Trilinos issueshttps://gitlab.osti.gov/jmwille/Trilinos/-/issues2019-04-23T23:01:23Zhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4960Ifpack2_Relaxation_def.hpp variable template C++14 extension warning breaking...2019-04-23T23:01:23ZJames WillenbringIfpack2_Relaxation_def.hpp variable template C++14 extension warning breaking SPARC Trilinos Integration builds starting 4/18/2019*Created by: bartlettroscoe*
CC: @trilinos/ifpack2, @srajama1 (Trilinos Linear Solvers Product Lead), @bartlettroscoe, @fryeguy52
<Checklist>
<???: Add label "client: ATDM">
<???: Add label "ATDM Sev: Blocker" (by default but coul...*Created by: bartlettroscoe*
CC: @trilinos/ifpack2, @srajama1 (Trilinos Linear Solvers Product Lead), @bartlettroscoe, @fryeguy52
<Checklist>
<???: Add label "client: ATDM">
<???: Add label "ATDM Sev: Blocker" (by default but could be other "ATDM Sev: XXX")>
<???: Add label "type: bug"?>
<???: Add label for affected packages (e.g. "pkg: MueLu", "pkg: Tpetra", "pkg: Kokkos", etc.)>
<???: Add label "PA: ???Project Area???" (e.g. "PA: Linear Solvers", "PA: Data Services")>
<???: Add milestone "Initial cleanup of new ATDM ..." or "Keep promoted ATDM ...">
<???: Once GitHub Issue is created, add entries for tests to TrilinosATDMStatus/*.csv files>
## Next Action Status
<status-and-or-first-action>
## Description
The new warning elevated to an error:
```
Ifpack2_Relaxation_def.hpp:147:6: error: variable templates are a C++14 extension [-Werror,-Wc++14-extensions]
void Relaxation::updateCachedMultiVector(const Teuchos::RCP > & map, size_t numVecs) const{
^
```
is breaking the SPARC Trilinos integration builds as shown [here](http://compsim-dashboard.sandia.gov/cdash/index.php?project=SPARC&date=2019-04-18&filtercount=1&showfilters=1&field1=buildname&compare1=66&value1=-trildev) with that warning being shown [here](http://compsim-dashboard.sandia.gov/cdash/viewBuildError.php?buildid=108404)
## Current Status on CDash
* [sparc-alltpls_cee-cpu_clang-5.0.1_openmpi-1.10.2_static_opt-trildev builds over last 5 days](http://compsim-dashboard.sandia.gov/cdash/index.php?project=SPARC&date=2019-04-18&filtercombine=and&filtercount=2&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=sparc-alltpls_cee-cpu_clang-5.0.1_openmpi-1.10.2_static_opt-trildev&field2=buildstarttime&compare2=83&value2=5%20days%20ago)
## Steps to Reproduce
I can't see this warning being generated in the [Ifack2 package build itself for the build Trilinos-atdm-cee-rhel6_clang-5.0.1_openmpi-1.10.2_serial_static_opt](https://testing.sandia.gov/cdash-dev-view/viewBuildError.php?type=1&buildid=4910167) so I am not sure one can reproduce this just with Trilinos. (Does this suggest a lack of test coverage for Ifpack2?)
But if one can get on the CEE LAN and can clone the SPARC repos, then one can reproduce using the scripts described [here](https://snl-wiki.sandia.gov/display/CoodinatedDevOpsATDM/Building+ATDM+APPs+Against+Local+Installs+of+Trilinos#BuildingATDMAPPsAgainstLocalInstallsofTrilinos-BuildingandTestingSPARCAgainstLocalTrilinosInstallation). After getting Trilinos on to the 'develop' branch as described [here](https://snl-wiki.sandia.gov/display/CoodinatedDevOpsATDM/Building+ATDM+APPs+Against+Local+Installs+of+Trilinos#BuildingATDMAPPsAgainstLocalInstallsofTrilinos-BuildingagainstTrilinos'develop'usingtheATDMTrilinosconfiguration), one can reproduce this using the command:
```
$ cd sparc/
$ env \
ATDM_TRIL_SPARC_BUILDS_LIST=cee-rhel6_clang-5.0.1_openmpi-1.10.2_serial_static_opt \
ATDM_TRIL_SPARC_SKIP_NATIVE_BUILD=1 \
./sparc-tril-dev-scripts/run_builds_and_tests.sh
```
Keep promoted "ATDM" builds of Trilinos clean