Trilinos issueshttps://gitlab.osti.gov/jmwille/Trilinos/-/issues2016-12-02T18:49:12Zhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/277Remove bracket operator use from discretization tools2016-12-02T18:49:12ZJames WillenbringRemove bracket operator use from discretization tools*Created by: rppawlo*
Kokkos implemented a nasty hack to support bracket operator use in Intrepid. Long term we need to eliminate the use of bracket operator from all discretization tools that use Kokkos. Phalanx has acceptance tests th...*Created by: rppawlo*
Kokkos implemented a nasty hack to support bracket operator use in Intrepid. Long term we need to eliminate the use of bracket operator from all discretization tools that use Kokkos. Phalanx has acceptance tests that check this behavior for calling Intrepid. Below is the email discussion with Carter:
Would be easy to implement but dangerous to use.
A subview or any kind of non-contiguous view cannot be linearly indexed
and will have silent errors when doing so.
In DynRankView:
```
operator[]( int i ) const { return data()[i]; }
```
On 4/6/16, 2:03 PM, "Pawlowski, Roger P" rppawlo@sandia.gov wrote:
> Hi Nathan,
>
> It seems that the bracket operator on the DynRankView only works for a
> rank 1 array. The use case we have with Intrepid is that if I allocate
> a view with rank greater than 1:
>
> DynRankView<double> a(10,2);
>
> Then the bracket operator should give me access to all twenty entries in
> the array (e.g. a[19] should work). For the DynRankView in Phalanx, I
> just carried around a second member internally that the bracket operator
> implementation used:
>
> m_field_oned_view =
> array_oned_type(m_field_data7.ptr_on_device(),m_field_data7.size(),PHX::ge
> tSacadoSize(m_field_data7));
>
> Can we get something similar to this in the kokkos DynRankView? Long
> term I we would like to eliminate bracket operator, but that will take
> quite a bit of refactoring in intrepid.
>
> Roger
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/181Belos::LinearProblem should unset itself if preconditioner is set2016-03-07T02:23:48ZJames WillenbringBelos::LinearProblem should unset itself if preconditioner is set*Created by: mhoemmen*
@hkthorn @trilinos/belos
See discussion here: https://github.com/UK-MAC/TeaLeaf_Trilinos/issues/2
*Created by: mhoemmen*
@hkthorn @trilinos/belos
See discussion here: https://github.com/UK-MAC/TeaLeaf_Trilinos/issues/2
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/8Muelu installs various files twice2016-03-07T23:12:34ZJames WillenbringMuelu installs various files twice*Created by: nschloe*
When checking for files which are overridden during the installation process, one finds that Muelu contains a few of them
```
$ make install
$ sort install_manifest.txt | uniq --count --repeated
2 /opt/trili...*Created by: nschloe*
When checking for files which are overridden during the installation process, one finds that Muelu contains a few of them
```
$ make install
$ sort install_manifest.txt | uniq --count --repeated
2 /opt/trilinos/private/include/trilinos/KokkosCompat_ClassicNodeAPI_Wrapper.hpp
2 /opt/trilinos/private/include/trilinos/KokkosCompat_TMM.hpp
2 /opt/trilinos/private/include/trilinos/KokkosCompat_View_def.hpp
2 /opt/trilinos/private/include/trilinos/KokkosCompat_View.hpp
2 /opt/trilinos/private/include/trilinos/MueLu_AdaptiveSaMLParameterListInterpreter.hpp
2 /opt/trilinos/private/include/trilinos/MueLu_config.hpp
2 /opt/trilinos/private/include/trilinos/MueLu_FactoryFactory.hpp
2 /opt/trilinos/private/include/trilinos/MueLu_MLParameterListInterpreter.hpp
2 /opt/trilinos/private/include/trilinos/MueLu_ParameterListInterpreter.hpp
2 /opt/trilinos/private/include/trilinos/MueLu_RefMaxwell.hpp
2 /opt/trilinos/private/include/trilinos/MueLu_ShiftedLaplacian.hpp
2 /opt/trilinos/private/include/trilinos/MueLu_ShiftedLaplacianOperator.hpp
2 /opt/trilinos/private/include/trilinos/MueLu_TpetraOperator.hpp
2 /opt/trilinos/private/include/trilinos/TeuchosKokkosCompat_config.h
2 /opt/trilinos/private/include/trilinos/Thyra_MueLuPreconditionerFactory.hpp
2 /opt/trilinos/private/include/trilinos/Tpetra_CrsMatrixSolveOp.hpp
```
The reason for this is that the Muelu configuration installs multiple files with the same name in the same directory. It is not clear if the contents are the same, too, or if this actually presents a serious bug.
(From https://software.sandia.gov/bugzilla/show_bug.cgi?id=6428).
@trilinos/muelu
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/24duplicate TPL adapters2016-03-23T06:14:42ZJames Willenbringduplicate TPL adapters*Created by: nschloe*
In Trilinos, TriBits takes care of some of the TPL integration via the files in
```
cmake/tribits/common_tpls/FindTPL*.cmake
```
Their counterparts in
```
cmake/TPLs/FindTPL*.cmake
```
are redundant and should ...*Created by: nschloe*
In Trilinos, TriBits takes care of some of the TPL integration via the files in
```
cmake/tribits/common_tpls/FindTPL*.cmake
```
Their counterparts in
```
cmake/TPLs/FindTPL*.cmake
```
are redundant and should probably be removed.
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/21Reorganize Belos adapters into subpackages2016-03-07T23:11:02ZJames WillenbringReorganize Belos adapters into subpackages*Created by: nschloe*
Belos offers [a number of adapters](https://github.com/trilinos/Trilinos/tree/master/packages/belos) for their linear solvers, most notably Epetra and Tpetra. Unfortunately, there is no adapter for Thyra though. – ...*Created by: nschloe*
Belos offers [a number of adapters](https://github.com/trilinos/Trilinos/tree/master/packages/belos) for their linear solvers, most notably Epetra and Tpetra. Unfortunately, there is no adapter for Thyra though. – Oh wait, [there is one](https://github.com/trilinos/Trilinos/blob/master/packages/stratimikos/adapters/belos/src/BelosThyraAdapter.hpp)! In Stratimikos.