Trilinos issueshttps://gitlab.osti.gov/jmwille/Trilinos/-/issues2019-04-06T09:36:26Zhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4785Zoltan2: MJ giving unbalanced parts for large structured data2019-04-06T09:36:26ZJames WillenbringZoltan2: MJ giving unbalanced parts for large structured data*Created by: kddevin*
<!---
Provide a general summary of the issue in the Title above. If this issue
pertains to a particular package in Trilinos, it's worthwhile to start the
title with "PackageName: ".
-->
<!---
Note that an...*Created by: kddevin*
<!---
Provide a general summary of the issue in the Title above. If this issue
pertains to a particular package in Trilinos, it's worthwhile to start the
title with "PackageName: ".
-->
<!---
Note that anything between these delimiters is a comment that will not appear
in the issue description once created. Click on the Preview tab to see what
everything will look like when you submit.
-->
<!---
Feel free to delete anything from this template that is not applicable to the
issue you are submitting.
-->
<!---
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/zoltan2
<!---
Assignees: If you know anyone who should likely tackle this issue, select them
from the Assignees drop-down on the right.
-->
<!---
Lables: Choose any applicable package names from the Labels drop-down on the
right. Additionally, choose a label to indicate the type of issue, for
instance, bug, build, documentation, enhancement, etc.
-->
## Expectations
For uniformly weighted input, MJ should return balanced parts when not using rectilinear blocks.
## Current Behavior
For large structured data, MJ can return unbalanced parts.
For example, running with 9M points selected as integers within a 1000x1000x1000 cube and dividing into 64 parts, MJ returns imbalance of 3, with half of the parts empty.
```
myGlobalId_t = i 4; localCount = 9000000; globalCount = 9000000
Test: no weights, scalar = double
Imbalance Metrics: (64 existing parts) (32 of which are non-empty)
min max avg imbalance
object count 0 4.219e+05 1.406e+05 3
```
This result is consistent regardless of whether the coordinates are given to MJ as integers or doubles.
## Motivation and Context
<!---
How has this expectation failure affected you? What are you trying to
accomplish? Why do we need to address this? What does it have to do with
anything? Providing context helps us come up with a solution that is most
useful in the real world.
-->
I'd like to partition the nonzeros of a tensor with MJ, but for large-enough tensors, the resulting partition is not balanced.
## Definition of Done
<!---
Tell us what needs to happen. If necessary, give us a task list along the
lines of:
- [ ] First do this.
- [ ] Then do that.
- [ ] Also this other thing.
-->
MJ returns balanced parts for this use case.
## Possible Solution
<!---
Not obligatory, but suggest a fix for the bug or documentation, or suggest
ideas on how to implement the addition or change.
-->
## Steps to Reproduce
<!---
Provide a link to a live example, or an unambiguous set of steps to reproduce
this issue. Include code to reproduce, if relevant.
1. Do this.
1. Do that.
1. Shake fist angrily at computer.
-->
New test problem zoltan2/test/partition/mj_imbalanced.cpp demonstrates the problem.
Running on one processor:
Zoltan2_mj_imbalanced.exe
## Your Environment
<!---
Include relevant details about your environment such that we can replicate this
issue.
-->
- **Relevant repo SHA1s:**
- **Relevant configure flags or configure script:**
- **Operating system and version:**
- **Compiler and TPL versions:**
77f266c4c5f8c2135b922c299ea531d221a2df5c
All platforms
## Related Issues
<!---
If applicable, let us know how this bug is related to any other open issues:
-->
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
## Additional Information
<!---
Anything else that might be helpful for us to know in addressing this issue:
* Configure log file:
* Build log file:
* Test log file:
* When was the last time everything worked (date/time; SHA1s; etc.)?
* What did you do that made the bug rear its ugly head?
* Have you tried turning it off and on again?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4736INSTALLING TRILINOS(ML SOLVER)2019-04-15T18:32:55ZJames WillenbringINSTALLING TRILINOS(ML SOLVER)*Created by: chandu1263*
<!---
Provide a general summary of the issue in the Title above. If this issue
pertains to a particular package in Trilinos, it's worthwhile to start the
title with "PackageName: ".
-->
<!---
Note that...*Created by: chandu1263*
<!---
Provide a general summary of the issue in the Title above. If this issue
pertains to a particular package in Trilinos, it's worthwhile to start the
title with "PackageName: ".
-->
<!---
Note that anything between these delimiters is a comment that will not appear
in the issue description once created. Click on the Preview tab to see what
everything will look like when you submit.
-->
<!---
Feel free to delete anything from this template that is not applicable to the
issue you are submitting.
-->
<!---
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/<teamName>
<!---
Assignees: If you know anyone who should likely tackle this issue, select them
from the Assignees drop-down on the right.
-->
<!---
Lables: Choose any applicable package names from the Labels drop-down on the
right. Additionally, choose a label to indicate the type of issue, for
instance, bug, build, documentation, enhancement, etc.
-->
## Expectations
<!---
Tell us what you think should happen, how you think things should work, what
you would like to see in the documentation, etc.
-->
## Current Behavior
<!---
Tell us how the current behavior fails to meet your expectations in some way.
-->
## Motivation and Context
<!---
How has this expectation failure affected you? What are you trying to
accomplish? Why do we need to address this? What does it have to do with
anything? Providing context helps us come up with a solution that is most
useful in the real world.
-->
## Definition of Done
<!---
Tell us what needs to happen. If necessary, give us a task list along the
lines of:
- [ ] First do this.
- [ ] Then do that.
- [ ] Also this other thing.
-->
## Possible Solution
<!---
Not obligatory, but suggest a fix for the bug or documentation, or suggest
ideas on how to implement the addition or change.
-->
## Steps to Reproduce
<!---
Provide a link to a live example, or an unambiguous set of steps to reproduce
this issue. Include code to reproduce, if relevant.
1. Do this.
1. Do that.
1. Shake fist angrily at computer.
-->
## Your Environment
<!---
Include relevant details about your environment such that we can replicate this
issue.
-->
- **Relevant repo SHA1s:**
- **Relevant configure flags or configure script:**
- **Operating system and version:**
- **Compiler and TPL versions:**
## Related Issues
<!---
If applicable, let us know how this bug is related to any other open issues:
-->
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
## Additional Information
<!---
Anything else that might be helpful for us to know in addressing this issue:
* Configure log file:
* Build log file:
* Test log file:
* When was the last time everything worked (date/time; SHA1s; etc.)?
* What did you do that made the bug rear its ugly head?
* Have you tried turning it off and on again?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4778PanzerAdaptersSTK test timing out in ATDM build on white/ride2019-05-02T17:57:09ZJames WillenbringPanzerAdaptersSTK test timing out in ATDM build on white/ride*Created by: fryeguy52*
CC: @trilinos/panzer, @mperego (Trilinos Discretizations Product Lead), @bartlettroscoe, @fryeguy52
## Next Action Status
## Description
As shown in [this query](https://testing.sandia.gov/cdash/que...*Created by: fryeguy52*
CC: @trilinos/panzer, @mperego (Trilinos Discretizations Product Lead), @bartlettroscoe, @fryeguy52
## Next Action Status
## Description
As shown in [this query](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=5&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=Trilinos-atdm-white-ride-cuda-9.2-gnu-7.2.0-release-debug&field2=testname&compare2=61&value2=PanzerAdaptersSTK_MixedCurlLaplacianExample-ConvTest-Tri-Order-1&field3=site&compare3=61&value3=white&field4=buildstarttime&compare4=84&value4=2019-03-31&field5=buildstarttime&compare5=83&value5=2019-02-28) the test:
* PanzerAdaptersSTK_MixedCurlLaplacianExample-ConvTest-Tri-Order-1
is failing (timeout) in the build:
* Trilinos-atdm-white-ride-cuda-9.2-gnu-7.2.0-release-debug
It started to timeout on ride on 2019-03-20. Prior to that day it was taking about 9 minutes to complete. A list of commits on that day can be found [here](https://testing.sandia.gov/cdash/viewNotes.php?buildid=4755222#!#note1)
## Current Status on CDash
The current status of this test can be seen [here](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=4&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=Trilinos-atdm-white-ride-cuda-9.2-gnu-7.2.0-release-debug&field2=testname&compare2=61&value2=PanzerAdaptersSTK_MixedCurlLaplacianExample-ConvTest-Tri-Order-1&field3=buildstarttime&compare3=84&value3=today&field4=buildstarttime&compare4=83&value4=yesterday)
## Steps to Reproduce
One should be able to reproduce this failure on ride or white as described in:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md
More specifically, the commands given for ride or white are provided at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md#ridewhite
The exact commands to reproduce this issue should be:
```
$ cd <some_build_dir>/
$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh Trilinos-atdm-white-ride-cuda-9.2-gnu-7.2.0-release-debug
$ cmake \
-GNinja \
-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
-DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_Panzer=ON \
$TRILINOS_DIR
$ make NP=16
$ bsub -x -Is -q rhel7F -n 16 ctest -j16
```Keep promoted "ATDM" builds of Trilinos cleanhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4771Errors compiling Trilinos with TriKota 2019-04-01T21:52:43ZJames WillenbringErrors compiling Trilinos with TriKota *Created by: ikalash*
I am trying to revive our Albany tests that use TriKota, which we have not run for awhile (on the order of a year or two). I am getting the following compilation error when I try to compile it:
```
[ 30%] Bui...*Created by: ikalash*
I am trying to revive our Albany tests that use TriKota, which we have not run for awhile (on the order of a year or two). I am getting the following compilation error when I try to compile it:
```
[ 30%] Building CXX object packages/TriKota/Dakota/src/CMakeFiles/dakota_src.dir/ParallelLibrary.cpp.o
/home/ikalash/nightlyAlbanyTests/Results/Trilinos/packages/TriKota/Dakota/packages/pecos/util/src/linear_algebra.cpp: In function ‘void Pecos::util::GEMV(Teuchos::ETransp, bool, ScalarType, const Teuchos::SerialDenseMatrix<OrdinalType, ScalarType>&, const Teuchos::SerialDenseVector<OrdinalType, ScalarType>&, ScalarType, Teuchos::SerialDenseVector<OrdinalType, ScalarType>&) [with OrdinalType = int; ScalarType = std::complex<double>]’:
/home/ikalash/nightlyAlbanyTests/Results/Trilinos/packages/TriKota/Dakota/packages/pecos/util/src/linear_algebra.cpp:84:3: error: ‘ZGEMV_F77’ was not declared in this scope
ZGEMV_F77( &T, &M, &N, &alpha,
^~~~~~~~~
/home/ikalash/nightlyAlbanyTests/Results/Trilinos/packages/TriKota/Dakota/packages/pecos/util/src/linear_algebra.cpp:84:3: note: suggested alternative: ‘SGEMV_F77’
ZGEMV_F77( &T, &M, &N, &alpha,
^~~~~~~~~
SGEMV_F77
```
I am using dakota 6.9 public release, and this is on a Fedora 29, with gcc-8.3.1. Could someone please help me resolve the issue? It's possible I am not using the right Dakota version, or there is some option I'm missing in my configure script (as I said, I haven't tried to build with Dakota in awhile).
@trilinos/trikota https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4776Apply for Google's Season of Docs2019-04-05T13:44:55ZJames WillenbringApply for Google's Season of Docs*Created by: jmgate*
## What is It?
The [Software Sustainability Institute](https://www.software.ac.uk/) recently had [a blog post](https://www.software.ac.uk/blog/2019-03-26-season-docs-fostering-open-source-collaboration-tech-writers...*Created by: jmgate*
## What is It?
The [Software Sustainability Institute](https://www.software.ac.uk/) recently had [a blog post](https://www.software.ac.uk/blog/2019-03-26-season-docs-fostering-open-source-collaboration-tech-writers?mc_cid=19c554b05e&mc_eid=96b055f1e9) introducing Google's [Season of Docs](https://developers.google.com/season-of-docs/). The goal of the project is to pair technical writers with open source projects in need of documentation for a three month period starting in September of this year.
> In case you're familiar with it, this is similar to Google's [Summer of Code](https://developers.google.com/open-source/gsoc/2008/) project from years ago.
## What's the Timeline Look Like?
The complete timeline [is available here](https://developers.google.com/season-of-docs/docs/timeline), but the parts we need to be aware of are:
* April 2nd–23rd: Submit application to Google
* April 30th: Selection of organizations announced
* September 2nd: Doc writing officially starts
* November 29th: Tech writer submits final work products
## Who Pays for What?
Google will pay the technical writer ~$6,000 (adjusted for cost of living) over the three month period. They also supply some smaller amount of funding to the institution for the sake of mentoring the technical writer over the course of the season.
## How Does the Tech Writer Do the Work?
They work remotely from wherever they happen to be, using whatever remote collaboration means the mentoring organization uses. For us, that'd mean we'd communicate via GitHub issues and pull requests, and if we need to speak in person, we could give them a call. If Sandia wants to fly them out to meet/work in person, that's on us. There's no need on our end for actual hiring, onboarding, etc.
## What Do We Need to Do?
- [ ] First we need to identify two organization administrators (a primary and a backup) to manage our participation in Season of Docs. I can be one of these, though I don't need to be.
- [ ] Generate a list of project ideas. These would be specific tasks that will be accomplished in the three-month program. There's no need to adhere to these 100% once the program starts, but they are intended to give technical writers an accurate idea of what they might be doing with us. To decide what we'd like to focus on, we probably want to bring this up at the next Trilinos leaders' meeting (@maherou, @rppawlo, @mperego, @kddevin, @srajama1, @jwillenbring). If that's too far away, we should probably set up a Skype meeting sooner, because we don't have too much time to get an application together.
- [ ] Given the specific tasks above, we need to identify at least two mentors to help bring the tech writer on board and oversee their work throughout the season.
- [ ] Then we need to submit our application within the next three weeks.
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4770Deprecation in Tpetra::CrsMatrix constructor triggers warning in Xpetra that ...2019-04-12T12:45:03ZJames WillenbringDeprecation in Tpetra::CrsMatrix constructor triggers warning in Xpetra that crashes the SPARC build*Created by: bartlettroscoe*
CC: @trilinos/xpetra, @trilinos/tpetra , @kddevin (Trilinos Data Services Product Lead), @bartlettroscoe, @fryeguy52, @mhoemmen
## Next Action Status
<status-and-or-first-action>
## Description
...*Created by: bartlettroscoe*
CC: @trilinos/xpetra, @trilinos/tpetra , @kddevin (Trilinos Data Services Product Lead), @bartlettroscoe, @fryeguy52, @mhoemmen
## Next Action Status
<status-and-or-first-action>
## Description
The commit 24cef7553e09f35f08a8c93bd3c7f8dab5aeb3ea merged in PR #4748 deprecated a constructor for `Tpetra::CrsMatrix` and triggered a deprecated warning when SPARC builds showing the error:
```
/projects/atdm_devops/trilinos_installs/2019-03-29/cee-rhel6_clang-5.0.1_openmpi-1.10.2_serial_static_opt/include/Xpetra_TpetraCrsMatrix.hpp:109:31: error: 'CrsMatrix' is deprecated [-Werror,-Wdeprecated-declarations]
: mtx_(Teuchos::rcp(new Tpetra::CrsMatrix (toTpetra(rowMap), NumEntriesPerRowToAlloc, toTpetra(pftype), params))) { }
```
This deprecated warning (elevated to an error in SPARC because they set `-Werror`) is triggered inside of Trilinos headers but is not shown in the Xpetra test suite shown [here](https://testing.sandia.gov/cdash-dev-view/index.php?project=Trilinos&parentid=4809252). Does this show a gap in the automated tests for Xpetra?
## Current Status on CDash
The current status can only be seen in the SPARC Trilinos Integration builds shown over the last few days [here](http://compsim-dashboard.sandia.gov/cdash/index.php?project=SPARC&date=2019-03-30&filtercombine=and&filtercount=2&showfilters=1&filtercombine=and&field1=buildname&compare1=66&value1=-trildev&field2=buildstarttime&compare2=83&value2=5%20days%20ago).
## Steps to Reproduce
Since the native test suite does not show a problem, one can only reproduce this by building SPARC itself. See the instructions for doing that [here](https://snl-wiki.sandia.gov/display/CoodinatedDevOpsATDM/Building+ATDM+APPs+Against+Local+Installs+of+Trilinos#BuildingATDMAPPsAgainstLocalInstallsofTrilinos-BuildingagainsttheSPARCTrilinos'master'versionusingthenativeSPARCTrilinosconfigurationscripts).
But if one wants to reproduce say the `clang-5.0.1` build on a CEE RHEL6 machine, one can follow the instructions at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md
More specifically, the commands given for the system 'cee-rhel6' are provided at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md#cee-rhel6-environment
The exact commands to reproduce this issue should be:
```
$ cd <some_build_dir>/
$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh \
Trilinos-atdm-cee-rhel6_clang-5.0.1_openmpi-1.10.2_serial_static_opt
$ cmake \
-GNinja \
-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
-DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_Xpetra=ON \
$TRILINOS_DIR
$ make NP=16
```
But of course that does not show a warning so Xpetra needs to be upgraded to reproduce that warning.Keep promoted "ATDM" builds of Trilinos cleanhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4738Intrepid2_unit-test_Projection_Serial_Test_InterpolationProjection_TET_MPI_1 ...2019-04-03T19:48:10ZJames WillenbringIntrepid2_unit-test_Projection_Serial_Test_InterpolationProjection_TET_MPI_1 failing ATDM mutrino build*Created by: fryeguy52*
CC: @trilinos/intrepid2, @mperego (Trilinos Discretizations Product Lead), @bartlettroscoe, @fryeguy52
## Next Action Status
<status-and-or-first-action>
## Description
As shown in [this query](https...*Created by: fryeguy52*
CC: @trilinos/intrepid2, @mperego (Trilinos Discretizations Product Lead), @bartlettroscoe, @fryeguy52
## Next Action Status
<status-and-or-first-action>
## Description
As shown in [this query](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercount=5&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=Trilinos-atdm-mutrino-intel-opt-openmp-HSW&field2=testname&compare2=61&value2=Intrepid2_unit-test_Projection_Serial_Test_InterpolationProjection_TET_MPI_1&field3=site&compare3=61&value3=mutrino&field4=buildstarttime&compare4=84&value4=2019-03-27T00%3A00%3A00&field5=buildstarttime&compare5=83&value5=2019-02-25T00%3A00%3A00) the test:
* `Intrepid2_unit-test_Projection_Serial_Test_InterpolationProjection_TET_MPI_1`
started failing in the build:
* `Trilinos-atdm-mutrino-intel-opt-openmp-HSW`
starting on 2019-03-26
test output can be found [here](https://testing.sandia.gov/cdash/testDetails.php?test=72286414&build=4781169)
new commits on the day it started failing can be found [here](https://testing.sandia.gov/cdash/viewNotes.php?buildid=4781164#!#note7)
## Current Status on CDash
current status can be found [here](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercount=5&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=Trilinos-atdm-mutrino-intel-opt-openmp-HSW&field2=testname&compare2=61&value2=Intrepid2_unit-test_Projection_Serial_Test_InterpolationProjection_TET_MPI_1&field3=site&compare3=61&value3=mutrino&field4=buildstarttime&compare4=84&value4=today&field5=buildstarttime&compare5=83&value5=yesterday)
## Steps to Reproduce
One should be able to reproduce this failure on mutrino as described in:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md
More specifically, the commands given for mutrino are provided at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md#mutrino
The exact commands to reproduce this issue should be:
```
$ cd <some_build_dir>/
$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh Trilinos-atdm-mutrino-intel-opt-openmp-HSW
$ cmake \
-GNinja \
-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
-DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_Intrepid2=ON \
$TRILINOS_DIR
$ make NP=16
$ salloc -N 1 -p standard -J $ATDM_CONFIG_JOB_NAME ctest -j16
```
Keep promoted "ATDM" builds of Trilinos cleanhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4731Teuchos: VerboseObject fix filestreams2019-04-04T05:26:32ZJames WillenbringTeuchos: VerboseObject fix filestreams*Created by: jjellio*
Currently, VerboseObject provides an option to allow output to be redirected to a file. Unfortunately, this feature results in every MPI process opening/writing the file, which is not typically what an OStream is u...*Created by: jjellio*
Currently, VerboseObject provides an option to allow output to be redirected to a file. Unfortunately, this feature results in every MPI process opening/writing the file, which is not typically what an OStream is used to accomplish. For file output, this implementation leads to extreme performance degradation with large parallel jobs.
@trilinos/teuchos @bartlettroscoe @mhoemmen
## Expectations
VerboseObject should write to a single file (and be as performant at stdout.
## Current Behavior
Currently, we open multiple files and typically write exactly the same data to the same file. This gives the illusion of working as intended. Since the file will actually be correct at the end of the run. The issue is that every MPI process is writing the data, and this is not intended.
## Motivation and Context
ATDM apps would like to use this functionality. We uncovered/identified this issue by running with VerboseObject output to files with >64 nodes.
## Possible Solution
This fix is straightforward, and is addressed in PR#4629
(This is an issue to map to the PR... I should create the issues first in the future ... woops!)https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4729Tpetra: std::call_once does not work well with gcc serial builds2019-03-28T19:11:34ZJames WillenbringTpetra: std::call_once does not work well with gcc serial builds*Created by: kddevin*
<!---
Provide a general summary of the issue in the Title above. If this issue
pertains to a particular package in Trilinos, it's worthwhile to start the
title with "PackageName: ".
-->
@trilinos/tpetra @egb...*Created by: kddevin*
<!---
Provide a general summary of the issue in the Title above. If this issue
pertains to a particular package in Trilinos, it's worthwhile to start the
title with "PackageName: ".
-->
@trilinos/tpetra @egboman
Recall from #3057:
Use of std::call_once with gcc in serial builds requires TPL_ENABLE_PThread=ON.
This requirement is not obvious to the user; indeed, only because I had been bitten by it once before (#3033) did I know that info was available in a github issue. Most users will not guess that Pthreads is required for a serial build (nor should they).
Use of std::call_once has been reintroduced in Tpetra_Details_Behavior.cpp.
Is it necessary? Can it be removed?
## Expectations
Serial configurations should not need to specify TPL Pthreads to work correctly with Tpetra.
## Current Behavior
std::call_once crashes in serial Trilinos builds without TPL_ENABLE_Pthread=ON.
## Motivation and Context
@egboman is trying to run serial coloring algorithms in Zoltan2 on his Linux workstation. Tpetra CrsMatrix construction fails because std::call_once fails in fetching debug environment variables in CrsGraph constructor.
## Definition of Done
I hope: std::call_once removed from Tpetra; I hate being bitten twice by the same bug.
## Steps to Reproduce
build serial Trilinos with Zoltan2 and TPL_ENABLE_Pthread=OFF
make test
## Your Environment
On @egboman's workstation
module purge
module load sems-env
module load sems-cmake
module load sems-gcc/4.9.3
cmake \
-D CMAKE_BUILD_TYPE:STRING=DEBUG \
-D BUILD_SHARED_LIBS:BOOL=ON \
-D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=OFF \
-D Trilinos_ENABLE_EXPLICIT_INSTANTIATION:BOOL=ON \
-D Trilinos_ENABLE_Zoltan2:BOOL=ON \
-D Zoltan2_ENABLE_Experimental:BOOL=ON \
-D Trilinos_ENABLE_TESTS:BOOL=ON \
-D TPL_BLAS_LIBRARIES="/usr/lib64/libblas.so.3" \
-D TPL_LAPACK_LIBRARIES="/usr/lib64/liblapack.so.3" \
..
92bf4f0867cd171f89afcfd0a2266d33fd77de39
## Related Issues
<!---
If applicable, let us know how this bug is related to any other open issues:
-->
Same as #3057
Related to #3033
## Additional Information
<!---
Anything else that might be helpful for us to know in addressing this issue:
* Configure log file:
* Build log file:
* Test log file:
* When was the last time everything worked (date/time; SHA1s; etc.)?
* What did you do that made the bug rear its ugly head?
* Have you tried turning it off and on again?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4724STKBalance tests failing on ATDM cee intel builds 2019-04-21T01:52:22ZJames WillenbringSTKBalance tests failing on ATDM cee intel builds *Created by: fryeguy52*
CC: @trilinos/stk, @kddevin (Trilinos Data Services Product Lead), @bartlettroscoe, @fryeguy52
## Next Action Status
<status-and-or-first-action>
## Description
As shown in [this query](https://testi...*Created by: fryeguy52*
CC: @trilinos/stk, @kddevin (Trilinos Data Services Product Lead), @bartlettroscoe, @fryeguy52
## Next Action Status
<status-and-or-first-action>
## Description
As shown in [this query](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=7&showfilters=1&filtercombine=and&field1=buildname&compare1=65&value1=Trilinos-atdm-cee-rhel6_intel-&field2=buildname&compare2=63&value2=static_opt&field3=testname&compare3=65&value3=STKBalance_stk_balance_&field4=testname&compare4=66&value4=_MPI_4&field5=site&compare5=61&value5=cee-rhel6&field6=buildstarttime&compare6=84&value6=2019-03-26T00%3A00%3A00&field7=buildstarttime&compare7=83&value7=2019-02-24T00%3A00%3A00) the tests:
* STKBalance_stk_balance_m2n_MPI_4
* STKBalance_stk_balance_MPI_4
are failing in the builds:
* Trilinos-atdm-cee-rhel6_intel-18.0.2_mpich2-3.2_openmp_static_opt
* Trilinos-atdm-cee-rhel6_intel-17.0.1_intelmpi-5.1.2_serial_static_opt
They are failing with s segmentation fault:
```
===================================================================================
= BAD TERMINATION OF ONE OF YOUR APPLICATION PROCESSES
= PID 37762 RUNNING AT ceerws1113
= EXIT CODE: 139
= CLEANING UP REMAINING PROCESSES
= YOU CAN IGNORE THE BELOW CLEANUP MESSAGES
===================================================================================
YOUR APPLICATION TERMINATED WITH THE EXIT STRING: Segmentation fault (signal 11)
This typically refers to a problem with your application.
Please see the FAQ page for debugging suggestions
```
new commits for that build can be found [here](https://testing.sandia.gov/cdash/viewNotes.php?buildid=4761571#!#note1)
## Current Status on CDash
[CDash results from the last testing day](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=7&showfilters=1&filtercombine=and&field1=buildname&compare1=65&value1=Trilinos-atdm-cee-rhel6_intel-&field2=buildname&compare2=63&value2=static_opt&field3=testname&compare3=65&value3=STKBalance_stk_balance_&field4=testname&compare4=66&value4=_MPI_4&field5=site&compare5=61&value5=cee-rhel6&field6=buildstarttime&compare6=84&value6=today&field7=buildstarttime&compare7=83&value7=yesterday)
## Steps to Reproduce
One should be able to reproduce this failure on a machine with a cee rhel6 environment as described in:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md
More specifically, the commands given for a machine with a cee rhel6 environment are provided at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md#cee-rhel6-environment
The exact commands to reproduce this issue should be:
```
$ cd <some_build_dir>/
$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh Trilinos-atdm-cee-rhel6_intel-18.0.2_mpich2-3.2_openmp_static_opt
$ cmake \
-GNinja \
-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
-DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_STK=ON \
$TRILINOS_DIR
$ make NP=16
$ ctest -j16
```
Keep promoted "ATDM" builds of Trilinos cleanhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4725NOX_LOCA_BrussXYZT_bdsdt_MPI_2 failing on ATDM serrano build2019-04-21T01:23:05ZJames WillenbringNOX_LOCA_BrussXYZT_bdsdt_MPI_2 failing on ATDM serrano build*Created by: fryeguy52*
CC: @trilinos/nox, @rppawlo (Trilinos Nonlinear Solvers Product Lead), @bartlettroscoe, @fryeguy52
<Checklist>
<???: Add label "ATDM">
<???: Add label "bug"?>
<???: Add label for affected packages (e.g. "M...*Created by: fryeguy52*
CC: @trilinos/nox, @rppawlo (Trilinos Nonlinear Solvers Product Lead), @bartlettroscoe, @fryeguy52
<Checklist>
<???: Add label "ATDM">
<???: Add label "bug"?>
<???: Add label for affected packages (e.g. "MueLu", "Tpetra", "Kokkos", etc.)>
<???: Add milestone "Initial cleanup of new ATDM builds of Trilinos" or "Keep promoted ATDM builds of Trilinos clean">
<???: Once GitHub Issue is created, add entries for tests to TrilinosATDMStatus/*.csv files>
<???: Add label "PA: ???Project Area???" (e.g. "PA: Linear Solvers", "PA: Data Services")>
## Next Action Status
<status-and-or-first-action>
## Description
As shown in [this query](<cdash-query-url) the tests:
* NOX_LOCA_BrussXYZT_bdsdt_MPI_2
are failing in the builds:
* Trilinos-atdm-serrano-intel-debug-openmp
Test output can be found [here](https://testing.sandia.gov/cdash/testDetails.php?test=72062077&build=4773277)
## Current Status on CDash
current status on cdash can be found [here](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercount=5&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=Trilinos-atdm-serrano-intel-debug-openmp&field2=testname&compare2=61&value2=NOX_LOCA_BrussXYZT_bdsdt_MPI_2&field3=site&compare3=61&value3=serrano&field4=buildstarttime&compare4=84&value4=today&field5=buildstarttime&compare5=83&value5=yesterday)
## Steps to Reproduce
One should be able to reproduce this failure on serrano as described in:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md
More specifically, the commands given for serrano are provided at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md#chamaserrano
The exact commands to reproduce this issue should be:
```
$ cd <some_build_dir>/
$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh Trilinos-atdm-serrano-intel-debug-openmp
$ cmake \
-GNinja \
-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
-DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_NOX=ON \
$TRILINOS_DIR
$ make NP=16
$ salloc -N1 --time=0:20:00 --account=<YOUR_WCID> ctest -j16
```Keep promoted "ATDM" builds of Trilinos cleanhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4698Tempus: Fix Divide by Zero2019-04-05T19:59:39ZJames WillenbringTempus: Fix Divide by Zero*Created by: ccober6*
In the relative norm calculation, the denominator is not check if zero during the consistency check.
@trilinos/tempus *Created by: ccober6*
In the relative norm calculation, the denominator is not check if zero during the consistency check.
@trilinos/tempus https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4693SPARC 'master' build error due to missing Tempus::createStepper()2019-04-03T03:08:09ZJames WillenbringSPARC 'master' build error due to missing Tempus::createStepper()*Created by: bartlettroscoe*
CC: @trilinos/tempus , @rppawlo (Trilinos Nonlinear Solvers Product Lead), @bartlettroscoe, @fryeguy52, @ccober6
## Next Action Status
<status-and-or-first-action>
## Description
As shown in [th...*Created by: bartlettroscoe*
CC: @trilinos/tempus , @rppawlo (Trilinos Nonlinear Solvers Product Lead), @bartlettroscoe, @fryeguy52, @ccober6
## Next Action Status
<status-and-or-first-action>
## Description
As shown in [this query](http://compsim-dashboard.sandia.gov/cdash/index.php?project=SPARC&date=2019-03-20&filtercombine=and&filtercount=2&showfilters=1&filtercombine=and&field1=buildname&compare1=66&value1=-trildev&field2=buildstarttime&compare2=83&value2=2019-03-16) the SPARC Trilinos integration builds that build SPARC 'master' against Trilinos 'develop' have a broken build of SPARC where the build error (for example for the `clang-5.0.1` build), shown [here](http://compsim-dashboard.sandia.gov/cdash/viewBuildError.php?buildid=102207)) show:
```
26: error: no matching member function for call to 'createStepper'
tempus_stepper_ = sf->createStepper(tempus_me_, "Backward Euler");
~~~~^~~~~~~~~~~~~
```
## Current Status on CDash
The status of these tests/builds for the current testing day can be found at:
* [SPARC Trilinos Integration Builds over last 5 days](http://compsim-dashboard.sandia.gov/cdash/index.php?project=SPARC&date=2019-03-20&filtercombine=and&filtercount=2&showfilters=1&filtercombine=and&field1=buildname&compare1=66&value1=-trildev&field2=buildstarttime&compare2=83&value2=5%20days%20ago)
NOTE: The build for the current testing day may not be posted at the time you click this link
## Steps to Reproduce
Instructions for building and installing Trilinos and then building and testing SPARC are given [here](https://snl-wiki.sandia.gov/display/CoodinatedDevOpsATDM/Building+ATDM+APPs+Against+Local+Installs+of+Trilinos#BuildingATDMAPPsAgainstLocalInstallsofTrilinos-BuildingandTestingSPARCAgainstLocalTrilinosInstallation).
To reproduce one will need to be in the SPARC development group to clone the SPARC git repos.
Keep promoted "ATDM" builds of Trilinos cleanhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4690Framework: can't access PR dashboard, insecure connection?2019-03-21T18:02:11ZJames WillenbringFramework: can't access PR dashboard, insecure connection?*Created by: jhux2*
@trilinos/framework
I can't access the PR dashboard, starting sometime on 3/21/2019. The URL is `https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&filtercount=1&showfilters=1&field1=buildname&compar...*Created by: jhux2*
@trilinos/framework
I can't access the PR dashboard, starting sometime on 3/21/2019. The URL is `https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&filtercount=1&showfilters=1&field1=buildname&compare1=65&value1=PR-`, and until yesterday, it worked fine.
The message is
![image](https://user-images.githubusercontent.com/12970120/54767602-b7bb0c80-4bba-11e9-8f6e-0e9a4b4a2dfb.png)
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4689Trilinos compilation error in Albany nightly due to Xpetra/MueLu 2019-03-21T16:39:02ZJames WillenbringTrilinos compilation error in Albany nightly due to Xpetra/MueLu *Created by: ikalash*
We have a new failing build in the Albany nightlies:
http://cdash.sandia.gov/CDash-2-3-0/viewBuildError.php?buildid=82719
It appears the problem is with @trilinos/xpetra , @trilinos/muelu . The compiler is ...*Created by: ikalash*
We have a new failing build in the Albany nightlies:
http://cdash.sandia.gov/CDash-2-3-0/viewBuildError.php?buildid=82719
It appears the problem is with @trilinos/xpetra , @trilinos/muelu . The compiler is gcc/8.2.1 . Note that Albany nightlies use master instead of develop branch of Trilinos. I changed it in hopes that it would be more stable (but I am rethinking that decision now...). https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4680Tpetra::CrsGraph, CrsMatrix: Constructor that takes an array of max row count...2019-03-29T22:29:16ZJames WillenbringTpetra::CrsGraph, CrsMatrix: Constructor that takes an array of max row counts, takes it by ArrayRCP, but doesn't actually keep the reference*Created by: mhoemmen*
@trilinos/tpetra @vbrunini
Both `Tpetra::CrsGraph` and `Tpetra::CrsMatrix` have constructors that take an array of the maximum number of entries in each row. The constructors take that array by `Teuchos::Arra...*Created by: mhoemmen*
@trilinos/tpetra @vbrunini
Both `Tpetra::CrsGraph` and `Tpetra::CrsMatrix` have constructors that take an array of the maximum number of entries in each row. The constructors take that array by `Teuchos::ArrayRCP<const size_t>`. Idiomatically, taking an ArrayRCP of const suggests that the class keeps a reference to the array, so that users shouldn't modify it. This is not what happens. Tpetra actually deep-copies the array.
We should thus change the constructors so they take either a raw array, or `Teuchos::ArrayView<const size_t>`. Once we have C++20, we can use `std::span`, which exactly expresses the desired idiom in native C++.
I found this by looking through Chaparral (@vbrunini of course has already fixed it to use StaticProfile, because he is just effective like that ;-) ). I saw that it was using a nonowning ArrayRCP there, and got worried, but then discovered that it didn't matter, since CrsGraph (and thus CrsMatrix) just deep-copies it.https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4679Framework: Pre-Merge Inspection Not Happening2019-03-21T15:49:18ZJames WillenbringFramework: Pre-Merge Inspection Not Happening*Created by: csiefer2*
This has been sitting for an hour since an approved review w/o pre-merge inspection #4672
@trilinos/framework @jwillenbring *Created by: csiefer2*
This has been sitting for an hour since an approved review w/o pre-merge inspection #4672
@trilinos/framework @jwillenbring https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4678Stratimikos and Rythmos tests failing on many ATDM builds2019-03-26T15:04:05ZJames WillenbringStratimikos and Rythmos tests failing on many ATDM builds*Created by: fryeguy52*
CC: @trilinos/stratimikos, @srajama1 (Trilinos Linear Solvers Product Lead), @rppawlo (Trilinos Nonlinear Solvers Product Lead), @bartlettroscoe, @fryeguy52
<Checklist>
<???: Add label "ATDM">
<???: Add lab...*Created by: fryeguy52*
CC: @trilinos/stratimikos, @srajama1 (Trilinos Linear Solvers Product Lead), @rppawlo (Trilinos Nonlinear Solvers Product Lead), @bartlettroscoe, @fryeguy52
<Checklist>
<???: Add label "ATDM">
<???: Add label "bug"?>
<???: Add label for affected packages (e.g. "MueLu", "Tpetra", "Kokkos", etc.)>
<???: Add milestone "Initial cleanup of new ATDM builds of Trilinos" or "Keep promoted ATDM builds of Trilinos clean">
<???: Once GitHub Issue is created, add entries for tests to TrilinosATDMStatus/*.csv files>
<???: Add label "PA: ???Project Area???" (e.g. "PA: Linear Solvers", "PA: Data Services")>
## Next Action Status
<status-and-or-first-action>
## Description
As shown in [this query](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&date=2019-03-20&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=5&showfilters=1&filtercombine=and&field1=groupname&compare1=61&value1=ATDM&field2=status&compare2=61&value2=Failed&field3=testname&compare3=62&value3=Ifpack2_BlockTriDiContainerUnitAndPerfTests_MPI_4&field4=buildstarttime&compare4=83&value4=2019-03-20&field5=buildstarttime&compare5=84&value5=2019-03-21) the tests:
* Stratimikos_test_single_stratimikos_solver_driver_belos_np_MPI_1
* Stratimikos_test_single_stratimikos_solver_driver_belos_ml_MPI_1
* Stratimikos_test_single_stratimikos_solver_driver_belos_ifpack_MPI_1
* Rythmos_timeDiscretizedBackwardEuler_amesos_MPI_1
are failing in many ATDM builds.
[new commits when these started failing](https://testing.sandia.gov/cdash/viewNotes.php?buildid=4754139#!#note4)
## Current Status on CDash
currently failing tests in ATDM builds can be seen [here](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&date=2019-03-20&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=4&showfilters=1&filtercombine=and&field1=groupname&compare1=61&value1=ATDM&field2=status&compare2=61&value2=Failed&field3=buildstarttime&compare3=83&value3=today&field4=buildstarttime&compare4=84&value4=tomorrow)
## Steps to Reproduce
One should be able to reproduce this failure on with a sems rhel6 environment as described in:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md
More specifically, the commands given for with a sems rhel6 environment are provided at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md#sems-rhel6-environment
The exact commands to reproduce this issue should be:
```
$ cd <some_build_dir>/
$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh Trilinos-atdm-sems-rhel6-gnu-7.2.0-openmp-release
$ cmake \
-GNinja \
-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
-DTrilinos_ENABLE_TESTS=ON \
-DTrilinos_ENABLE_Stratimikos=ON \
-DTrilinos_ENABLE_Rythmos=ON \
$TRILINOS_DIR
$ make NP=16
$ ctest -j8
```
Keep promoted "ATDM" builds of Trilinos cleanhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4669Zoltan2 crashes in MPI_Allreduce for MiniEM test2019-03-22T19:06:12ZJames WillenbringZoltan2 crashes in MPI_Allreduce for MiniEM test*Created by: kddevin*
@trilinos/zoltan2
@jjellio @cgcgcg @jhux2
The MiniEM team reports crashes in MPI_Allreduce in Zoltan2 when using MultiJagged partitioning. They provide instructions for reproducing the problem in
https://...*Created by: kddevin*
@trilinos/zoltan2
@jjellio @cgcgcg @jhux2
The MiniEM team reports crashes in MPI_Allreduce in Zoltan2 when using MultiJagged partitioning. They provide instructions for reproducing the problem in
https://gitlab-ex.sandia.gov/jhu/TrilinosSolverPerformance/issues/25
Similar issues were also reported by external user Robert Starr long ago, but could not be replicated in our environment.
## Steps to Reproduce
<!---
Provide a link to a live example, or an unambiguous set of steps to reproduce
this issue. Include code to reproduce, if relevant.
1. Do this.
1. Do that.
1. Shake fist angrily at computer.
-->
See
https://gitlab-ex.sandia.gov/jhu/TrilinosSolverPerformance/issues/25
## Your Environment
Develop branch; linux or mac
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4663Epetra_CrsMatrix::Multiply with locally replicated range map question2019-03-20T17:46:08ZJames WillenbringEpetra_CrsMatrix::Multiply with locally replicated range map question*Created by: bartgol*
<!---
Provide a general summary of the issue in the Title above. If this issue
pertains to a particular package in Trilinos, it's worthwhile to start the
title with "PackageName: ".
-->
<!---
Note that an...*Created by: bartgol*
<!---
Provide a general summary of the issue in the Title above. If this issue
pertains to a particular package in Trilinos, it's worthwhile to start the
title with "PackageName: ".
-->
<!---
Note that anything between these delimiters is a comment that will not appear
in the issue description once created. Click on the Preview tab to see what
everything will look like when you submit.
-->
<!---
Feel free to delete anything from this template that is not applicable to the
issue you are submitting.
-->
<!---
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/epetra
<!---
Assignees: If you know anyone who should likely tackle this issue, select them
from the Assignees drop-down on the right.
-->
<!---
Lables: Choose any applicable package names from the Labels drop-down on the
right. Additionally, choose a label to indicate the type of issue, for
instance, bug, build, documentation, enhancement, etc.
-->
## Current Behavior
<!---
Tell us how the current behavior fails to meet your expectations in some way.
-->
Currently, if the range map is locally replicated, the result of `A.Apply(X,Y)` is not what I expected. In particular, Epetra does a final call `Y.Reduce()`, which ends up giving a Y vector that is numProc times larger than what I expected. Why is Epetra doing this? I.e., why are we reducing the output vector, in case of a locally replicated range map? Isn't the result (before the Reduce() call) already what one most likely wants? The user can always call `Y.Reduce()` if he is interested in that.
## Possible Solution
<!---
Not obligatory, but suggest a fix for the bug or documentation, or suggest
ideas on how to implement the addition or change.
-->
Assuming my concern is correct, simply remove line 3212 (and the likes in other branches of if statements) in Epetra_CrsMatrix.cpp