Trilinos issueshttps://gitlab.osti.gov/jmwille/Trilinos/-/issues2019-04-20T20:21:19Zhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4790TpetraCore tests failing in ATDM sems-rhel7+cuda+complex build2019-04-20T20:21:19ZJames WillenbringTpetraCore tests failing in ATDM sems-rhel7+cuda+complex build*Created by: fryeguy52*
CC: @trilinos/tpetra, @kddevin (Trilinos Data Services Product Lead), @bartlettroscoe, @fryeguy52
<Checklist>
<???: Add label "ATDM">
<???: Add label "bug"?>
<???: Add label for affected packages (e.g. "Mu...*Created by: fryeguy52*
CC: @trilinos/tpetra, @kddevin (Trilinos Data Services Product Lead), @bartlettroscoe, @fryeguy52
<Checklist>
<???: Add label "ATDM">
<???: Add label "bug"?>
<???: Add label for affected packages (e.g. "MueLu", "Tpetra", "Kokkos", etc.)>
<???: Add milestone "Initial cleanup of new ATDM builds of Trilinos" or "Keep promoted ATDM builds of Trilinos clean">
<???: Once GitHub Issue is created, add entries for tests to TrilinosATDMStatus/*.csv files>
<???: Add label "PA: ???Project Area???" (e.g. "PA: Linear Solvers", "PA: Data Services")>
## Next Action Status
<status-and-or-first-action>
## Description
As shown in [this query](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=6&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-static-release-debug&field2=testname&compare2=65&value2=TpetraCore&field3=site&compare3=61&value3=sems-rhel7&field4=buildstarttime&compare4=84&value4=2019-04-02T00%3A00%3A00&field5=buildstarttime&compare5=83&value5=2019-03-25T00%3A00%3A00&field6=status&compare6=61&value6=Failed) the build:
* Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-static-release-debug
has several failing TpetraCore tests. The following are failing everyday ([CDash](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=6&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-static-release-debug&field2=testname&compare2=65&value2=TpetraCore_gemm_m_eq_&field3=testname&compare3=66&value3=_MPI_1&field4=site&compare4=61&value4=sems-rhel7&field5=buildstarttime&compare5=84&value5=2019-04-02T00%3A00%3A00&field6=buildstarttime&compare6=83&value6=2019-03-03T00%3A00%3A00))
* TpetraCore_gemm_m_eq_1_MPI_1
* TpetraCore_gemm_m_eq_1_MPI_2
* TpetraCore_gemm_m_eq_1_MPI_5
* TpetraCore_gemm_m_eq_1_MPI_13
While these have failed randomly over the last couple weeks ([CDash](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=7&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-static-release-debug&field2=testname&compare2=65&value2=TpetraCore&field3=testname&compare3=64&value3=_gemm_m_eq_&field4=site&compare4=61&value4=sems-rhel7&field5=buildstarttime&compare5=84&value5=2019-04-02T00%3A00%3A00&field6=buildstarttime&compare6=83&value6=2019-03-19T00%3A00%3A00&field7=status&compare7=61&value7=Failed)):
* TpetraCore_MultiVector_MicroBenchmark_MPI_1
* TpetraCore_Map_Bug5822_2_MPI_2
* TpetraCore_getEntryOnHost_MPI_1
* TpetraCore_gemv_MPI_1
* TpetraCore_deep_copy_MultiVector_to_SerialDenseMatrix_MPI_1
* TpetraCore_createMirrorView_MPI_1
several more tests have failed over the last 2 weeks in similar complex shared build shown [here](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=6&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-shared-release-debug&field2=testname&compare2=65&value2=TpetraCore&field3=site&compare3=61&value3=sems-rhel7&field4=buildstarttime&compare4=84&value4=today&field5=buildstarttime&compare5=83&value5=2%20weeks%20ago&field6=status&compare6=61&value6=failed):
* Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-shared-release-debug
Those tests are:
* TpetraCore_MatrixMatrix_UnitTests_MPI_4
* TpetraCore_Issue_607_MPI_4
* TpetraCore_Issue_114_MPI_4
* TpetraCore_Issue601_MPI_4
* TpetraCore_ImportExport2_UnitTests_MPI_4
* TpetraCore_ImportBug5430_MPI_4
* TpetraCore_Import_Union_MPI_4
* TpetraCore_CrsMatrix_NonlocalSumInto_Ignore_MPI_4
* TpetraCore_CrsMatrix_gaussSeidel_MPI_4
* TpetraCore_CrsGraph_getNumDiags_MPI_4
* TpetraCore_AddProfiling_UnitTests_MPI_4
<more-details>
## Current Status on CDash
[Failed TpetraCore tests for the current testing day](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=6&showfilters=1&filtercombine=and&field1=buildname&compare1=61&value1=Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-static-release-debug&field2=testname&compare2=65&value2=TpetraCore&field3=site&compare3=61&value3=sems-rhel7&field4=buildstarttime&compare4=84&value4=today&field5=buildstarttime&compare5=83&value5=yesterday&field6=status&compare6=61&value6=failed)
## Steps to Reproduce
One should be able to reproduce this failure on with a sems rhel6 environment as described in:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md
More specifically, the commands given for with a sems rhel6 environment are provided at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md#sems-rhel6-environment
The exact commands to reproduce this issue should be:
```
$ cd <some_build_dir>/
$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-static-release-debug
$ cmake \
-GNinja \
-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
-DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_Tpetra=ON \
$TRILINOS_DIR
$ make NP=16
$ ctest -j8
```
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4801Many PanzerAdaptersSTK (random?) failures in ATDM sems-rhel7+cuda+complex builds2019-04-20T20:12:51ZJames WillenbringMany PanzerAdaptersSTK (random?) failures in ATDM sems-rhel7+cuda+complex builds*Created by: fryeguy52*
CC: @trilinos/panzer, @mperego (Trilinos Discretizations Product Lead), @bartlettroscoe, @fryeguy52
<Checklist>
<???: Add label "ATDM">
<???: Add label "bug"?>
<???: Add label for affected packages (e.g. "...*Created by: fryeguy52*
CC: @trilinos/panzer, @mperego (Trilinos Discretizations Product Lead), @bartlettroscoe, @fryeguy52
<Checklist>
<???: Add label "ATDM">
<???: Add label "bug"?>
<???: Add label for affected packages (e.g. "MueLu", "Tpetra", "Kokkos", etc.)>
<???: Add milestone "Initial cleanup of new ATDM builds of Trilinos" or "Keep promoted ATDM builds of Trilinos clean">
<???: Once GitHub Issue is created, add entries for tests to TrilinosATDMStatus/*.csv files>
<???: Add label "PA: ???Project Area???" (e.g. "PA: Linear Solvers", "PA: Data Services")>
## Next Action Status
## Description
As shown in [this query](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=6&showfilters=1&filtercombine=and&field1=buildname&compare1=65&value1=Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-&field2=testname&compare2=65&value2=PanzerAdaptersSTK_&field3=site&compare3=61&value3=sems-rhel7&field4=buildstarttime&compare4=84&value4=2019-04-03T00%3A00%3A00&field5=buildstarttime&compare5=83&value5=2019-03-21T00%3A00%3A00&field6=status&compare6=61&value6=Failed) these tests:
* PanzerAdaptersSTK_CurlLaplacianExample
* PanzerAdaptersSTK_CurlLaplacianExample-ConvTest-Quad-Order-1
* PanzerAdaptersSTK_CurlLaplacianExample-ConvTest-Quad-Order-2
* PanzerAdaptersSTK_CurlLaplacianExample-ConvTest-Quad-Order-3
* PanzerAdaptersSTK_CurlLaplacianExample-ConvTest-Quad-Order-4
* PanzerAdaptersSTK_CurlLaplacianMultiblockExample-ConvTest-Quad-Order-1
* PanzerAdaptersSTK_MixedCurlLaplacianExample-ConvTest-Quad-Order-1
* PanzerAdaptersSTK_MixedCurlLaplacianExample-ConvTest-Quad-Order-2
* PanzerAdaptersSTK_MixedCurlLaplacianExample-ConvTest-Quad-Order-3
* PanzerAdaptersSTK_MixedCurlLaplacianExample-ConvTest-Tri-Order-1
* PanzerAdaptersSTK_MixedCurlLaplacianExample-ConvTest-Tri-Order-2
* PanzerAdaptersSTK_MixedCurlLaplacianMultiblockExample-ConvTest-Quad-Order-1
* PanzerAdaptersSTK_MixedPoissonExample-ConvTest-Hex-Order-1
* PanzerAdaptersSTK_MixedPoissonExample-ConvTest-Hex-Order-2
* PanzerAdaptersSTK_MixedPoissonExample-ConvTest-Hex-Order-3
* PanzerAdaptersSTK_MixedPoissonMultiblockExample-ConvTest-Hex-Order-1
* PanzerAdaptersSTK_PoissonInterfaceExample_2d_diffsideids_MPI_1
have failed at least once on one of these builds since 2019-03-21:
* Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-static-release-debug
* Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-shared-release-debug
## Current Status on CDash
PanzerAdaptersSTK tests that failed on those builds for the current testing day can be found [here](https://testing.sandia.gov/cdash/queryTests.php?project=Trilinos&filtercombine=and&filtercombine=&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=6&showfilters=1&filtercombine=and&field1=buildname&compare1=65&value1=Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-&field2=testname&compare2=65&value2=PanzerAdaptersSTK_&field3=site&compare3=61&value3=sems-rhel7&field4=buildstarttime&compare4=84&value4=today&field5=buildstarttime&compare5=83&value5=yesterday&field6=status&compare6=61&value6=Failed)
## Steps to Reproduce
One should be able to reproduce this failure on with a sems rhel6 environment as described in:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md
More specifically, the commands given for with a sems rhel6 environment are provided at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md#sems-rhel6-environment
The exact commands to reproduce this issue should be:
```
$ cd <some_build_dir>/
$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh Trilinos-atdm-sems-rhel7-cuda-9.2-Volta70-complex-static-release-debug
$ cmake \
-GNinja \
-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
-DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_Panzer=ON \
$TRILINOS_DIR
$ make NP=16
$ ctest -j8
```
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4280Tpetra: sort and merge values: CrsMatrix::insertGlobalValues2019-04-19T00:53:35ZJames WillenbringTpetra: sort and merge values: CrsMatrix::insertGlobalValues*Created by: tjfulle*
## What
Sort and merge new values in `CrsMatrix::insertGlobalValues`
## Why
`CrsMatrix::insertGlobalValues` does not sort/merge existing values. Instead, indices/values are appended to their row of the mat...*Created by: tjfulle*
## What
Sort and merge new values in `CrsMatrix::insertGlobalValues`
## Why
`CrsMatrix::insertGlobalValues` does not sort/merge existing values. Instead, indices/values are appended to their row of the matrix, regardless if they are already present in the row. During `fillComplete`, rows are sorted/merged so that duplicate entries are "compressed" out. For `StaticProfile` matrix, this can lead to running out of capacity due to duplicate entries.
@trilinos/tpetra
## Related Issues
#4278, #4279 Tpetra: Deprecate DynamicProfilehttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4281Tpetra: sort and merge values: CrsMatrix::insertLocalValues2019-04-18T22:09:22ZJames WillenbringTpetra: sort and merge values: CrsMatrix::insertLocalValues*Created by: tjfulle*
## What
Sort and merge new values in `CrsMatrix::insertLocalValues`
## Why
`CrsMatrix::insertLocalValues` does not sort/merge existing values. Instead, indices/values are appended to their row of the matri...*Created by: tjfulle*
## What
Sort and merge new values in `CrsMatrix::insertLocalValues`
## Why
`CrsMatrix::insertLocalValues` does not sort/merge existing values. Instead, indices/values are appended to their row of the matrix, regardless if they are already present in the row. During `fillComplete`, rows are sorted/merged so that duplicate entries are "compressed" out. For `StaticProfile` matrix, this can lead to running out of capacity due to duplicate entries.
@trilinos/tpetra
## Related Issues
#4278, #4279, #4280 Tpetra: Deprecate DynamicProfilehttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4279Tpetra: sort and merge on insert: CrsGraph::insertLocalIndices2019-04-18T22:08:54ZJames WillenbringTpetra: sort and merge on insert: CrsGraph::insertLocalIndices*Created by: tjfulle*
## What
Sort and merge new indices in `CrsGraph::insertLocalIndices`
## Why
`CrsGraph` does not sort/merge new indices. Instead, indices are appended to their row of the graph, regardless if they are alrea...*Created by: tjfulle*
## What
Sort and merge new indices in `CrsGraph::insertLocalIndices`
## Why
`CrsGraph` does not sort/merge new indices. Instead, indices are appended to their row of the graph, regardless if they are already present in the row. During `fillComplete`, rows are sorted/merged so that duplicate entries are "compressed" out. For `StaticProfile` graph, this can lead to running out of capacity due to duplicate entries.
@trilinos/tpetra
## Related Issues
#4278 Tpetra: Deprecate DynamicProfilehttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4278Tpetra: sort and merge on insert: CrsGraph::insertGlobalIndices2019-04-18T22:08:34ZJames WillenbringTpetra: sort and merge on insert: CrsGraph::insertGlobalIndices*Created by: tjfulle*
## What
Sort and merge new indices in `CrsGraph::insertGlobalIndices`
## Why
`CrsGraph` does not sort/merge new indices. Instead, indices are appended to their row of the graph, regardless if they are alre...*Created by: tjfulle*
## What
Sort and merge new indices in `CrsGraph::insertGlobalIndices`
## Why
`CrsGraph` does not sort/merge new indices. Instead, indices are appended to their row of the graph, regardless if they are already present in the row. During `fillComplete`, rows are sorted/merged so that duplicate entries are "compressed" out. For `StaticProfile` graph, this can lead to running out of capacity due to duplicate entries.
@trilinos/tpetra Tpetra: Deprecate DynamicProfilehttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4796TriBits: undefined variable breaks nightly builds2019-04-18T17:27:20ZJames WillenbringTriBits: undefined variable breaks nightly builds*Created by: lucbv*
@bartlettroscoe (there is not good team for that type of issues...)
## Expectations
triBits changes should not break current nightly builds.
## Current Behavior
The nightly builds from MueLu are all failing a...*Created by: lucbv*
@bartlettroscoe (there is not good team for that type of issues...)
## Expectations
triBits changes should not break current nightly builds.
## Current Behavior
The nightly builds from MueLu are all failing at configure time due to an undefined variable: `${${PROJECT_NAME}_TRIBITS_DIR}` in file `cmake/tribits/core/utils/MessageWrapper.cmake` at line 45.
## Motivation and Context
This has taken down all the nightly MueLu builds which means that we cannot detect bugs in our specialize and experimental tracks that usually are not tested by ATDM or Continuous builds.
## Possible Solution
Is seems that changes done last week in triBits are to blame, see commit `2283e955`
## Steps to Reproduce
Attempting to run any build using the `cmake/ctest/drivers/{enigma,geminga,rocketman,trappist}` will fail.https://gitlab.osti.gov/jmwille/Trilinos/-/issues/1183Teuchos: Remove Teuchos_ENABLE_LONG_LONG_INT option2019-04-18T10:06:45ZJames WillenbringTeuchos: Remove Teuchos_ENABLE_LONG_LONG_INT option*Created by: mhoemmen*
@trilinos/teuchos
The ability to disable `long long` support in Teuchos causes spurious issues like #1161. The only reason not to allow use of `long long` is because of some Teuchos users who do not enable C+...*Created by: mhoemmen*
@trilinos/teuchos
The ability to disable `long long` support in Teuchos causes spurious issues like #1161. The only reason not to allow use of `long long` is because of some Teuchos users who do not enable C++11 in their builds. We need to respect these users, but it doesn't make sense to make `Teuchos_ENABLE_LONG_LONG_INT` a user-settable option. If you have C++11, you should get `long long`, whether you want it or not.https://gitlab.osti.gov/jmwille/Trilinos/-/issues/2567Tpetra: Ignore Teuchos_ENABLE_LONG_LONG_INT 2019-04-18T10:06:44ZJames WillenbringTpetra: Ignore Teuchos_ENABLE_LONG_LONG_INT *Created by: mhoemmen*
See PR #2547, Issue #2498, and PR #2499 for context. Several years ago, the way to tell Tpetra to disable `GlobalOrdinal=long long` support, was to set `Teuchos_ENABLE_LONG_LONG_INT:BOOL=OFF`. There was apparent...*Created by: mhoemmen*
See PR #2547, Issue #2498, and PR #2499 for context. Several years ago, the way to tell Tpetra to disable `GlobalOrdinal=long long` support, was to set `Teuchos_ENABLE_LONG_LONG_INT:BOOL=OFF`. There was apparently no other way to do it. That was bad.
Later on, we added proper Tpetra options for enabling or disabling `GlobalOrdinal=long long` support, in Tpetra. However, users tend to keep and reuse CMake configuration options for Trilinos. As a result, users kept expecting that `Teuchos_ENABLE_LONG_LONG_INT:BOOL=OFF` would work. #2495 is an example of an issue that came up for this reason.
I worked around this with PR #2499, but the right approach is for Tpetra simply to ignore this CMake option. Users should not set this Teuchos option any more! Teuchos requires C++11 -- it has for a while -- and C++11 requires `long long`. We shouldn't be afraid to remove old options.
I would also like Teuchos to require that this option always be ON, but that's a separate issue.
@trilinos/tpetra https://gitlab.osti.gov/jmwille/Trilinos/-/issues/3619STK: fix build warnings under CUDA2019-04-16T18:17:28ZJames WillenbringSTK: fix build warnings under CUDA*Created by: jhux2*
While working on #2674 on waterman, I'm seeing a lot of the following boost warnings during compilation of STK:
```
include/boost/mpl/for_each.hpp(78): warning: calling a __host__ function from a __host__ __device_...*Created by: jhux2*
While working on #2674 on waterman, I'm seeing a lot of the following boost warnings during compilation of STK:
```
include/boost/mpl/for_each.hpp(78): warning: calling a __host__ function from a __host__ __device__ function is not allowed
```
@trilinos/stk @alanw0 @bartlettroscoe Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4827Tpetra::Details::copyConvert doesn't build for conversions between Kokkos::co...2019-04-16T14:01:50ZJames WillenbringTpetra::Details::copyConvert doesn't build for conversions between Kokkos::complex<float> and double*Created by: mhoemmen*
@trilinos/tpetra
This breaks `Tpetra::deep_copy` between `MultiVector<std::complex<float>, ...>` and `MultiVector<double, ...>`.*Created by: mhoemmen*
@trilinos/tpetra
This breaks `Tpetra::deep_copy` between `MultiVector<std::complex<float>, ...>` and `MultiVector<double, ...>`.https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4736INSTALLING TRILINOS(ML SOLVER)2019-04-15T18:32:55ZJames WillenbringINSTALLING TRILINOS(ML SOLVER)*Created by: chandu1263*
<!---
Provide a general summary of the issue in the Title above. If this issue
pertains to a particular package in Trilinos, it's worthwhile to start the
title with "PackageName: ".
-->
<!---
Note that...*Created by: chandu1263*
<!---
Provide a general summary of the issue in the Title above. If this issue
pertains to a particular package in Trilinos, it's worthwhile to start the
title with "PackageName: ".
-->
<!---
Note that anything between these delimiters is a comment that will not appear
in the issue description once created. Click on the Preview tab to see what
everything will look like when you submit.
-->
<!---
Feel free to delete anything from this template that is not applicable to the
issue you are submitting.
-->
<!---
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/<teamName>
<!---
Assignees: If you know anyone who should likely tackle this issue, select them
from the Assignees drop-down on the right.
-->
<!---
Lables: Choose any applicable package names from the Labels drop-down on the
right. Additionally, choose a label to indicate the type of issue, for
instance, bug, build, documentation, enhancement, etc.
-->
## Expectations
<!---
Tell us what you think should happen, how you think things should work, what
you would like to see in the documentation, etc.
-->
## Current Behavior
<!---
Tell us how the current behavior fails to meet your expectations in some way.
-->
## Motivation and Context
<!---
How has this expectation failure affected you? What are you trying to
accomplish? Why do we need to address this? What does it have to do with
anything? Providing context helps us come up with a solution that is most
useful in the real world.
-->
## Definition of Done
<!---
Tell us what needs to happen. If necessary, give us a task list along the
lines of:
- [ ] First do this.
- [ ] Then do that.
- [ ] Also this other thing.
-->
## Possible Solution
<!---
Not obligatory, but suggest a fix for the bug or documentation, or suggest
ideas on how to implement the addition or change.
-->
## Steps to Reproduce
<!---
Provide a link to a live example, or an unambiguous set of steps to reproduce
this issue. Include code to reproduce, if relevant.
1. Do this.
1. Do that.
1. Shake fist angrily at computer.
-->
## Your Environment
<!---
Include relevant details about your environment such that we can replicate this
issue.
-->
- **Relevant repo SHA1s:**
- **Relevant configure flags or configure script:**
- **Operating system and version:**
- **Compiler and TPL versions:**
## Related Issues
<!---
If applicable, let us know how this bug is related to any other open issues:
-->
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
## Additional Information
<!---
Anything else that might be helpful for us to know in addressing this issue:
* Configure log file:
* Build log file:
* Test log file:
* When was the last time everything worked (date/time; SHA1s; etc.)?
* What did you do that made the bug rear its ugly head?
* Have you tried turning it off and on again?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4852Tpetra: Make CrsGraph implement the "new" DistObject interface 2019-04-12T19:09:48ZJames WillenbringTpetra: Make CrsGraph implement the "new" DistObject interface *Created by: mhoemmen*
@trilinos/tpetra
## Current Behavior
`Tpetra::CrsGraph` currently implements the "old" DistObject interface (copyAndPermute, packAndPrepare, unpackAndCombine) instead of the "new" DistObject interface (copy...*Created by: mhoemmen*
@trilinos/tpetra
## Current Behavior
`Tpetra::CrsGraph` currently implements the "old" DistObject interface (copyAndPermute, packAndPrepare, unpackAndCombine) instead of the "new" DistObject interface (copyAndPermuteNew, packAndPrepareNew, unpackAndCombineNew).
## Motivation and Context
This blocks deprecation and removal of the "old" DistObject interface.
## Definition of Done
- [ ] Implement copyAndPermuteNew, packAndPrepareNew, and unpackAndCombineNew
- [ ] Implement useNewInterface and have it return true
- [ ] Make sure all the tests pass
## Possible Solution
@tjfulle has spent quite a bit of effort on thread-parallel CrsGraph pack and unpack. It looks like he did most of the underlying work already. This is more about getting the interfaces to match and plugging everything in.
## Related Issues
* Blocks https://github.com/trilinos/Trilinos/issues/4853 https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4770Deprecation in Tpetra::CrsMatrix constructor triggers warning in Xpetra that ...2019-04-12T12:45:03ZJames WillenbringDeprecation in Tpetra::CrsMatrix constructor triggers warning in Xpetra that crashes the SPARC build*Created by: bartlettroscoe*
CC: @trilinos/xpetra, @trilinos/tpetra , @kddevin (Trilinos Data Services Product Lead), @bartlettroscoe, @fryeguy52, @mhoemmen
## Next Action Status
<status-and-or-first-action>
## Description
...*Created by: bartlettroscoe*
CC: @trilinos/xpetra, @trilinos/tpetra , @kddevin (Trilinos Data Services Product Lead), @bartlettroscoe, @fryeguy52, @mhoemmen
## Next Action Status
<status-and-or-first-action>
## Description
The commit 24cef7553e09f35f08a8c93bd3c7f8dab5aeb3ea merged in PR #4748 deprecated a constructor for `Tpetra::CrsMatrix` and triggered a deprecated warning when SPARC builds showing the error:
```
/projects/atdm_devops/trilinos_installs/2019-03-29/cee-rhel6_clang-5.0.1_openmpi-1.10.2_serial_static_opt/include/Xpetra_TpetraCrsMatrix.hpp:109:31: error: 'CrsMatrix' is deprecated [-Werror,-Wdeprecated-declarations]
: mtx_(Teuchos::rcp(new Tpetra::CrsMatrix (toTpetra(rowMap), NumEntriesPerRowToAlloc, toTpetra(pftype), params))) { }
```
This deprecated warning (elevated to an error in SPARC because they set `-Werror`) is triggered inside of Trilinos headers but is not shown in the Xpetra test suite shown [here](https://testing.sandia.gov/cdash-dev-view/index.php?project=Trilinos&parentid=4809252). Does this show a gap in the automated tests for Xpetra?
## Current Status on CDash
The current status can only be seen in the SPARC Trilinos Integration builds shown over the last few days [here](http://compsim-dashboard.sandia.gov/cdash/index.php?project=SPARC&date=2019-03-30&filtercombine=and&filtercount=2&showfilters=1&filtercombine=and&field1=buildname&compare1=66&value1=-trildev&field2=buildstarttime&compare2=83&value2=5%20days%20ago).
## Steps to Reproduce
Since the native test suite does not show a problem, one can only reproduce this by building SPARC itself. See the instructions for doing that [here](https://snl-wiki.sandia.gov/display/CoodinatedDevOpsATDM/Building+ATDM+APPs+Against+Local+Installs+of+Trilinos#BuildingATDMAPPsAgainstLocalInstallsofTrilinos-BuildingagainsttheSPARCTrilinos'master'versionusingthenativeSPARCTrilinosconfigurationscripts).
But if one wants to reproduce say the `clang-5.0.1` build on a CEE RHEL6 machine, one can follow the instructions at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md
More specifically, the commands given for the system 'cee-rhel6' are provided at:
* https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md#cee-rhel6-environment
The exact commands to reproduce this issue should be:
```
$ cd <some_build_dir>/
$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh \
Trilinos-atdm-cee-rhel6_clang-5.0.1_openmpi-1.10.2_serial_static_opt
$ cmake \
-GNinja \
-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
-DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_Xpetra=ON \
$TRILINOS_DIR
$ make NP=16
```
But of course that does not show a warning so Xpetra needs to be upgraded to reproduce that warning.Keep promoted "ATDM" builds of Trilinos cleanhttps://gitlab.osti.gov/jmwille/Trilinos/-/issues/4836Tempus: Improve Interval Output Setup2019-04-11T21:48:56ZJames WillenbringTempus: Improve Interval Output Setup*Created by: ccober6*
In the output interval and the screen output interval, all the intervals are placed in a vector along with the specified output times or indices, and then sorted. This allowed all the output times and indices to b...*Created by: ccober6*
In the output interval and the screen output interval, all the intervals are placed in a vector along with the specified output times or indices, and then sorted. This allowed all the output times and indices to be in one vector and searched. However when the number of time steps reaches millions, the sort is far too expensive. This will rework the interval specification so that it is not part of the vector or sorting.
@trilinos/tempus
## Expectations
Work the same as previously but without the costly sorting.https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4821Tempus: Add method to set Tableaus.2019-04-11T21:48:37ZJames WillenbringTempus: Add method to set Tableaus.*Created by: ccober6*
@trilinos/tempus
## Motivation and Context
To better setup RK methods, it is nice to set the Butcher Tableau directly instead of through a ParameterList.
## Solution
Add set method for the tableaus.*Created by: ccober6*
@trilinos/tempus
## Motivation and Context
To better setup RK methods, it is nice to set the Butcher Tableau directly instead of through a ParameterList.
## Solution
Add set method for the tableaus.https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4843Tempus: Separate Stepper Header and Source2019-04-11T21:48:09ZJames WillenbringTempus: Separate Stepper Header and Source*Created by: ccober6*
Cleanup the Stepper base class and separate the header from the source code.
@trilinos/tempus
## Expectations
Nothing should change. Just code shuffling to improve code quality.*Created by: ccober6*
Cleanup the Stepper base class and separate the header from the source code.
@trilinos/tempus
## Expectations
Nothing should change. Just code shuffling to improve code quality.https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4840Tpetra: Deprecate MultiVectorFiller2019-04-11T18:23:38ZJames WillenbringTpetra: Deprecate MultiVectorFiller*Created by: csiefer2*
Because Tpetra::FEMultiVector is so much better...*Created by: csiefer2*
Because Tpetra::FEMultiVector is so much better...https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4850MueLu: update LTG Matrix kernels in TpetraExt2019-04-10T20:53:18ZJames WillenbringMueLu: update LTG Matrix kernels in TpetraExt*Created by: jjellio*
Update the TpetraExt (LTG) kernels to use improved copies and memory management.
These changes were not propagated from the work done last fall. This issue mirrors the PR being submitted.
@trilinos/muelu
@c...*Created by: jjellio*
Update the TpetraExt (LTG) kernels to use improved copies and memory management.
These changes were not propagated from the work done last fall. This issue mirrors the PR being submitted.
@trilinos/muelu
@csiefer2
## Expectations
- [x] The kernels will use bulk threaded copies for copy-out
- [x] The kernels will compute the rowptr in-place (reduced memory overhead)
https://gitlab.osti.gov/jmwille/Trilinos/-/issues/4829KokkosKernels broke Albany build on Ride2019-04-10T14:34:42ZJames WillenbringKokkosKernels broke Albany build on Ride*Created by: ikalash*
It appears some changes to KokkosKernels broke Albany's Ride build over the weekend. Here is the error:
```
58%] Building C object packages/aztecoo/src/CMakeFiles/aztecoo.dir/az_gsumd_puma.c.o ...*Created by: ikalash*
It appears some changes to KokkosKernels broke Albany's Ride build over the weekend. Here is the error:
```
58%] Building C object packages/aztecoo/src/CMakeFiles/aztecoo.dir/az_gsumd_puma.c.o /.../repos/Trilinos/packages/kokkos-kernels/src/sparse/impl/KokkosSparse_spgemm_impl_color.hpp(516): error: namespace "KokkosGraph::Experimental" has no member "d2_graph_color"
--
```
http://cdash.sandia.gov/CDash-2-3-0/viewBuildError.php?buildid=83384
Could someone please have a look?
@trilinos/kokkos-kernels