MueLu, Teuchos build error on Windows (MSVC)
Created by: mplooster
Found while working on #1160. For this build using Visual Studio 2015, this error in MueLu was introduced recently:
C:\Users\mgploos\TrilinosProject\MPI_Release_12.11\Trilinos\packages\teuchos\core\src\Teuchos_Array.hpp(1352): error C2102: '&' requires l-value
I can trace it back to this commit a couple of weeks ago - 2c0690c4. If I comment out the line
level->Set(varName, Teuchos::getValue<Array<bool> >(it2->second), NoFactory::get());
MueLu builds fine. The ArrayRCP<bool> version that was also added in this commit compiles without any problems, so I am not sure what it is about Array<bool> that would cause this to start failing. I do know that the call to Teuchos::getValue in MueLu_HierarchyUtils_def.hpp ends up using Teuchos::Array<T>::view after lots of casting and calls to other template functions.
Can anyone on the @trilinos/muelu @trilinos/teuchos or @trilinos/framework teams comment on what might be happening here that would cause this build error?