Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Trilinos
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 936
    • Issues 936
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • James Willenbring
  • Trilinos
  • Issues
  • #2044

Closed
Open
Created Dec 04, 2017 by James Willenbring@jmwilleMaintainer

Look into adding pull request testing to STK/SEACAS integration

Created by: bmpersc

@trilinos/framework

Expectations

Instead of directly pushing to the develop branch after local tests pass have the integration issue a pull request so that the PR testing will be done as well.

Current Behavior

The integration currently runs a set of tests and if those tests pass pushes to the develop branch directly. This was the pattern all developers used when this tool was created.

Motivation and Context

With the impending switch to use PR's for all contributions the automated things should also switch to this. Worst case is that is really is unneeded, best case is that it provides additional testing and protections.

Possible Solution

The tools we are using already know how to push to a github repo, we need to switch that to use a fork, either from someone on the framework team or create one special for this. From there we then need to have an automated way to issue the pull request from the existing tool. Using the github api it may already be possible to issue a pull request from a script. If so this should be pretty easy to do. I will need to look into what is possible with the github api for this.

Assignee
Assign to
Time tracking