Missing Sacado test dependency
Created by: jwillenbring
When building Sacado for a nightly no-C++11 build with optional packages off, the following error occurred:
/jenkins/slave/workspace/Trilinos_XYCE_MPI/MPI_OPT_DEV_XYCE/Trilinos/packages/sacado/test/UnitTests/ConversionTests.cpp:30:39: error: Teuchos_UnitTestHarness.hpp: No such file or directory /jenkins/slave/workspace/Trilinos_XYCE_MPI/MPI_OPT_DEV_XYCE/Trilinos/packages/sacado/test/UnitTests/ConversionTests.cpp:31:42: error: Teuchos_UnitTestRepository.hpp: No such file or directory /jenkins/slave/workspace/Trilinos_XYCE_MPI/MPI_OPT_DEV_XYCE/Trilinos/packages/sacado/test/UnitTests/ConversionTests.cpp:32:40: error: Teuchos_GlobalMPISession.hpp: No such file or directory /jenkins/slave/workspace/Trilinos_XYCE_MPI/MPI_OPT_DEV_XYCE/Trilinos/packages/sacado/test/UnitTests/ConversionTests.cpp:33:38: error: Teuchos_TestingHelpers.hpp: No such file or directory /jenkins/slave/workspace/Trilinos_XYCE_MPI/MPI_OPT_DEV_XYCE/Trilinos/packages/sacado/test/UnitTests/ConversionTests.cpp:53: error: expected constructor, destructor, or type conversion before ‘(’ token /jenkins/slave/workspace/Trilinos_XYCE_MPI/MPI_OPT_DEV_XYCE/Trilinos/packages/sacado/test/UnitTests/ConversionTests.cpp:70: error: template declaration of ‘bool test_ad_conversions’ /jenkins/slave/workspace/Trilinos_XYCE_MPI/MPI_OPT_DEV_XYCE/Trilinos/packages/sacado/test/UnitTests/ConversionTests.cpp:70: error: ‘Teuchos’ has not been declared ...
The full context can be seen here:
http://testing.sandia.gov/cdash/viewBuildError.php?buildid=2380725
I have a simple fix that I have tested which is to add TeuchosCore as a required test dependence for Sacado. I did not investigate if it would be possible to refactor the testing to optionally use Teuchos. It seems very likely that this case isn't commonly exercised, as Teuchos is an optional library dependence for Sacado, and Teuchos is included in the vast majority of Trilinos builds.
I plan to issue a pull request for this simple fix later today.