Teuchos: Add CMake test to set HAVE_TEUCHOS_KOKKOS_PROFILING
Created by: mhoemmen
See #2271 (closed), in particular my comment here: https://github.com/trilinos/Trilinos/pull/2272#issuecomment-367517327
Teuchos actually does define a CMake option (Teuchos_KOKKOS_PROFILING
) that controls HAVE_TEUCHOS_KOKKOS_PROFILING
, but the default value of the CMake option is OFF
. It doesn't check Kokkos' CMake options at all. We need Teuchos to enable this automatically by default, if the Kokkos package is enabled and if Kokkos profiling is enabled.
@trilinos/teuchos
Motivation and Context
Lots of Trilinos packages use Teuchos timers. We want those packages to get the advantage of Kokkos profiling, without needing to change their existing Teuchos timer infrastructure. We also want this capability to exist by default; users shouldn't have to set nondefault CMake options to get it.
Definition of Done
-
Make Teuchos' CMake logic enable Teuchos_KOKKOS_PROFILING
by default, if the Kokkos package is enabled and if Kokkos profiling is enabled. -
Test that the Teuchos code that uses Kokkos profiling hooks actually builds and runs correctly, since it hasn't been building or running by default.
Related Issues
- Related to #2271 (closed)