Trilinos "Clean" and auto PR builds need a Trilinos_ENABLE_DEBUG=ON build (#2292) · Issues · James Willenbring / Trilinos

Trilinos "Clean" and auto PR builds need a Trilinos_ENABLE_DEBUG=ON build

Created by: bartlettroscoe

CC: @trilinos/framework, @maherou, @rppawlo

Description

It would seem that all of the current "Clean" builds of Trilinos shown for example yesterday at:

https://testing.sandia.gov/cdash/index.php?project=Trilinos&date=2018-02-21&filtercount=1&showfilters=1&field1=groupname&compare1=61&value1=Clean

all have Trilinos_ENABLE_DEBUG=OFF set. You can see this, for example, by looking at the uploaded CMakeCache.txt files for these three builds at:

which all show:

Trilinos_ENABLE_DEBUG:BOOL=OFF

This is not a good thing because there are a lot of run-time checks turned on with you configure Trilinos with -DTrilinos_ENABLE_DEBUG=ON. It catches a lot of undefined and otherwise illegal behavior that a Trilinos_ENABLE_DEBUG=OFF does not catch.

Because none of the "Clean" builds have -DTrilinos_ENABLE_DEBUG=ON one would assume that none of the auto PR builds have it set either. Therefore, can that auto PR builds have at least one build that has this turned on. And from looking at recent PRs like:

https://github.com/trilinos/Trilinos/pull/2289#issuecomment-367782068

it looks like the auto PR tester is now only running one build. If that is the case, it is critical that this one build set -DTrilinos_ENABLE_DEBUG=ON.

This is a big issue for supporting developers and users of Trilinos and especially for ATDM builds of Trilinos that set -DTrilinos_ENABLE_DEBUG=ON. For example, this let skip through defects like #2270.