ShyLU: shadow warnings in Tacho
Created by: jhux2
There are a few shadow warnings in Tacho during a relatively vanilla build of Trilinos.
@trilinos/shylu @kyungjoo-kim
In file included from /home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/Tacho.hpp:28:0,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Tacho_decl.hpp:51,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Tacho.hpp:47,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Factory.hpp:111,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2.hpp:45,
from /home/jhu/trilinos/Trilinos/packages/muelu/src/Smoothers/MueLu_Amesos2Smoother_def.hpp:56,
from packages/muelu/src/Utils/ExplicitInstantiation/MueLu_Amesos2Smoother.cpp:55:
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_SymbolicTools.hpp: In lambda function:
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_SymbolicTools.hpp:251:75: warning: declaration of ‘const ordinal_type_array& aj’ shadows a parameter [-Wshadow]
const ordinal_type_array &flag) -> ordinal_type {
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_SymbolicTools.hpp:224:52: note: shadowed declaration is here
const ordinal_type_array &aj,
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_SymbolicTools.hpp:251:75: warning: declaration of ‘const size_type_array& ap’ shadows a parameter [-Wshadow]
const ordinal_type_array &flag) -> ordinal_type {
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_SymbolicTools.hpp:223:49: note: shadowed declaration is here
const size_type_array &ap,
^
In file included from /home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/Tacho.hpp:56:0,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Tacho_decl.hpp:51,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Tacho.hpp:47,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Factory.hpp:111,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2.hpp:45,
from /home/jhu/trilinos/Trilinos/packages/muelu/src/Smoothers/MueLu_Amesos2Smoother_def.hpp:56,
from packages/muelu/src/Utils/ExplicitInstantiation/MueLu_Amesos2Smoother.cpp:55:
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_FactorizeChol.hpp: In member function ‘void Tacho::Experimental::TaskFunctor_FactorizeChol<MatValueType, ExecSpace>::operator()(Tacho::Experimental::TaskFunctor_FactorizeChol<MatValueType, ExecSpace>::member_type&, Tacho::Experimental::TaskFunctor_FactorizeChol<MatValueType, ExecSpace>::value_type&)’:
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_FactorizeChol.hpp:91:34: warning: declaration of ‘const ordinal_type r_val’ shadows a parameter [-Wshadow]
const ordinal_type r_val = factorize_internal(member, _s.max_decendant_schur_size, true);
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_FactorizeChol.hpp:81:56: note: shadowed declaration is here
void operator()(member_type &member, value_type &r_val) {
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_FactorizeChol.hpp:117:32: warning: declaration of ‘const ordinal_type r_val’ shadows a parameter [-Wshadow]
const ordinal_type r_val = factorize_internal(member, _s.n - _s.m, false);
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_FactorizeChol.hpp:81:56: note: shadowed declaration is here
void operator()(member_type &member, value_type &r_val) {
^
In file included from /home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/Tacho.hpp:57:0,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Tacho_decl.hpp:51,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Tacho.hpp:47,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Factory.hpp:111,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2.hpp:45,
from /home/jhu/trilinos/Trilinos/packages/muelu/src/Smoothers/MueLu_Amesos2Smoother_def.hpp:56,
from packages/muelu/src/Utils/ExplicitInstantiation/MueLu_Amesos2Smoother.cpp:55:
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_FactorizeCholPanel.hpp: In member function ‘void Tacho::Experimental::TaskFunctor_FactorizeCholPanel<MatValueType, ExecSpace>::operator()(Tacho::Experimental::TaskFunctor_FactorizeCholPanel<MatValueType, ExecSpace>::member_type&, Tacho::Experimental::TaskFunctor_FactorizeCholPanel<MatValueType, ExecSpace>::value_type&)’:
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_FactorizeCholPanel.hpp:95:34: warning: declaration of ‘const ordinal_type r_val’ shadows a parameter [-Wshadow]
const ordinal_type r_val = factorize_internal(member, _s.max_decendant_schur_size, true);
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_FactorizeCholPanel.hpp:85:56: note: shadowed declaration is here
void operator()(member_type &member, value_type &r_val) {
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_FactorizeCholPanel.hpp:121:32: warning: declaration of ‘const ordinal_type r_val’ shadows a parameter [-Wshadow]
const ordinal_type r_val = factorize_internal(member, _s.n - _s.m, false);
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_FactorizeCholPanel.hpp:85:56: note: shadowed declaration is here
void operator()(member_type &member, value_type &r_val) {
^
In file included from /home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/Tacho.hpp:61:0,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Tacho_decl.hpp:51,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Tacho.hpp:47,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Factory.hpp:111,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2.hpp:45,
from /home/jhu/trilinos/Trilinos/packages/muelu/src/Smoothers/MueLu_Amesos2Smoother_def.hpp:56,
from packages/muelu/src/Utils/ExplicitInstantiation/MueLu_Amesos2Smoother.cpp:55:
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_SolveLowerChol.hpp: In member function ‘void Tacho::Experimental::TaskFunctor_SolveLowerChol<MatValueType, ExecSpace>::operator()(Tacho::Experimental::TaskFunctor_SolveLowerChol<MatValueType, ExecSpace>::member_type&, Tacho::Experimental::TaskFunctor_SolveLowerChol<MatValueType, ExecSpace>::value_type&)’:
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_SolveLowerChol.hpp:93:34: warning: declaration of ‘const ordinal_type r_val’ shadows a parameter [-Wshadow]
const ordinal_type r_val = solve_internal(member, _s.max_decendant_schur_size, true);
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_SolveLowerChol.hpp:85:56: note: shadowed declaration is here
void operator()(member_type &member, value_type &r_val) {
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_SolveLowerChol.hpp:117:32: warning: declaration of ‘const ordinal_type r_val’ shadows a parameter [-Wshadow]
const ordinal_type r_val = solve_internal(member, _s.n - _s.m, false);
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_SolveLowerChol.hpp:85:56: note: shadowed declaration is here
void operator()(member_type &member, value_type &r_val) {
^
In file included from /home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/Tacho.hpp:62:0,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Tacho_decl.hpp:51,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Tacho.hpp:47,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2_Factory.hpp:111,
from /home/jhu/trilinos/Trilinos/packages/amesos2/src/Amesos2.hpp:45,
from /home/jhu/trilinos/Trilinos/packages/muelu/src/Smoothers/MueLu_Amesos2Smoother_def.hpp:56,
from packages/muelu/src/Utils/ExplicitInstantiation/MueLu_Amesos2Smoother.cpp:55:
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_SolveUpperChol.hpp: In member function ‘void Tacho::Experimental::TaskFunctor_SolveUpperChol<MatValueType, ExecSpace>::operator()(Tacho::Experimental::TaskFunctor_SolveUpperChol<MatValueType, ExecSpace>::member_type&, Tacho::Experimental::TaskFunctor_SolveUpperChol<MatValueType, ExecSpace>::value_type&)’:
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_SolveUpperChol.hpp:85:32: warning: declaration of ‘const ordinal_type r_val’ shadows a parameter [-Wshadow]
const ordinal_type r_val = solve_internal(member, _s.max_decendant_schur_size, true);
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_SolveUpperChol.hpp:81:56: note: shadowed declaration is here
void operator()(member_type &member, value_type &r_val) {
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_SolveUpperChol.hpp:89:32: warning: declaration of ‘const ordinal_type r_val’ shadows a parameter [-Wshadow]
const ordinal_type r_val = solve_internal(member, _s.n - _s.m, false);
^
/home/jhu/trilinos/Trilinos/packages/shylu/shylu_node/tacho/src/TachoExp_TaskFunctor_SolveUpperChol.hpp:81:56: note: shadowed declaration is here
void operator()(member_type &member, value_type &r_val) {