Tpetra: Ignore Teuchos_ENABLE_LONG_LONG_INT
Created by: mhoemmen
See PR #2547, Issue #2498 (closed), and PR #2499 for context. Several years ago, the way to tell Tpetra to disable GlobalOrdinal=long long
support, was to set Teuchos_ENABLE_LONG_LONG_INT:BOOL=OFF
. There was apparently no other way to do it. That was bad.
Later on, we added proper Tpetra options for enabling or disabling GlobalOrdinal=long long
support, in Tpetra. However, users tend to keep and reuse CMake configuration options for Trilinos. As a result, users kept expecting that Teuchos_ENABLE_LONG_LONG_INT:BOOL=OFF
would work. #2495 (closed) is an example of an issue that came up for this reason.
I worked around this with PR #2499, but the right approach is for Tpetra simply to ignore this CMake option. Users should not set this Teuchos option any more! Teuchos requires C++11 -- it has for a while -- and C++11 requires long long
. We shouldn't be afraid to remove old options.
I would also like Teuchos to require that this option always be ON, but that's a separate issue.
@trilinos/tpetra