Add MueLu "Refactor" enables to auto PR and ATDM Trilinos builds
Created by: bartlettroscoe
CC: @trilinos/framework, @rppawlo, @bathmatt, @micahahoward, @fryeguy52, @trilinos/muelu, @trilinos/kokkos
Next Action Status
PR #3716 merged on 10/23/2018 automatically enables these "Kokkos Refactor" options by default for all OpenMP and CUDA builds. This was confirmed in the CMakeCache file for the build Trilinos-atdm-waterman-cuda-9.2-debug
on 10/25/2018 shown here. Next: Get confirmation from @jmgate that these options have been removed from the EMPIRE's EM-Plasma BuildScripts/ALL/configure-trilinos.sh
script ...
Description
As of 5/2/2018, The EMPIRE build of Trilinos is now enabling the options:
-D MueLu_ENABLE_Kokkos_Refactor:BOOL=ON \
-D Xpetra_ENABLE_Kokkos_Refactor:BOOL=ON \
-D MueLu_ENABLE_Kokkos_Refactor_Use_By_Default:BOOL=ON \
in the script BuildScripts/ALL/configure-trilinos.sh
in the EM-Plasma/BuildScripts
git repo as of commit:
commit fc167d95c1ac4bc810050ababbf94a80c860dbe2
Author: Matt Bettencourt <mbetten@sandia.gov>
Date: Tue May 1 10:31:30 2018 -0600
Added options suggested by JHu
diff --git a/ALL/configure-trilinos.sh b/ALL/configure-trilinos.sh
index c23b5fa..d189d5c 100755
--- a/ALL/configure-trilinos.sh
+++ b/ALL/configure-trilinos.sh
@@ -201,6 +201,9 @@ cmake \
-D Kokkos_ENABLE_Cuda_Lambda:BOOL=${USE_CUDA} \
-D Kokkos_ENABLE_Debug_Bounds_Check:BOOL=${BOUNDS_CHECK} \
-D KOKKOS_ARCH=${Kokkos_Arch} \
+-D MueLu_ENABLE_Kokkos_Refactor:BOOL=ON \
+-D Xpetra_ENABLE_Kokkos_Refactor:BOOL=ON \
+-D MueLu_ENABLE_Kokkos_Refactor_Use_By_Default:BOOL=ON \
-D Panzer_ENABLE_EXPLICIT_INSTANTIATION:BOOL=ON \
-D Panzer_ENABLE_FADTYPE:STRING="Sacado::Fad::DFad<RealType>" \
-D Panzer_ENABLE_TESTS:BOOL=ON \
Because of this, we need to add these options to the Trilinos auto PR builds (#2317 (closed)) and the ATDM Trilinos builds (TRIL-171).
Another solution would be to change MueLu to turn these options on by default for non-Windows systems and then to support Windows, disable these by default.
That latter is likely preferable from a SNL Trilinos customer perspective. Trilinos, by default, should configure in a way that supports our most important customers and then require extra options to configure in other ways for other customers. Right now, enabling Kokkos by default should be the norm, not the exception.
Related Issues
- Related to: #2317 (closed)