Panzer: Implicit dependence on Tpetra::DefaultPlatform include via Teko
Created by: mhoemmen
@trilinos/panzer @trilinos/teko @trilinos/tpetra
Panzer depends implicitly on Teko including Tpetra_DefaultPlatform.hpp
. This hinders the planned deprecation and removal of Tpetra::DefaultPlatform
.
Expectations
Code that depends on a class' declaration must include a header file that declares the class. This insulates the code from otherwise harmless upstream header file include changes.
Motivation and Context
See #57.
Possible Solution
- Provide the necessary
Tpetra_DefaultPlatform.hpp
includes where needed in Panzer. - Stop using
Tpetra::DefaultPlatform
.
a. If you want the defaultNode
type, doTpetra::Map<>::node_type
. b. You no longer need to create Node instances, so don't callgetNode()
any more. c. If you want the defaultComm
instance, callTpetra::getDefaultComm()
. It lives inTpetra_Core.hpp
.
Related Issues
- Blocks #3095 (closed), #57