MueLu: AlgebraicPermutationStrategy does reductions on scalar instead of a magnitude type
Created by: lucbv
@trilinos/muelu @mhoemmen
Expectations
MueLu_AlgebraicPermutationStrategy_def.hpp should not perform reductions on Scalar
, especially with the REDUCE_MIN/MAX
closure. Instead perform said reductions on Teuchos::ScalarTraits<Scalar>::magnitudeType
. This will alleviate issues of performing a reduction on std::complex<>
.
Current Behavior
Currently it is unclear that the results coming out of the MPI reductions are probably not useful when Scalar=std::complex<>
.
Motivation and Context
This is a bug it needs to be fixed...
Possible Solution
Carefully adjust types in the class so that all reductions are performed on magnitudeType
if possible.
Related Issues
- Follows #3480 (closed)
- Precedes
- Related to
- Part of
- Composed of