PyTrilinos: Standardize Configuration Macros
Created by: wfspotz
@trilinos/pytrilinos
Expectations
Configuration macros for PyTrilinos should be consistently named and distinct from other packages.
Current Behavior
Some configuration macros are not distinct (HAVE_EPETRA
), some are distinct (HAVE_PYTRILINOS_AZTECOO
), and some are redundant (HAVE_PYTRILINOS_EPETRA
).
Motivation and Context
@mhoemmen made some suggestions while reviewing #3575, which led to the observation that this needs to be cleaned up.
Definition of Done
-
Eliminate HAVE_<PACKAGE>
macros in favor ofHAVE_PYTRILINOS_<PACKAGE>
macros inPyTrilinos_config.h.in
-
HAVE_EPETRA
➡ HAVE_PYTRILINOS_EPETRA
-
HAVE_TPETRA
➡ HAVE_PYTRILINOS_TPETRA
-
HAVE_DOMI
➡ HAVE_PYTRILINOS_DOMI
-
HAVE_NOX_EPETRA
➡ HAVE_PYTRILINOS_NOX_EPETRA
-
HAVE_NOX_EPETRAEXT
➡ HAVE_PYTRILINOS_NOX_EPETRAEXT
-
HAVE_NOX_PETSC
➡ HAVE_PYTRILINOS_NOX_PETSC
-
EpetraExt_BUILD_MODEL_EVALUATOR
➡ ️HAVE_PYTRILINOS_EPETRAEXT_MODEL_EVALUATOR
-
-
Make same changes in PyTrilinos headers and source files -
Test for Teuchos-only configuration -
Test for linear solver only configuration -
Test for linear and nonlinear solver only configuration -
Test for full configuration