Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Trilinos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 936
    • Issues 936
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • James Willenbring
  • Trilinos
  • Issues
  • #381

Closed
Open
Created May 23, 2016 by James Willenbring@jmwilleMaintainer

Tpetra::CrsMatrix: Implement "DualView" (better: "dual view") semantics

Created by: mhoemmen

@trilinos/tpetra Tpetra::MultiVector already implements "dual view" semantics. We need the other modifiable Tpetra classes to implement this as well.

Tpetra::CrsMatrix needs to implement the following interface:

  • sync<MemorySpace>(): Sync to the given memory space
  • modify<MemorySpace>(): Mark data in the given memory space as modified
  • bool need_sync<MemorySpace>() const: Do we need a sync to the given memory space?
  • local_matrix_type getLocalMatrix<MemorySpace>() const: Get the KokkosSparse::CrsMatrix living in the given memory space

Currently, getLocalMatrix is not templated, and returns the version of the data living in Tpetra::CrsMatrix::device_type::memory_space. Tpetra::CrsMatrix does not yet provide any of the other methods.

It does not make sense for Tpetra::CrsGraph to implement dual view semantics until that class' interface allows thread-parallel graph construction (other than by constructing a Kokkos::StaticCrsGraph in a thread-parallel way, and handing it to Tpetra::CrsGraph's constructor). Thus, this Tpetra::CrsMatrix issue only refers to the fixed graph case -- either when the matrix was created using a const graph, or after the matrix's first fillComplete call.

Assignee
Assign to
Time tracking