Ifpack2: Build warning in test, suggesting incorrectness or unexpected behavior (#4036) · Issues · James Willenbring / Trilinos

Ifpack2: Build warning in test, suggesting incorrectness or unexpected behavior

Created by: mhoemmen

@trilinos/ifpack2

I get the following build warning with GCC 7.2 and CUDA (ATDM build):

.../Trilinos/packages/ifpack2/test/unit_tests/Ifpack2_UnitTestBlockTriDiContainerUtil.hpp: In lambda function:
/scratch/mhoemme/sparc/Trilinos/packages/ifpack2/test/unit_tests/Ifpack2_UnitTestBlockTriDiContainerUtil.hpp:249:34: warning: comparison of constant ‘1’ with boolean expression is always false [-Wbool-compare]
           input.tolerance = norm_based > 1 ? tol : 0;
                       ~~~~~~~~~~~^~~

It looks like this is an operator precedence issue.