Teuchos errors in Werror build

Created by: jwillenbring

@trilinos/teuchos @bartlettroscoe @hkthorn @mhoemmen

Expectations

Teuchos should build warning free as a matter of code quality, and because of important customer requirements. We are currently using the following cxxflags for this build:

-Wall -ansi -pedantic -Werror -Wno-unknown-pragmas -Wno-narrowing -Wno-pragmas -Wno-delete-non-virtual-dtor

Current Behavior

Currently Teuchos has a number of warnings that are promoted to errors in this build as seen here.

Motivation and Context

We are working to set up dev->master and pull request builds that use these flags for GCC 7.2 to protect the code from the introduction of more warnings. We are starting with some low-level packages as some warnings from these packages have the potential to impact packages downstream in this build.

Definition of Done

Teuchos builds warning free with the flags above for GCC 7.2.

Steps to Reproduce

The GitHub Trilinos fork

jwillenbring/Trilinos

has a branch

jwillenbring-PR-Werror-2

that can be merged in to test via submitting a PR. If that is done, only the Teuchos changes should be merged for now (not the PR test definition changes). Alternatively, @jwillenbring can test any proposed solutions if you prefer.