GitLab

Created by: CamelliaDPG

@trilinos/tpetra

Expectations

Builds with clang that use the -Wshadow flag should not emit warnings.

Current Behavior

Three such warnings are emitted by clang when building MatrixMarket_Tpetra.hpp.

.../include/MatrixMarket_Tpetra.hpp:6896:56: warning: declaration shadows a typedef in 'Writer<SparseMatrixType>' [-Wshadow]
        typedef typename multivector_type::scalar_type scalar_type;
                                                       ^
.../include/MatrixMarket_Tpetra.hpp:5844:54: note: previous declaration is here
      typedef typename SparseMatrixType::scalar_type scalar_type;
                                                     ^
.../include/MatrixMarket_Tpetra.hpp:7021:56: warning: declaration shadows a typedef in 'Writer<SparseMatrixType>' [-Wshadow]
        typedef typename multivector_type::scalar_type scalar_type;
                                                       ^
.../include/MatrixMarket_Tpetra.hpp:5844:54: note: previous declaration is here
      typedef typename SparseMatrixType::scalar_type scalar_type;
                                                     ^
.../include/MatrixMarket_Tpetra.hpp:976:57: warning: declaration shadows a typedef in 'Reader<SparseMatrixType>' [-Wshadow]
        typedef typename ArrayView<const GO>::size_type size_type;
                                                        ^
.../include/MatrixMarket_Tpetra.hpp:220:49: note: previous declaration is here
      typedef Teuchos::ArrayRCP<int>::size_type size_type;

Environment

I'm building on a Mac using Apple clang 10.0.0.