Skip to content

GitLab

Closed
Opened by James Willenbring@jmwilleMaintainer

Deprecation in Tpetra::CrsMatrix constructor triggers warning in Xpetra that crashes the SPARC build

Created by: bartlettroscoe

CC: @trilinos/xpetra, @trilinos/tpetra , @kddevin (Trilinos Data Services Product Lead), @bartlettroscoe, @fryeguy52, @mhoemmen

Next Action Status

Description

The commit 24cef755 merged in PR #4748 deprecated a constructor for Tpetra::CrsMatrix and triggered a deprecated warning when SPARC builds showing the error:

/projects/atdm_devops/trilinos_installs/2019-03-29/cee-rhel6_clang-5.0.1_openmpi-1.10.2_serial_static_opt/include/Xpetra_TpetraCrsMatrix.hpp:109:31: error: 'CrsMatrix' is deprecated [-Werror,-Wdeprecated-declarations]
     : mtx_(Teuchos::rcp(new Tpetra::CrsMatrix (toTpetra(rowMap), NumEntriesPerRowToAlloc, toTpetra(pftype), params))) {  }

This deprecated warning (elevated to an error in SPARC because they set -Werror) is triggered inside of Trilinos headers but is not shown in the Xpetra test suite shown here. Does this show a gap in the automated tests for Xpetra?

Current Status on CDash

The current status can only be seen in the SPARC Trilinos Integration builds shown over the last few days here.

Steps to Reproduce

Since the native test suite does not show a problem, one can only reproduce this by building SPARC itself. See the instructions for doing that here.

But if one wants to reproduce say the clang-5.0.1 build on a CEE RHEL6 machine, one can follow the instructions at:

More specifically, the commands given for the system 'cee-rhel6' are provided at:

The exact commands to reproduce this issue should be:

$ cd <some_build_dir>/

$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh \
    Trilinos-atdm-cee-rhel6_clang-5.0.1_openmpi-1.10.2_serial_static_opt

$ cmake \
 -GNinja \
 -DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
 -DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_Xpetra=ON \
 $TRILINOS_DIR

$ make NP=16

But of course that does not show a warning so Xpetra needs to be upgraded to reproduce that warning.