Ifpack2_Relaxation_def.hpp variable template C++14 extension warning breaking SPARC Trilinos Integration builds starting 4/18/2019
Created by: bartlettroscoe
CC: @trilinos/ifpack2, @srajama1 (Trilinos Linear Solvers Product Lead), @bartlettroscoe, @fryeguy52
??: Add label "client: ATDM"> ??: Add label "ATDM Sev: Blocker" (by default but could be other "ATDM Sev: XXX")> ??: Add label "type: bug"?> ??: Add label for affected packages (e.g. "pkg: MueLu", "pkg: Tpetra", "pkg: Kokkos", etc.)> ??: Add label "PA: ???Project Area???" (e.g. "PA: Linear Solvers", "PA: Data Services")> ??: Add milestone "Initial cleanup of new ATDM ..." or "Keep promoted ATDM ..."> ??: Once GitHub Issue is created, add entries for tests to TrilinosATDMStatus/*.csv files>Next Action Status
Description
The new warning elevated to an error:
Ifpack2_Relaxation_def.hpp:147:6: error: variable templates are a C++14 extension [-Werror,-Wc++14-extensions]
void Relaxation::updateCachedMultiVector(const Teuchos::RCP > & map, size_t numVecs) const{
^is breaking the SPARC Trilinos integration builds as shown here with that warning being shown here
Current Status on CDash
Steps to Reproduce
I can't see this warning being generated in the Ifack2 package build itself for the build Trilinos-atdm-cee-rhel6_clang-5.0.1_openmpi-1.10.2_serial_static_opt so I am not sure one can reproduce this just with Trilinos. (Does this suggest a lack of test coverage for Ifpack2?)
But if one can get on the CEE LAN and can clone the SPARC repos, then one can reproduce using the scripts described here. After getting Trilinos on to the 'develop' branch as described here, one can reproduce this using the command:
$ cd sparc/
$ env \
ATDM_TRIL_SPARC_BUILDS_LIST=cee-rhel6_clang-5.0.1_openmpi-1.10.2_serial_static_opt \
ATDM_TRIL_SPARC_SKIP_NATIVE_BUILD=1 \
./sparc-tril-dev-scripts/run_builds_and_tests.sh