Tpetra, Teuchos, etc. compiler warnings being treated as errors for unused functions in Sierra - Trilinos integration

Created by: ajpowelsnl

Bug Report

@trilinos/tpetra @trilinos/teuchos

Sierra - Trilinos integration is failing because the compiler is treating warnings as errors in these :

-Werror=unused-function

There are ~ 8000 instances of this type of error (see enclosed log): grep -c [-Werror=unused-function] sierra_trilinos_int_042919.txt 8081

sierra_trilinos_int_042919.txt.zip

Description

Representative error --

/scratch/ajpowel/sierra_code_042619/fuego/src/nonconformal/Afgo_NonConformalDiffusiveScalarAlgorithm.C:16:
/scratch/ajpowel/sierra_code_042619/objs/tpls/trilinos_tpls/b2ed81b8c8472240/include/Tpetra_CrsMatrix_def.hpp:89:3: error: 'std::shared_ptr<Tpetra::Details::CommRequest> Tpetra::{anonymous}::iallreduceIntRaw(const int&, int&, Teuchos::EReductionType, const Teuchos::Comm<int>&)' defined but not used [-Werror=unused-function]
   iallreduceIntRaw (const int& localValue,
   ^~~~~~~~~~~~~~~~

Steps to Reproduce

1. Set your development environment; module load sierra-devel;
2. Clone a ${SIERRA_CODE_PROJECT};
3. cd to the ${SIERRA_CODE_PROJECT};
4. rm -fr TPLs_src/Trilinos;
5. git clone github.com/Trilinos/trilinos TPLs_src/Trilinos
6. bake --verbose trilinos-integration=on