Trilinos merge requestshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests2019-05-07T04:08:54Zhttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/5113Clean up a warning & set Werror for Pamgen2019-05-07T04:08:54ZJames WillenbringClean up a warning & set Werror for Pamgen*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/pamgen @trilinos/framework
## Description
<!--- Please describe your changes in detail. -->
This removes a couple of lines that are unused variables and sets Werror for Pamgen.
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
This is work towards #3178 and takes care of #5104.
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
<!---
## Screenshots
Not obligatory, but is there anything pertinent that we should see?
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/5111Move the gcc 4.8.4 build to use static libraries2019-05-06T19:40:38ZJames WillenbringMove the gcc 4.8.4 build to use static libraries*Created by: prwolfe*
@trilinos/framework
## Description
This is the changes needed to the PR environment and scripts to get the gcc 4.8.4 build to use static libraries. Note that the build still fails on some missing template inst...*Created by: prwolfe*
@trilinos/framework
## Description
This is the changes needed to the PR environment and scripts to get the gcc 4.8.4 build to use static libraries. Note that the build still fails on some missing template instantiations so this cannot merge until those issues are resolved.
## Motivation and Context
Builds for external customers should work withe either shared or static libraries
## Related Issues
* Closes #5058
## How Has This Been Tested?
I used the instructions at https://github.com/trilinos/Trilinos/wiki/Reproducing-PR-Testing-Errors to build this locally.
## Checklist
- [ x ] My commit messages mention the appropriate GitHub issue numbers.
- [ ] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [ x ] All new and existing tests passed.
- [ ] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
Additional issues for the template problems will be created directly.