Trilinos merge requestshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests2018-12-18T09:10:21Zhttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4064Enable TeuchosNumerics_LAPACK_test_MPI_1 test in 'debug' Power8 and Power8 bu...2018-12-18T09:10:21ZJames WillenbringEnable TeuchosNumerics_LAPACK_test_MPI_1 test in 'debug' Power8 and Power8 builds and disable just the STEQR() test*Created by: bartlettroscoe*
CC: @trilinos/teuchos, @fryeguy52
## Description
Enable TeuchosNumerics_LAPACK_test_MPI_1 test in 'debug' Power8 and Power8 builds and disable just the STEQR() test.
NOTE: This test was being disa...*Created by: bartlettroscoe*
CC: @trilinos/teuchos, @fryeguy52
## Description
Enable TeuchosNumerics_LAPACK_test_MPI_1 test in 'debug' Power8 and Power8 builds and disable just the STEQR() test.
NOTE: This test was being disabled in some `release-debug` builds where it did not need to be disabled. In fact, the `STEQR()` function does not segfault when using optimized compiler options (which are used in a `release-debug` build).
## Motivation and Context
We need to be running LAPACK tests for the functions being used by Trilinos and not disable them all (see #2410).
## How Has This Been Tested?
On 'ride' I did:
```
$ bsub -x -Is -q rhel7F -n 16 \
./checkin-test-atdm.sh \
cuda-9.2-debug gnu-openmp-debug \
--enable-packages=TeuchosNumerics --local-do-all
```
which returned:
```
PASSED (NOT READY TO PUSH): Trilinos: ride10
Mon Dec 17 08:51:43 MST 2018
Enabled Packages: TeuchosNumerics
Build test results:
-------------------
1) cuda-9.2-debug => passed: passed=16,notpassed=0 (1.50 min)
2) gnu-openmp-debug => passed: passed=16,notpassed=0 (0.60 min)
```
and showed:
```
$ for build_name in cuda-9.2-debug gnu-openmp-debug ; do grep -nH TeuchosNumerics_LAPACK_test ${build_name}/ctest.out ; done | grep "Pass"
cuda-9.2-debug/ctest.out:33:16/16 Test #9: TeuchosNumerics_LAPACK_test_MPI_1 .................. Passed 0.43 sec
gnu-openmp-debug/ctest.out:30:13/16 Test #9: TeuchosNumerics_LAPACK_test_MPI_1 .................. Passed 1.88 sec
```
And I ran this on 'waterman' using:
```
$ bsub -x -Is -n 20 \
./checkin-test-atdm.sh \
cuda-9.2-debug cuda-9.2-release-debug gnu-openmp-release-debug \
--enable-packages=TeuchosNumerics --local-do-all
```
which returned:
```
PASSED (NOT READY TO PUSH): Trilinos: waterman1
Mon Dec 17 08:56:33 MST 2018
Enabled Packages: TeuchosNumerics
Build test results:
-------------------
1) cuda-9.2-debug => passed: passed=16,notpassed=0 (1.20 min)
2) cuda-9.2-release-debug => passed: passed=16,notpassed=0 (1.34 min)
3) gnu-openmp-release-debug => passed: passed=16,notpassed=0 (1.08 min)
```
and showed:
```
$ for build_name in cuda-9.2-debug cuda-9.2-release-debug gnu-openmp-release-debug ; do grep -nH TeuchosNumerics_LAPACK_test ${build_name}/ctest.out ; done | grep "Pass"
cuda-9.2-debug/ctest.out:32:15/16 Test #9: TeuchosNumerics_LAPACK_test_MPI_1 .................. Passed 2.20 sec
cuda-9.2-release-debug/ctest.out:29:12/16 Test #9: TeuchosNumerics_LAPACK_test_MPI_1 .................. Passed 2.24 sec
gnu-openmp-release-debug/ctest.out:26: 9/16 Test #9: TeuchosNumerics_LAPACK_test_MPI_1 .................. Passed 4.10 sec
```
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4151Stacked timer unit testing support2019-01-10T19:16:32ZJames WillenbringStacked timer unit testing support*Created by: rppawlo*
Some applications are writing unit testing scripts that rely on StackedTimer data. This commit adds queries and overrides of Timer values to help support unit testing of the StackedTimer for both Trilinos and withi...*Created by: rppawlo*
Some applications are writing unit testing scripts that rely on StackedTimer data. This commit adds queries and overrides of Timer values to help support unit testing of the StackedTimer for both Trilinos and within the applications.
Also cleaned up some inconsistent naming conventions.https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4146Teuchos: fix for #41452019-01-10T19:17:06ZJames WillenbringTeuchos: fix for #4145*Created by: rppawlo*
Addresses #4145.*Created by: rppawlo*
Addresses #4145.https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4157Trilinos: Code cleanup2019-01-10T22:35:13ZJames WillenbringTrilinos: Code cleanup*Created by: rppawlo*
This set of commits covers the following:
1. Fix compiler warnings for unused parameter in Ifpack
2. Fix (most) shadow warnings in PIRO
3. Fix all shadow warnings in Panzer
4. Fix ptr use in Teuchos StackedTime...*Created by: rppawlo*
This set of commits covers the following:
1. Fix compiler warnings for unused parameter in Ifpack
2. Fix (most) shadow warnings in PIRO
3. Fix all shadow warnings in Panzer
4. Fix ptr use in Teuchos StackedTimer as suggested in #4151
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4217Add infrastructure for CUDA PR build2019-01-23T17:27:23ZJames WillenbringAdd infrastructure for CUDA PR build*Created by: jwillenbring*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `mast...*Created by: jwillenbring*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
## Description
<!--- Please describe your changes in detail. -->
This PR adds/modifies files in preparation of adding a dev->master CUDA build and then a PR CUDA build.
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
We need to protect against breaking the CUDA build at PR time. This is in response to #2464.
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
## How Has This Been Tested?
<!---
Please describe in detail how you tested your changes. Include details of your
testing environment and the tests you ran to see how your change affects other
areas of the code. Consider including configure, build, and test log files.
-->
@ZUUL42 set up Jenkins infrastructure for this build also, and we have a [large subset of Trilinos tests passing](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=4425385). We have disabled temporarily what is failing so that we can get a PR build in place that will protect what is passing while we work on the remaining issues.
<!---
## Screenshots
Not obligatory, but is there anything pertinent that we should see?
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4241Revert PR #42282019-02-01T18:17:50ZJames WillenbringRevert PR #4228*Created by: mhoemmen*
This reverts commit 24c2eb2f9c622f856a0477a0ef8751b4145ca7b1, reversing
changes made to 7b60b19b90f7cc1066da428b7d8ad18813675a87.
It turns out that this breaks builds if Fortran is not enabled. CMake
apparen...*Created by: mhoemmen*
This reverts commit 24c2eb2f9c622f856a0477a0ef8751b4145ca7b1, reversing
changes made to 7b60b19b90f7cc1066da428b7d8ad18813675a87.
It turns out that this breaks builds if Fortran is not enabled. CMake
apparently permits the configuration to proceed, but the build fails
with a missing header file. This revert should fix the following issues:
https://github.com/kokkos/kokkos-kernels/issues/372
https://github.com/trilinos/Trilinos/issues/4237
https://github.com/trilinos/Trilinos/issues/4235
#4242
@trilinos/kokkos-kernels
## Related Issues
* Closes https://github.com/kokkos/kokkos-kernels/issues/372, #4235, #4237
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4308Disable Fortran for 4.9.3 SERIAL build Fix Issue #42382019-02-07T23:38:59ZJames WillenbringDisable Fortran for 4.9.3 SERIAL build Fix Issue #4238*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
## Description
Disabled Fortran for the automated GCC 4.9.3 SERIAL build.
## Motivation and Context
This should address Issue #4238 . There are several projects and OSX users that disable Fortran when building Trilinos. This will make sure there is a Fortran-less configuration and PR build running to cover that.
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
## How Has This Been Tested?
Had this branch built successfully by Jenkins. [Everything builds and tests successfully](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=4474639).
<!---
## Screenshots
Not obligatory, but is there anything pertinent that we should see?
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4336Revert "Issue4258 remove teuchos sdmatrix inheritance"2019-02-11T07:49:04ZJames WillenbringRevert "Issue4258 remove teuchos sdmatrix inheritance"*Created by: bartlettroscoe*
CC: @trilinos/teuchos
Reverts trilinos/Trilinos#4259
Need to revert as per #4330. Someone needs to create a new issue to make these changes that preserve the existing `operator<<()` function.
*Created by: bartlettroscoe*
CC: @trilinos/teuchos
Reverts trilinos/Trilinos#4259
Need to revert as per #4330. Someone needs to create a new issue to make these changes that preserve the existing `operator<<()` function.
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4374Teuchos errors in Werror build2019-02-12T07:39:37ZJames WillenbringTeuchos errors in Werror build*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
@trilinos/teuchos
## Description
<!--- Please describe your changes in detail. -->
This turns on Warnings as Errors for Teuchos with the exception of:
-Wno-clobbered -Wno-vla -Wno-pragmas -Wno-unknown-pragmas -Wno-unused-local-typedefs -Wno-literal-suffix -Wno-deprecated-declarations -Wno-misleading-indentation -Wno-int-in-bool-context -Wno-maybe-uninitialized -Wno-nonnull-compare -Wno-address -Wno-inline
<!--- Why is this change required? What problem does it solve? -->
This addresses Issue #4254 "Teuchos errors in Werror build".
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
## How Has This Been Tested?
<!---
Please describe in detail how you tested your changes. Include details of your
testing environment and the tests you ran to see how your change affects other
areas of the code. Consider including configure, build, and test log files.
-->
This has been [built to develop without issue](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=4534802).
<!---
## Screenshots
Not obligatory, but is there anything pertinent that we should see?
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4405Enable Werror on 5 packages2019-02-15T16:08:53ZJames WillenbringEnable Werror on 5 packages*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
## Description
<!--- Please describe your changes in detail. -->
This enables Werror for @trilinos/kokkos-kernels, @trilinos/sacado, @trilinos/shards, @trilinos/phalanx, & @trilinos/panzer
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
This is continuing work on Issue #3178
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
## How Has This Been Tested?
<!---
Please describe in detail how you tested your changes. Include details of your
testing environment and the tests you ran to see how your change affects other
areas of the code. Consider including configure, build, and test log files.
-->
This has been built successfully with the PR GCC 7.2.0 build. [Results](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=4562967)
<!---
## Screenshots
Not obligatory, but is there anything pertinent that we should see?
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4384Add WError for kokkos2019-02-19T18:19:37ZJames WillenbringAdd WError for kokkos*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
@trilinos/kokkos
## Description
<!--- Please describe your changes in detail. -->
Like PR #4374 for Issue #4254, this turns on Warnings as Errors for kokkos in the GCC 7.2.0 PR build.
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
This addresses Issue #3178 turning on another package for Werror.
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
## How Has This Been Tested?
<!---
Please describe in detail how you tested your changes. Include details of your
testing environment and the tests you ran to see how your change affects other
areas of the code. Consider including configure, build, and test log files.
-->
This has been [built to develop without issue](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=4544446).
<!---
## Screenshots
Not obligatory, but is there anything pertinent that we should see?
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [ ] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4450Turn on Werror for EpetraExt, Pike, & Zoltan22019-02-21T07:04:56ZJames WillenbringTurn on Werror for EpetraExt, Pike, & Zoltan2*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
## Description
<!--- Please describe your changes in detail. -->
This will turn on Warnings as Errors for the @trilinos/epetraext , @trilinos/pike, & @trilinos/zoltan2 packages. It also reformats the flags for a bit cleaner code, sets the warning flags for all packages, and prepares to turn Werror on for all packages individually until they can be turned on for all.
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
This addresses issue #3178
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
## How Has This Been Tested?
<!---
Please describe in detail how you tested your changes. Include details of your
testing environment and the tests you ran to see how your change affects other
areas of the code. Consider including configure, build, and test log files.
-->
This has successfully been test built: [results](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=4597728)
<!---
## Screenshots
Not obligatory, but is there anything pertinent that we should see?
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4121Remove Deprecated Doxygen Options2019-02-25T15:48:05ZJames WillenbringRemove Deprecated Doxygen Options*Created by: jmgate*
@trilinos/framework
## Description
This PR removes obsolete Doxyfile options so they don't show up as warnings when you build Trilinos' documentation.
## Motivation and Context
Warning-free compilation make...*Created by: jmgate*
@trilinos/framework
## Description
This PR removes obsolete Doxyfile options so they don't show up as warnings when you build Trilinos' documentation.
## Motivation and Context
Warning-free compilation makes me happy.
## How Has This Been Tested?
I'm using `doxygen-1.8.14` (looks to be about a year old).https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4494Turn on Werror for Ifpack2, Intrepid2, & Piro2019-02-26T00:11:59ZJames WillenbringTurn on Werror for Ifpack2, Intrepid2, & Piro*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
## Description
<!--- Please describe your changes in detail. -->
This will turn on Warnings as Errors for the @trilinos/ifpack2, @trilinos/intrepid2, & @trilinos/piro packages.
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
This is continued work toward #3178.
## How Has This Been Tested?
<!---
Please describe in detail how you tested your changes. Include details of your
testing environment and the tests you ran to see how your change affects other
areas of the code. Consider including configure, build, and test log files.
-->
This has successfully been test built: [results](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=4622561)
<!---
## Screenshots
Not obligatory, but is there anything pertinent that we should see?
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4516Set Werror for Ifpack2019-03-07T22:33:41ZJames WillenbringSet Werror for Ifpack*Created by: ZUUL42*
EDIT: Modified PR & branch after I saw #4517
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automa...*Created by: ZUUL42*
EDIT: Modified PR & branch after I saw #4517
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
## Description
<!--- Please describe your changes in detail. -->
This sets Werror for Ifpack.
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
This is work toward #3178 turning Werror on for all packages.
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4397Reenable CUDA options2019-03-07T23:26:19ZJames WillenbringReenable CUDA options*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
## Description
<!--- Please describe your changes in detail. -->
This reenables all 34 of the @trilinos/tpetra tests and removes the debug/symbols OFF options in the automated CUDA builds.
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
This is a continuation of work on Issue #2464.
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
## How Has This Been Tested?
<!---
Please describe in detail how you tested your changes. Include details of your
testing environment and the tests you ran to see how your change affects other
areas of the code. Consider including configure, build, and test log files.
-->
This has been manually built successfully to dev. [Results](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=4554580)
<!---
## Screenshots
Not obligatory, but is there anything pertinent that we should see?
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4338Issue 2426 Enable Complex Doubles2019-03-07T23:26:29ZJames WillenbringIssue 2426 Enable Complex Doubles*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
## Description
<!--- Please describe your changes in detail. -->
This will enable Complex Doubles in the GCC 7.2.0 build
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
Addresses Issue #2426 PR testing should enable complex by default
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
## How Has This Been Tested?
<!---
Please describe in detail how you tested your changes. Include details of your
testing environment and the tests you ran to see how your change affects other
areas of the code. Consider including configure, build, and test log files.
-->
This has been tested to develop a number of times. The issues have been worked out and enabling complex doubles is ready to go.
https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=4504696
<!---
## Screenshots
Not obligatory, but is there anything pertinent that we should see?
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4578Set Werror for MueLu, Stokhos, & Tempus2019-03-18T16:54:56ZJames WillenbringSet Werror for MueLu, Stokhos, & Tempus*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
## Description
<!--- Please describe your changes in detail. -->
This sets -Werror for MueLu, Stokhos, & Tempus.
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
This is work toward #3178 turning Werror on for _all_ packages in the GCC 7.2.0 PR build.
Allowed by work from Issue/PR #4513/#4543 #4515/#4552 & #4510/#4522.
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4611Setup all Werror ICC flags & activate those flags for Pike & Tempus2019-03-19T18:46:03ZJames WillenbringSetup all Werror ICC flags & activate those flags for Pike & Tempus*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
@trilinos/pike
## Description
<!--- Please describe your changes in detail. -->
This sets puts all Werror flags in place for the ICC build to be activated individually at a package level.
It will also set Werror for Pike in the ICC build.
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
This is work toward #3178 turning Werror on for all packages in the ICC build.
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
## How Has This Been Tested?
<!---
Please describe in detail how you tested your changes. Include details of your
testing environment and the tests you ran to see how your change affects other
areas of the code. Consider including configure, build, and test log files.
-->
Run through a test build to confirm Pike builds with Werror flags set.
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->
https://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/4604Set Werror for NOX2019-03-19T18:46:07ZJames WillenbringSet Werror for NOX*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` wi...*Created by: ZUUL42*
<!---
Be sure to select `develop` as the `base` branch against which to create this
pull request. Only pull requests against `develop` will undergo Trilinos'
automated testing. Pull requests against `master` will be ignored.
Provide a general summary of your changes in the Title above. If this pull
request pertains to a particular package in Trilinos, it's worthwhile to start
the title with "PackageName: ".
Note that anything between these delimiters is a comment that will not appear
in the pull request description once created. Most areas in this message are
commented out and can be easily added by removing the comment delimiters.
Please make sure to mark:
* Reviewers
* Assignees
* Labels
Replace <teamName> below with the appropriate Trilinos package/team name.
-->
@trilinos/framework
## Description
<!--- Please describe your changes in detail. -->
This sets Werror for NOX.
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
This is work toward #3178 turning Werror on for all packages.
<!---
If applicable, let us know how this merge request is related to any other open
issues or pull requests:
## Related Issues
* Closes
* Blocks
* Is blocked by
* Follows
* Precedes
* Related to
* Part of
* Composed of
-->
Allowed by work from Issue #4509 & PR #4575.
<!---
Go over all the following points, and put an `x` in all the boxes that apply.
If you are unsure about any of these, please ask—we are here to help.
-->
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
<!---
## Additional Information
Anything else we need to know in evaluating this merge request?
-->