Trilinos merge requestshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests2018-05-25T17:34:40Zhttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2824Tril 198 cmake 3.11.2 ninja 1.8.22018-05-25T17:34:40ZJames WillenbringTril 198 cmake 3.11.2 ninja 1.8.2*Created by: bartlettroscoe*
CC: @fryeguy52
## Description
Updated ATDM Trilinos builds on 'white' and 'ride' to use manually installed CMake 3.11.2 and Ninja 1.8.2 (which supports CMake Fortran builds). I also did some refactor...*Created by: bartlettroscoe*
CC: @fryeguy52
## Description
Updated ATDM Trilinos builds on 'white' and 'ride' to use manually installed CMake 3.11.2 and Ninja 1.8.2 (which supports CMake Fortran builds). I also did some refactoring to remove duplication. See the commit log messages and diffs. There are not many changes here.
## Motivation and Context
There is hope that this will address several issues.
* The ninja module load failures in the Jenkins builds on 'ride' (see [TRIL-208](https://software-sandbox.sandia.gov/jira/browse/TRIL-208)).
* Crashing of 'bsub' on 'white' and 'ride' (see [TRIL-198](https://software-sandbox.sandia.gov/jira/browse/TRIL-198)). (Hoping the new libuv implementation of the ctest test job runner may magically fix the problems with 'bsub' crashing while running tests with ctest -S.)
## How Has This Been Tested?
I did quite a bit of manual testing for these changes. I think this is pretty solid.
* Do local testing on 'white':
- checkin-test-atdm.sh [Done]
- Jenkins driver [Done]
* Set up experimental Jenkins job 'Trilinos-atdm-white-ride-cuda-opt' on jenkins-son.sandia.gov that runs a build on branch tril-198-cmake-3.11.2-ninja-1.8.2 of my fork. => See [Jenkins log[(https://jenkins-son.sandia.gov/view/Trilinos%20ATDM/job/Trilinos-atdm-white-ride-cuda-opt/9/console) and [CDash build](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=3546221).
* Do local testing on 'ride':
- checkin-test-atdm.sh [Done]
- Jenkins driver [Done]
* Set up experimental Jenkins jobs on jenkins-srn.sandia.gov that runs build on branch tril-198-cmake-3.11.2-ninja-1.8.2 => See [Jenkins log](https://jenkins-srn.sandia.gov/view/Trilinos%20ATDM/job/Trilinos-atdm-white-ride-cuda-debug-exp/1/console) and [CDash build](https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&parentid=3546254).
* Do local testing on 'serrano' (to test change in split Jenkins driver):
- checkin-test-atdm.sh [Done]
- Jenkins driver [Done]
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] All new and existing tests passed.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2802Switch to all-at-once approach for 'toss3' builds on 'serrano' (TRIL-200, #2699)2018-05-22T23:29:10ZJames WillenbringSwitch to all-at-once approach for 'toss3' builds on 'serrano' (TRIL-200, #2699)*Created by: bartlettroscoe*
Now that the new testing-vm.sandia.gov site is sending out emails, I think
this is a safe thing to do. I am hoping this will help to avoid timeouts in
the sbatch command running the tests on 'serrano'.
...*Created by: bartlettroscoe*
Now that the new testing-vm.sandia.gov site is sending out emails, I think
this is a safe thing to do. I am hoping this will help to avoid timeouts in
the sbatch command running the tests on 'serrano'.
I did not test this. But this was a copy-and-paste from the other driver scripts for 'white'/'ride' that was tested and it is an extremely safe change. Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2792Switch all builds on 'white' and 'ride' to use all-at-oce approch (TRIL-198)2018-05-22T18:18:46ZJames WillenbringSwitch all builds on 'white' and 'ride' to use all-at-oce approch (TRIL-198)*Created by: bartlettroscoe*
Given data from past runs, this should result in less frequent crashing of the
'bsub' command. This will also just speed up the build by about a factor of 2
and speed up running the tests by about 25%.
...*Created by: bartlettroscoe*
Given data from past runs, this should result in less frequent crashing of the
'bsub' command. This will also just speed up the build by about a factor of 2
and speed up running the tests by about 25%.
I tested this locally on 'white' with:
```
$ time env \
JOB_NAME=Trilinos-atdm-white-ride-cuda-debug \
WORKSPACE=$PWD \
Trilinos_PACKAGES=Kokkos,Teuchos \
CTEST_TEST_TYPE=Experimental \
CTEST_DO_SUBMIT=OFF \
CTEST_DO_UPDATES=OFF \
CTEST_START_WITH_EMPTY_BINARY_DIRECTORY=FALSE ~/Trilinos.base/Trilinos/cmake/ctest/drivers/atdm/smart-jenkins-driver.sh \
&> console.out
```
and it showed that it used the all-at-once approach.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2759Tril 200 serrano fixups2018-05-17T15:14:51ZJames WillenbringTril 200 serrano fixups*Created by: bartlettroscoe*
@trilinos/<teamName>
## Description
This PR contains several fix-ups for the builds on 'serrano'. See the set of commits for what the changes are. There are good descriptions in the log messages in t...*Created by: bartlettroscoe*
@trilinos/<teamName>
## Description
This PR contains several fix-ups for the builds on 'serrano'. See the set of commits for what the changes are. There are good descriptions in the log messages in those.
However, the big things are:
* Disable the Panzer test `PanzerAdaptersSTK_MixedPoissonExample-ConvTest-Hex-Order-3` for intel-debug-openmp builds (#2751, commit 652a011)
* Try to fix failing tests by setting `KOKKOS_ARCH=BDW` (1a271e5) and switch to `mpiexec --bind-by socket` (e1944ed) (#2699)
* Enabled the usage of Ninja (297cf26)
## Related Issues
* Related to: #2751, #2699
## How Has This Been Tested?
I tested this locally on 'serrano' using:
```
$ ./checkin-test-atdm.sh intel-opt-openmp \
--enable-packages=Kokkos,Panzer --allow-no-pull --configure --build --send-email-to=
$ salloc -N1 --time=0:20:00 --account=fy150090 \
./checkin-test-atdm.sh intel-opt-openmp \
--enable-packages=Kokkos,Panzer --test
```
This gave the result:
```
PASSED (NOT READY TO PUSH): Trilinos: serrano-login5
Wed May 16 08:23:59 MDT 2018
Enabled Packages: Kokkos, Panzer
Build test results:
-------------------
0) MPI_RELEASE_DEBUG_SHARED_PT => Test case MPI_RELEASE_DEBUG_SHARED_PT was not run! => Does not affect push readiness! (-1.00 min)
1) intel-opt-openmp => passed: passed=180,notpassed=0 (2.68 min)
```
Unfortunately, I can't currently test the `intel-debug-openmp` build because it takes too much disk space and there is a quote of 50G in my home space on 'serrano'. I only have the disk space to test the `intel-opt-openmp` build.
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My change requires a change to the documentation.
- [x] I have updated the documentation accordingly.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2747Promote Trilinos-atdm-toss3-intel-opt-openmp-panzer to "ATDM" CDash Track/Gro...2018-05-15T14:24:46ZJames WillenbringPromote Trilinos-atdm-toss3-intel-opt-openmp-panzer to "ATDM" CDash Track/Group (TRIL-200)*Created by: bartlettroscoe*
This build has been 100% clean and passing all Panzer tests the last 5 days, including today.
*Created by: bartlettroscoe*
This build has been 100% clean and passing all Panzer tests the last 5 days, including today.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2729Move the mpiexec args before -np not after (#2699)2018-05-11T13:58:30ZJames WillenbringMove the mpiexec args before -np not after (#2699)*Created by: bartlettroscoe*
CC: @fryeguy52, @jmgate
The instructions on the 'serrano' support page say that these arguments should
go before the -np argument, not after the --n arugment. I am hoping this will fix
some of the fai...*Created by: bartlettroscoe*
CC: @fryeguy52, @jmgate
The instructions on the 'serrano' support page say that these arguments should
go before the -np argument, not after the --n arugment. I am hoping this will fix
some of the failures we are seeing as described in #2699.
Also, I changed the -np argument to --n to match exactly what the 'serrano'
support page says to do.
## How Has This Been Tested?
On serrano, I ran:
```
$ ./checkin-test-atdm.sh intel-opt-openmp --enable-packages=Rythmos,MueLu --configure --build
$ salloc -N1 --time=00:20:00 --account=fy150090 \
./checkin-test-atdm.sh intel-opt-openmp --enable-packages=Rythmos,MueLu --test
```
That returned:
```
PASSED (NOT READY TO PUSH): Trilinos: serrano-login5
Thu May 10 17:30:21 MDT 2018
Enabled Packages: Rythmos, MueLu
Build test results:
-------------------
0) MPI_RELEASE_DEBUG_SHARED_PT => Test case MPI_RELEASE_DEBUG_SHARED_PT was not run! => Does not affect push readiness! (-1.00 min)
1) intel-opt-openmp => passed: passed=125,notpassed=0 (1.06 min)
```
Now, all of the Rythmos tests were already passing for the `intel-opt-openmp` build. But the fact there were no failing MueLu tests is hopeful.
NOTE: I could not run the `intel-debug-openmp` build because it takes up too much disk space and bombs out my 50G disk quota before it completes the build. It would be nice to run that build because that is were we saw the most failures.
## Checklist
- [ ] All new and existing tests passed.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2671Use netlib BLAS and LAPACK instead of OpenBLAS 1.2.19 on white/ride (#2454)2018-05-03T04:54:00ZJames WillenbringUse netlib BLAS and LAPACK instead of OpenBLAS 1.2.19 on white/ride (#2454)*Created by: bartlettroscoe*
**CC:** @trilinos/belos , @trilinos/anasazi, @etphipp
## Description
This appears to fix almost all of the failing Belos and Anaszzi tests on 'white' (see #2454 2454)
## How Has This Been Tested?
...*Created by: bartlettroscoe*
**CC:** @trilinos/belos , @trilinos/anasazi, @etphipp
## Description
This appears to fix almost all of the failing Belos and Anaszzi tests on 'white' (see #2454 2454)
## How Has This Been Tested?
I tested this one 'white' using:
```
$ cd ~/Trilinos.base/BUILD/WHITE/CHECKIN/
$ bsub -x -I -q rhel7F -n 16 \
./checkin-test-atdm.sh all --enable-packages=Belos,Anasazi --local-do-all
```
This returned:
```
Build test results:
-------------------
0) MPI_RELEASE_DEBUG_SHARED_PT => Test case MPI_RELEASE_DEBUG_SHARED_PT was not run! => Does not affect push readiness! (-1.00 min)
1) gnu-debug-openmp => passed: passed=145,notpassed=0 (4.31 min)
2) gnu-opt-openmp => passed: passed=146,notpassed=0 (6.30 min)
3) cuda-debug => passed: passed=145,notpassed=0 (10.72 min)
4) cuda-opt => FAILED: passed=145,notpassed=1 => Not ready to push! (13.36 min)
```
The only failing test was the 'cuda-opt' test:
```
27 - Belos_pseudo_pcg_hb_0_MPI_4 (Failed)
```
That test was already failing so this is not a regression. We will fix that test next.
The detailed test results are shown below.
<details>
<summary>
<b>Detailed checkin-test-atdm.sh results:</b> (click to expand)
</summary>
```
FAILED (NOT READY TO PUSH): Trilinos: white24
Wed May 2 18:40:48 MDT 2018
Enabled Packages: Belos, Anasazi
Build test results:
-------------------
0) MPI_RELEASE_DEBUG_SHARED_PT => Test case MPI_RELEASE_DEBUG_SHARED_PT was not run! => Does not affect push readiness! (-1.00 min)
1) gnu-debug-openmp => passed: passed=145,notpassed=0 (4.31 min)
2) gnu-opt-openmp => passed: passed=146,notpassed=0 (6.30 min)
3) cuda-debug => passed: passed=145,notpassed=0 (10.72 min)
4) cuda-opt => FAILED: passed=145,notpassed=1 => Not ready to push! (13.36 min)
*** Commits for repo :
1) gnu-debug-openmp Results:
----------------------------
passed: Trilinos/gnu-debug-openmp: passed=145,notpassed=0
Wed May 2 18:10:00 MDT 2018
Enabled Packages: Belos, Anasazi
Hostname: white24
Source Dir: /home/rabartl/Trilinos.base/Trilinos/cmake/tribits/ci_support/../../..
Build Dir: /home/rabartl/Trilinos.base/BUILD/WHITE/CHECKIN/gnu-debug-openmp
CMake Cache Varibles: -GNinja -DTrilinos_TRIBITS_DIR:PATH=/home/rabartl/Trilinos.base/Trilinos/cmake/tribits -DTrilinos_ENABLE_TESTS:BOOL=ON -DTrilinos_TEST_CATEGORIES:STRING=BASIC -DTrilinos_ALLOW_NO_PACKAGES:BOOL=OFF -DDART_TESTING_TIMEOUT:STRING=600.0 -GNinja -DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake -DTrilinos_TRACE_ADD_TEST=ON -DTrilinos_ENABLE_Belos:BOOL=ON -DTrilinos_ENABLE_Anasazi:BOOL=ON -DTrilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=ON -DTrilinos_ENABLE_ALL_FORWARD_DEP_PACKAGES:BOOL=OFF
Make Options: -j 128
CTest Options: -j 16
Pull: Not Performed
Configure: Passed (0.76 min)
Build: Passed (2.75 min)
Test: Passed (0.81 min)
100% tests passed, 0 tests failed out of 145
Subproject Time Summary:
Anasazi = 329.01 sec*proc (74 tests)
Belos = 363.76 sec*proc (71 tests)
Total Test time (real) = 48.36 sec
Total time for gnu-debug-openmp = 4.31 min
2) gnu-opt-openmp Results:
--------------------------
passed: Trilinos/gnu-opt-openmp: passed=146,notpassed=0
Wed May 2 18:16:25 MDT 2018
Enabled Packages: Belos, Anasazi
Hostname: white24
Source Dir: /home/rabartl/Trilinos.base/Trilinos/cmake/tribits/ci_support/../../..
Build Dir: /home/rabartl/Trilinos.base/BUILD/WHITE/CHECKIN/gnu-opt-openmp
CMake Cache Varibles: -GNinja -DTrilinos_TRIBITS_DIR:PATH=/home/rabartl/Trilinos.base/Trilinos/cmake/tribits -DTrilinos_ENABLE_TESTS:BOOL=ON -DTrilinos_TEST_CATEGORIES:STRING=BASIC -DTrilinos_ALLOW_NO_PACKAGES:BOOL=OFF -DDART_TESTING_TIMEOUT:STRING=600.0 -GNinja -DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake -DTrilinos_TRACE_ADD_TEST=ON -DTrilinos_ENABLE_Belos:BOOL=ON -DTrilinos_ENABLE_Anasazi:BOOL=ON -DTrilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=ON -DTrilinos_ENABLE_ALL_FORWARD_DEP_PACKAGES:BOOL=OFF
Make Options: -j 128
CTest Options: -j 16
Pull: Not Performed
Configure: Passed (0.71 min)
Build: Passed (4.86 min)
Test: Passed (0.73 min)
100% tests passed, 0 tests failed out of 146
Subproject Time Summary:
Anasazi = 314.23 sec*proc (74 tests)
Belos = 316.64 sec*proc (72 tests)
Total Test time (real) = 43.52 sec
Total time for gnu-opt-openmp = 6.30 min
3) cuda-debug Results:
----------------------
passed: Trilinos/cuda-debug: passed=145,notpassed=0
Wed May 2 18:27:15 MDT 2018
Enabled Packages: Belos, Anasazi
Hostname: white24
Source Dir: /home/rabartl/Trilinos.base/Trilinos/cmake/tribits/ci_support/../../..
Build Dir: /home/rabartl/Trilinos.base/BUILD/WHITE/CHECKIN/cuda-debug
CMake Cache Varibles: -GNinja -DTrilinos_TRIBITS_DIR:PATH=/home/rabartl/Trilinos.base/Trilinos/cmake/tribits -DTrilinos_ENABLE_TESTS:BOOL=ON -DTrilinos_TEST_CATEGORIES:STRING=BASIC -DTrilinos_ALLOW_NO_PACKAGES:BOOL=OFF -DDART_TESTING_TIMEOUT:STRING=600.0 -GNinja -DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake -DTrilinos_TRACE_ADD_TEST=ON -DTrilinos_ENABLE_Belos:BOOL=ON -DTrilinos_ENABLE_Anasazi:BOOL=ON -DTrilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=ON -DTrilinos_ENABLE_ALL_FORWARD_DEP_PACKAGES:BOOL=OFF
Make Options: -j 128
CTest Options: -j 8
Pull: Not Performed
Configure: Passed (1.30 min)
Build: Passed (7.57 min)
Test: Passed (1.84 min)
100% tests passed, 0 tests failed out of 145
Subproject Time Summary:
Anasazi = 435.97 sec*proc (74 tests)
Belos = 400.05 sec*proc (71 tests)
Total Test time (real) = 110.43 sec
Total time for cuda-debug = 10.72 min
4) cuda-opt Results:
--------------------
FAILED: Trilinos/cuda-opt: passed=145,notpassed=1
Wed May 2 18:40:43 MDT 2018
Enabled Packages: Belos, Anasazi
Hostname: white24
Source Dir: /home/rabartl/Trilinos.base/Trilinos/cmake/tribits/ci_support/../../..
Build Dir: /home/rabartl/Trilinos.base/BUILD/WHITE/CHECKIN/cuda-opt
CMake Cache Varibles: -GNinja -DTrilinos_TRIBITS_DIR:PATH=/home/rabartl/Trilinos.base/Trilinos/cmake/tribits -DTrilinos_ENABLE_TESTS:BOOL=ON -DTrilinos_TEST_CATEGORIES:STRING=BASIC -DTrilinos_ALLOW_NO_PACKAGES:BOOL=OFF -DDART_TESTING_TIMEOUT:STRING=600.0 -GNinja -DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake -DTrilinos_TRACE_ADD_TEST=ON -DTrilinos_ENABLE_Belos:BOOL=ON -DTrilinos_ENABLE_Anasazi:BOOL=ON -DTrilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=ON -DTrilinos_ENABLE_ALL_FORWARD_DEP_PACKAGES:BOOL=OFF
Make Options: -j 128
CTest Options: -j 8
Pull: Not Performed
Configure: Passed (1.29 min)
Build: Passed (10.33 min)
Test: FAILED (1.74 min)
99% tests passed, 1 tests failed out of 146
Subproject Time Summary:
Anasazi = 421.83 sec*proc (74 tests)
Belos = 368.36 sec*proc (72 tests)
Total Test time (real) = 104.25 sec
The following tests FAILED:
27 - Belos_pseudo_pcg_hb_0_MPI_4 (Failed)
Errors while running CTest
Total time for cuda-opt = 13.36 min
```
</details>
## Checklist
- [ ] My commit messages mention the appropriate GitHub issue numbers.
- [ ] All new and existing tests passed.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2656Teko: Selective disable of single unit test in test Teko_testdriver_tpetra_MPI_12018-04-28T20:51:29ZJames WillenbringTeko: Selective disable of single unit test in test Teko_testdriver_tpetra_MPI_1*Created by: bartlettroscoe*
**CC:** @trilinos/teko, @eric-c-cyr, @fryeguy52
## Description
This PR defines a CMake var `Teko_DISABLE_LSCSTABALIZED_TPETRA_ALPAH_INV_D` and uses it to disable one unit test in the larger set of uni...*Created by: bartlettroscoe*
**CC:** @trilinos/teko, @eric-c-cyr, @fryeguy52
## Description
This PR defines a CMake var `Teko_DISABLE_LSCSTABALIZED_TPETRA_ALPAH_INV_D` and uses it to disable one unit test in the larger set of unit tests `Teko_testdriver_tpetra_MPI_1` and only for select RHEL6 ATDM Trilinos builds. This does not disable any test code for any platform where this test is currently passing. This addresses (at least for now) the failure in #2652.
This replaces the PR #2654.
As part of this PR, I also added commit 47be6fc to allow the checkin-test-atdm.sh script to test all of the supported builds for the RHEL6 ATDM Trilinos platform.
## How Has This Been Tested?
I verified that I could reproduce the failing tests on my CEE LAN RHEL6 machine `ceerws1113` and then verified that this PR branch fixes the tests by disabling just this one test.
Using a base version of 'develop', I tested this locally on ceerws1113 with:
```
$ ./checkin-test-atdm.sh all --enable-packages=Teko --local-do-all
```
this returned:
```
Enabled Packages: Teko
Build test results:
-------------------
0) MPI_RELEASE_DEBUG_SHARED_PT => Test case MPI_RELEASE_DEBUG_SHARED_PT was not run! => Does not affect push readiness! (-1.00 min)
1) gnu-debug-serial => FAILED: passed=18,notpassed=1 => Not ready to push! (1.52 min)
2) gnu-opt-serial => FAILED: passed=18,notpassed=1 => Not ready to push! (0.76 min)
3) gnu-debug-openmp => FAILED: passed=18,notpassed=1 => Not ready to push! (1.58 min)
4) gnu-opt-openmp => passed: passed=19,notpassed=0 (0.79 min)
5) intel-opt-openmp => FAILED: passed=18,notpassed=1 => Not ready to push! (1.18 min)
```
The failing tests where:
```
$ find -maxdepth 2 -name ctest.out -exec grep -H "[(]Failed[)]" {} \;
./gnu-debug-openmp/ctest.out: 4 - Teko_testdriver_tpetra_MPI_1 (Failed)
./gnu-opt-serial/ctest.out: 4 - Teko_testdriver_tpetra_MPI_1 (Failed)
./intel-opt-openmp/ctest.out: 4 - Teko_testdriver_tpetra_MPI_1 (Failed)
./gnu-debug-serial/ctest.out: 4 - Teko_testdriver_tpetra_MPI_1 (Failed)
```
Strange I did not reproduce the failure for the build `gnu-opt-openmp` on `ceerws1113`. I don't now why that is.
Using this updated branch in this PR, I tested this locally on ceerws113 with:
```
$ ./checkin-test-atdm.sh all --enable-packages=Teko --local-do-all
```
this returned:
```
Enabled Packages: Teko
Build test results:
-------------------
0) MPI_RELEASE_DEBUG_SHARED_PT => Test case MPI_RELEASE_DEBUG_SHARED_PT was not run! => Does not affect push readiness! (-1.00 min)
1) gnu-debug-serial => passed: passed=19,notpassed=0 (6.45 min)
2) gnu-opt-serial => passed: passed=19,notpassed=0 (0.43 min)
3) gnu-debug-openmp => passed: passed=19,notpassed=0 (7.31 min)
4) gnu-opt-openmp => passed: passed=19,notpassed=0 (6.37 min)
5) intel-opt-openmp => passed: passed=19,notpassed=0 (20.96 min)
```
The full output from the now passing test is shown below.
<details>
<summary>
<b>Full passing test Teko_testdriver_tpetra_MPI_1 output for build gnu-opt-serial:</b> (click to expand)
</summary>
```
Teuchos::GlobalMPISession::GlobalMPISession(): started processor with name ceerws1113 and rank 0!
Running test "SIMPLEPreconditionerFactory_tpetra"
"createPrec" ... PASSED
Teko: Begin debug MSG
SIMPLE Parameters:
inv type = ""
inv v type = "Ifpack2"
inv p type = "Ifpack2"
alpha = 1
use mass = 0
vel scaling = Lumped
SIMPLE Parameter list:
Explicit Velocity Inverse Type = Lumped
Inverse Pressure Type = Ifpack2
Inverse Velocity Type = Ifpack2
Teko: End debug MSG
Teko: Inverse "Ifpack2" is of type strat prec = 1, strat solv = 0, block prec = 0
"initializePrec(lumped)" ... PASSED
Teko: Begin debug MSG
SIMPLE Parameters:
inv type = ""
inv v type = "Ifpack2"
inv p type = "Ifpack2"
alpha = 1
use mass = 0
vel scaling = Diagonal
SIMPLE Parameter list:
Explicit Velocity Inverse Type = Diagonal
Inverse Pressure Type = Ifpack2
Inverse Velocity Type = Ifpack2
Teko: End debug MSG
Teko: Inverse "Ifpack2" is of type strat prec = 1, strat solv = 0, block prec = 0
"initializePrec(diag)" ... PASSED
Teko: Begin debug MSG
SIMPLE Parameters:
inv type = ""
inv v type = "Ifpack2"
inv p type = "Ifpack2"
alpha = 1
use mass = 0
vel scaling = AbsRowSum
SIMPLE Parameter list:
Explicit Velocity Inverse Type = AbsRowSum
Inverse Pressure Type = Ifpack2
Inverse Velocity Type = Ifpack2
Teko: End debug MSG
Teko: Inverse "Ifpack2" is of type strat prec = 1, strat solv = 0, block prec = 0
"initializePrec(absrowsum)" ... PASSED
"uninitializePrec" ... PASSED
"isCompatable" ... PASSED
"diagonal(diag)" ... PASSED
"result(diag)" ... PASSED
Test "SIMPLEPreconditionerFactory_tpetra" completed ... PASSED (8)
Running test "DiagonalPreconditionerFactory_tpetra"
"createPrec" ... PASSED
"initializePrec" ... PASSED
||Z-Y||/||Z|| = 0
"canApply" ... PASSED
Test "DiagonalPreconditionerFactory_tpetra" completed ... PASSED (3)
Running test "LU2x2PreconditionerFactory_tpetra"
"createPrec" ... PASSED
"initializePrec" ... PASSED
"uninitializePrec" ... PASSED
"isCompatable" ... PASSED
"identity" ... PASSED
"diagonal" ... PASSED
"result" ... PASSED
"alphabeta" ... PASSED
Test "LU2x2PreconditionerFactory_tpetra" completed ... PASSED (8)
Running test "LSCStablePreconditionerFactory_tpetra"
"createPrec" ... PASSED
Teko: LSCPrecFact::buildPO BuildStateTime = 0
Teko: LSCPrecFact::buildPO GetInvTime = 2.86102e-06
Teko: LSCPrecFact::buildPO TotalTime = 3.00407e-05
"initializePrec" ... PASSED
"uninitializePrec" ... PASSED
"isCompatable" ... PASSED
Teko: LSCPrecFact::buildPO BuildStateTime = 1.19209e-06
Teko: LSCPrecFact::buildPO GetInvTime = 9.53674e-07
Teko: LSCPrecFact::buildPO TotalTime = 2.00272e-05
"identity" ... PASSED
Teko: LSCPrecFact::buildPO BuildStateTime = 0
Teko: LSCPrecFact::buildPO GetInvTime = 1.90735e-06
Teko: LSCPrecFact::buildPO TotalTime = 4.00543e-05
"diagonal" ... PASSED
Teko: LSCPrecFact::buildPO BuildStateTime = 0
Teko: LSCPrecFact::buildPO GetInvTime = 9.53674e-07
Teko: LSCPrecFact::buildPO TotalTime = 2.5034e-05
"result" ... PASSED
Test "LSCStablePreconditionerFactory_tpetra" completed ... PASSED (7)
Running test "LSCStabilized_tpetra"
Teko: LSCPrecFact::buildPO BuildStateTime = 0
Teko: LSCPrecFact::buildPO GetInvTime = 9.53674e-07
Teko: LSCPrecFact::buildPO TotalTime = 4.1008e-05
"diagonal" ... PASSED
Teko: Inverse "Ifpack2" is of type strat prec = 1, strat solv = 0, block prec = 0
Teko: LSC::initializeState Build Scaling <mass> type "Diagonal"
Teko: Begin debug MSG
LSC Gamma Parameter = 0.237413
LSC Alpha Parameter = 0.667104
Teko: End debug MSG
Teko: LSC::buildState BuildOpsTime = 0.00371313
Teko: LSC::computeInverses Building inv(F)
Teko: LSC::computeInverses GetInvF = 8.70228e-05
Teko: LSC::computeInverses Building inv(BQBtmC)
Teko: LSC::computeInverses GetInvBQBt = 7.51019e-05
Teko: LSC::buildState BuildInvTime = 0.00018692
Teko: LSCPrecFact::buildPO BuildStateTime = 0.00390792
Teko: LSCPrecFact::buildPO GetInvTime = 1.90735e-06
Teko: LSCPrecFact::buildPO TotalTime = 0.00393581
"strategy" ... PASSED
Test "LSCStabilized_tpetra" completed ... PASSED (2)
Running test "Jacobi2x2PreconditionerFactory_tpetra"
"createPrec" ... PASSED
"initializePrec" ... PASSED
"uninitializePrec" ... PASSED
"isCompatable" ... PASSED
"identity" ... PASSED
"diagonal" ... PASSED
"result" ... PASSED
Teko: Begin debug MSG
Looked up "Block Jacobi"
Built Teuchos::RCP<Teko::PreconditionerFactory>{ptr=0x3cde558,node=0x3c9f0d0,strong_count=1,weak_count=0}
Teko: End debug MSG
Teko: JacobiPrecFact: Building default inverse "Ifpack2"
Teko: Inverse "Ifpack2" is of type strat prec = 1, strat solv = 0, block prec = 0
Teko: Begin debug MSG
Looked up "Block Jacobi"
Built Teuchos::RCP<Teko::PreconditionerFactory>{ptr=0x3cdcf08,node=0x3c9f0d0,strong_count=1,weak_count=0}
Teko: End debug MSG
Teko: JacobiPrecFact: Building default inverse "ML"
Teko: Inverse "ML" is of type strat prec = 1, strat solv = 0, block prec = 0
Teko: JacobiPrecFact: Building inverse 1 "Amesos"
Teko: Inverse "Amesos" is of type strat prec = 0, strat solv = 1, block prec = 0
Teko: JacobiPrecFact: Building inverse 3 "Ifpack"
Teko: Inverse "Ifpack" is of type strat prec = 1, strat solv = 0, block prec = 0
"initializeFromParameterList" ... PASSED
Test "Jacobi2x2PreconditionerFactory_tpetra" completed ... PASSED (8)
Running test "BlockJacobiPreconditionerFactory_tpetra"
"createPrec" ... PASSED
"initializePrec" ... PASSED
"uninitializePrec" ... PASSED
"isCompatible" ... PASSED
Test "BlockJacobiPreconditionerFactory_tpetra" completed ... PASSED (4)
Running test "BlockUpperTriInverseOp_tpetra"
"apply" ... PASSED
"alphabeta" ... PASSED
Test "BlockUpperTriInverseOp_tpetra" completed ... PASSED (2)
Running test "BlockLowerTriInverseOp_tpetra"
"apply" ... PASSED
"alphabeta" ... PASSED
Test "BlockLowerTriInverseOp_tpetra" completed ... PASSED (2)
Running test "tTpetraOperatorWrapper"
"functionality" ... PASSED
Test "tTpetraOperatorWrapper" completed ... PASSED (1)
Running test "InterlacedTpetra"
"buildSubMaps_num" ... PASSED
"buildSubMaps_vec" ... PASSED
"buildMaps" ... PASSED
"one2many" ... PASSED
"many2one" ... PASSED
Test "InterlacedTpetra" completed ... PASSED (5)
Running test "BlockingTpetra"
"buildMaps" ... PASSED
"one2many" ... PASSED
"many2one" ... PASSED
"buildSubBlock" ... PASSED
Test "BlockingTpetra" completed ... PASSED (4)
Running test "TpetraThyraConverter"
"blockThyraToTpetra" ... PASSED
"single_blockThyraToTpetra" ... PASSED
"blockTpetraToThyra" ... PASSED
"single_blockTpetraToThyra" ... PASSED
Test "TpetraThyraConverter" completed ... PASSED (4)
Running test "tGraphLaplacian_tpetra"
"single_array" ... PASSED
"multi_array" ... PASSED
Test "tGraphLaplacian_tpetra" completed ... PASSED (2)
Running test "tParallelInverse_tpetra"
Teko: Inverse "Belos" is of type strat prec = 0, strat solv = 1, block prec = 0
"inverse" ... PASSED
Test "tParallelInverse_tpetra" completed ... PASSED (1)
Running test "tExplicitOps_tpetra"
"mult_diagScaleMatProd" ... PASSED
"mult_diagScaling" ... PASSED
"add" ... PASSED
"mult_modScaleMatProd" ... PASSED
"add_mod" ... PASSED
Test "tExplicitOps_tpetra" completed ... PASSED (5)
Running test "LSCHIntegrationTest_tpetra"
Teko: Inverse "Ifpack2" is of type strat prec = 1, strat solv = 0, block prec = 0
Teko: LSC::initializeState Build Scaling <mass> type "Diagonal"
Teko: LSC::buildState BuildOpsTime = 0.000283957
Teko: LSC::computeInverses Building inv(F)
Teko: LSC::computeInverses GetInvF = 8.70228e-05
Teko: LSC::computeInverses Building inv(BQBtmC)
Teko: LSC::computeInverses GetInvBQBt = 8.79765e-05
Teko: LSC::computeInverses Building inv(BHBtmC)
Teko: LSC::computeInverses GetInvBHBt = 7.10487e-05
Teko: LSC::buildState BuildInvTime = 0.000277996
Teko: LSCPrecFact::buildPO BuildStateTime = 0.000571966
Teko: LSCPrecFact::buildPO GetInvTime = 1.90735e-06
Teko: LSCPrecFact::buildPO TotalTime = 0.000596046
"hScaling" ... PASSED
Test "LSCHIntegrationTest_tpetra" completed ... PASSED (1)
Running test "Lumping_tpetra"
"lumping" ... PASSED
"invLumping" ... PASSED
Test "Lumping_tpetra" completed ... PASSED (2)
Running test "AbsRowSum_tpetra"
"absRowSum" ... PASSED
"invAbsRowSum" ... PASSED
Test "AbsRowSum_tpetra" completed ... PASSED (2)
Running test "NeumannSeries_tpetra"
Teko: Inverse "Neumann" is of type strat prec = 1, strat solv = 0, block prec = 0
Teko: Inverse "Ifpack2" is of type strat prec = 1, strat solv = 0, block prec = 0
Teko: Inverse "Neumann" is of type strat prec = 1, strat solv = 0, block prec = 0
Teko: Inverse "Ifpack2" is of type strat prec = 1, strat solv = 0, block prec = 0
"test_simpleOp" ... PASSED
Teko: Inverse "Neumann" is of type strat prec = 1, strat solv = 0, block prec = 0
Teko: Inverse "Ifpack2" is of type strat prec = 1, strat solv = 0, block prec = 0
"test_scaledOp" ... PASSED
Test "NeumannSeries_tpetra" completed ... PASSED (2)
Running test "PCDStrategy_tpetra"
Teko: Inverse "Ifpack2" is of type strat prec = 1, strat solv = 0, block prec = 0
"PCDStrategy" ... PASSED
Test "PCDStrategy_tpetra" completed ... PASSED (1)
Running test "LSCIntegrationTest_tpetra"
Teko: LSC::initializeState Build Scaling <mass> type "Diagonal"
Teko: LSC::buildState BuildOpsTime = 0.00213313
Teko: LSC::computeInverses Building inv(F)
Teko: LSC::computeInverses GetInvF = 0.0080862
Teko: LSC::computeInverses Building inv(BQBtmC)
Teko: LSC::computeInverses GetInvBQBt = 0.00157905
Teko: LSC::buildState BuildInvTime = 0.00968599
Teko: LSCPrecFact::buildPO BuildStateTime = 0.0118351
Teko: LSCPrecFact::buildPO GetInvTime = 9.53674e-07
Teko: LSCPrecFact::buildPO TotalTime = 0.0118802
"withmassStable" ... PASSED
Teko: LSC::initializeState Build Scaling <F> type "Diagonal"
Teko: LSC::buildState BuildOpsTime = 0.003824
Teko: LSC::computeInverses Building inv(F)
Teko: LSC::computeInverses GetInvF = 0.00873494
Teko: LSC::computeInverses Building inv(BQBtmC)
Teko: LSC::computeInverses GetInvBQBt = 0.00154901
Teko: LSC::buildState BuildInvTime = 0.0103078
Teko: LSCPrecFact::buildPO BuildStateTime = 0.014163
Teko: LSCPrecFact::buildPO GetInvTime = 1.90735e-06
Teko: LSCPrecFact::buildPO TotalTime = 0.0141981
"nomassStable" ... PASSED
Teko: Begin debug MSG
Looked up "NS LSC"
Built Teuchos::RCP<Teko::PreconditionerFactory>{ptr=0x3e70d38,node=0x3dc1fb0,strong_count=1,weak_count=0}
Teko: End debug MSG
Teko: Building LSC strategy "Basic Inverse"
Teko: Begin debug MSG
LSC Inverse Strategy Parameters:
inv type = "Amesos"
inv v type = "Ifpack"
inv p type = "Ifpack"
bndry rows = 1
use ldu = 1
use mass = 0
use w-scaling = 0
assume stable = 0
scale type = Diagonal
LSC Inverse Strategy Parameter list:
Inverse Type = Amesos
Inverse Velocity Type = Ifpack
Inverse Pressure Type = Ifpack
Ignore Boundary Rows = 1
Use LDU = 1
Teko: End debug MSG
Teko: Inverse "Ifpack" is of type strat prec = 1, strat solv = 0, block prec = 0
Teko: Begin debug MSG
Looked up "NS LSC"
Built Teuchos::RCP<Teko::PreconditionerFactory>{ptr=0x3e458d8,node=0x3ed1290,strong_count=1,weak_count=0}
Teko: End debug MSG
Teko: Building LSC strategy "Basic Inverse"
Teko: Begin debug MSG
LSC Inverse Strategy Parameters:
inv type = "Amesos"
inv v type = "Ifpack"
inv p type = "Ifpack"
bndry rows = 1
use ldu = 1
use mass = 0
use w-scaling = 0
assume stable = 0
scale type = Diagonal
LSC Inverse Strategy Parameter list:
Inverse Type = Amesos
Inverse Velocity Type = Ifpack
Inverse Pressure Type = Ifpack
Ignore Boundary Rows = 1
Use LDU = 1
Teko: End debug MSG
Teko: Inverse "Ifpack" is of type strat prec = 1, strat solv = 0, block prec = 0
Teko: Begin debug MSG
Looked up "NS LSC"
Built Teuchos::RCP<Teko::PreconditionerFactory>{ptr=0x3e70d38,node=0x3dc1fb0,strong_count=1,weak_count=0}
Teko: End debug MSG
Teko: Building LSC strategy "The Cat"
LSC Construction failed: Strategy "The Cat" could not be constructed
Teko: Begin debug MSG
Looked up "NS LSC"
Built Teuchos::RCP<Teko::PreconditionerFactory>{ptr=0x3e70d38,node=0x3dc1fb0,strong_count=1,weak_count=0}
Teko: End debug MSG
LSC Construction failed: Strategy "The Cat" requires a "Strategy Settings" sublist
"plConstruction" ... PASSED
Test "LSCIntegrationTest_tpetra" completed ... PASSED (3)
Running test "tStridedTpetraOperator"
"numvars_constr" ... PASSED
"vector_constr" ... PASSED
"reorder(flat reorder)" ... PASSED
"reorder(composite reorder = 1)" ... PASSED
"reorder(composite reorder = 2)" ... PASSED
Test "tStridedTpetraOperator" completed ... PASSED (5)
Running test "tBlockedTpetraOperator"
"vector_constr" ... PASSED
"reorder(flat reorder)" ... PASSED
"reorder(composite reorder = 1)" ... PASSED
"reorder(composite reorder = 2)" ... PASSED
Test "tBlockedTpetraOperator" completed ... PASSED (4)
Tests Passed: 86, Tests Failed: 0
(Incidently, you want no failures)
```
</details>
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [x] All new and existing tests passed.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2621Revert "Merge pull request #2501 from bartlettroscoe/2473-disable-random-fail...2018-04-24T17:25:08ZJames WillenbringRevert "Merge pull request #2501 from bartlettroscoe/2473-disable-random-failing-anasazi-tests" (#2473)*Created by: bartlettroscoe*
**CC:** @fryeguy52, @trilinos/anasazi
## Description
This reverts commit 2e9da0c931e8c11c60d194e8a64d13e6e8697213, reversing
changes made to c828f5ad7f9ccef1d148839aaf65d6236ca172d5.
The merge bra...*Created by: bartlettroscoe*
**CC:** @fryeguy52, @trilinos/anasazi
## Description
This reverts commit 2e9da0c931e8c11c60d194e8a64d13e6e8697213, reversing
changes made to c828f5ad7f9ccef1d148839aaf65d6236ca172d5.
The merge branch in PR #2517 should allow these tests to pass now.
This should resolve #2473. We will just need to to observe these tests passing.
Note that this just impacts the tests that run in the ATDM Trilinos builds and does not impact any actual code in Trilinos at all or any of the auto PR builds.
## How this was tested
I tested this on white with:
```
$ bsub -x -I -q rhel7F -n 16 \
./checkin-test-atdm.sh cuda-debug gnu-debug-openmp \
--enable-all-packages=off --no-enable-fwd-packages \
--enable-packages=Anasazi --local-do-all
...
PASSED (NOT READY TO PUSH): Trilinos: white24
Mon Apr 23 11:55:40 MDT 2018
Enabled Packages: Anasazi
Build test results:
-------------------
0) MPI_RELEASE_DEBUG_SHARED_PT => Test case MPI_RELEASE_DEBUG_SHARED_PT was not run! => Does not affect push readiness! (-1.00 min)
1) cuda-debug => passed: passed=74,notpassed=0 (14.77 min)
2) gnu-debug-openmp => passed: passed=74,notpassed=0 (3.84 min)
```
## Checklist
- [x] My commit messages mention the appropriate GitHub issue numbers.
- [x] My code follows the code style of the affected package(s).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] No new compiler warnings were introduced.
- [ ] These changes break backwards compatibility.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2501Disable 3 Anasazi tests that randomly fail in debug builds on white/ride (#2473)2018-04-04T01:34:24ZJames WillenbringDisable 3 Anasazi tests that randomly fail in debug builds on white/ride (#2473)*Created by: bartlettroscoe*
These tests randomly fail with massive diffs. Very strange behavior. See #2473 for history and more details.
*Created by: bartlettroscoe*
These tests randomly fail with massive diffs. Very strange behavior. See #2473 for history and more details.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/24882487 fix timemonitor unittests mpi 32018-04-02T12:30:18ZJames Willenbring2487 fix timemonitor unittests mpi 3*Created by: bartlettroscoe*
CC: @trilinos/teuchos
This addresses #2487 and actually fixes the test on a bunch of platforms. For more details, see https://github.com/trilinos/Trilinos/issues/2487#issuecomment-377648679 and the comm...*Created by: bartlettroscoe*
CC: @trilinos/teuchos
This addresses #2487 and actually fixes the test on a bunch of platforms. For more details, see https://github.com/trilinos/Trilinos/issues/2487#issuecomment-377648679 and the commit message logs. It should be pretty clear from that.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/2482Loose error tol from 5e-14 to 5.5e-14 for gnu-opt-serial on hansen/shiller (#...2018-03-30T15:44:14ZJames WillenbringLoose error tol from 5e-14 to 5.5e-14 for gnu-opt-serial on hansen/shiller (#2475)*Created by: bartlettroscoe*
CC: @trilinos/teko
This small increase in the error tolerance allows the
tDiagonallyScaledPreconditioner_application_test_row_tpetra_UnitTest unit test
to pass on the ATDM build Trilinos-atdm-hansen-sh...*Created by: bartlettroscoe*
CC: @trilinos/teko
This small increase in the error tolerance allows the
tDiagonallyScaledPreconditioner_application_test_row_tpetra_UnitTest unit test
to pass on the ATDM build Trilinos-atdm-hansen-shiller-gnu-opt-serial. See #2475.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/24472410 disable lapack tests ride debug2018-03-23T18:20:55ZJames Willenbring2410 disable lapack tests ride debug*Created by: bartlettroscoe*
**CC:** @trilinos/teuchos
This addresses #2410. See the commit log.
*Created by: bartlettroscoe*
**CC:** @trilinos/teuchos
This addresses #2410. See the commit log.
Initial cleanup of new ATDM builds of Trilinoshttps://gitlab.osti.gov/jmwille/Trilinos/-/merge_requests/24092407 fix safe as check power82018-03-19T14:24:17ZJames Willenbring2407 fix safe as check power8*Created by: bartlettroscoe*
**CC:** @trilinos/teuchos, @mhoemmen
## Description
This PR branch improves the outputting of some of the Teuchos type conversion code unit tests and it fixes a problem with a safeAs() test on power8 ...*Created by: bartlettroscoe*
**CC:** @trilinos/teuchos, @mhoemmen
## Description
This PR branch improves the outputting of some of the Teuchos type conversion code unit tests and it fixes a problem with a safeAs() test on power8 systems. This addresses issue #2407.
Now, building and running with:
```
./TeuchosCore_TypeConversions_UnitTest.exe --test=stringToReal --details=ALL
```
passes as shown below on two systems.
With this change, on my Linux machine crf450 the unit test output shows:
```
1. asSafe_stringToReal_UnitTest ...
minLD = -1.19e+4932
minusOneLD = -1
maxLD = 1.19e+4932
...
sizeof_long_double = 16
sizeof_double = 8
max_exponent10_long_double = 4932
max_exponent10_double = 308
Testing converting from 'long double' to 'double' that does not fit ...
Test that code {valD = asSafe<double>(valToString(minLD));} throws std::range_error: passed
Exception message for expected exception:
/ascldap/users/rabartl/Trilinos.base/Trilinos/packages/teuchos/core/src/Teuchos_as.hpp:558:
Throw number = 3
Throw test that evaluated to true: errno == ERANGE && (val != 0)
Teuchos::ValueTypeConversionTraits<double, std::string>::convert: The value in the given string "-1.189731495357231765021263853e+4932" overflows double.
valD = -1
Test that code {valD = asSafe<double>(valToString(maxLD));} throws std::range_error: passed
Exception message for expected exception:
/ascldap/users/rabartl/Trilinos.base/Trilinos/packages/teuchos/core/src/Teuchos_as.hpp:558:
Throw number = 4
Throw test that evaluated to true: errno == ERANGE && (val != 0)
Teuchos::ValueTypeConversionTraits<double, std::string>::convert: The value in the given string "1.189731495357231765021263853e+4932" overflows double.
valD = -1
Testing string -> long double conversions ...
...
[Passed] (0.000535 sec)
Total Time: 0.000829 sec
Summary: total = 116, run = 1, passed = 1, failed = 0
End Result: TEST PASSED
```
So it runs the unit tests `Testing converting from 'long double' to 'double' that does not fit` gets run since both the sizeof() and max_exponent10 values for long double are larger than for double. So these important tests run.
But when I run this unit test now on the power8 machine `ride` with the the `gnu-debug-openmp` build as shown above, it shows:
```
1. asSafe_stringToReal_UnitTest ...
minLD = -1.8e+308
minusOneLD = -1
maxLD = 1.8e+308
...
sizeof_long_double = 16
sizeof_double = 8
max_exponent10_long_double = 308
max_exponent10_double = 308
Testing string -> long double conversions ...
...
[Passed] (0.000418 sec)
Total Time: 0.000783 sec
Summary: total = 116, run = 1, passed = 1, failed = 0
End Result: TEST PASSED
```
See, that shows that on this machine `max_exponent10_long_double` = `max_exponent10_double` = `308` and the checks printed in the section `Testing converting from 'long double' to 'double' that does not fit` are skipped and instead it goes straight to `Testing string -> long double conversions`.
I think this is the right thing to do to fix these tests and it informs something about this system.
Initial cleanup of new ATDM builds of Trilinos