Skip to content

Tpetra: Refactor CrsMatrix pack/unpack procedures to use PackTraits

James Willenbring requested to merge tjfulle:topics/threaded-pack-unpack into develop

Created by: tjfulle

@trilinos/tpetra, @mhoemmen

Comments

This commit is a combination of several commits that address a several issues: #797, #798 (closed), #800 (closed), #802 (closed)

A summary of changes are as follows:

  • Refactor CrsMatrix pack/unpack procedures to use PackTraits (for both static and dynamic profile matrices)
  • Refactor packCrsMatrix to pack (optional) PIDs
  • Remove exists packAndPrepareWithOwningPIDs and instead use the aforementioned packCrsMatrix procedure.
  • Modify PackTraits run on threads by removing calls to TEUCHOS_TEST_FOR_EXCEPTION and decorating device code with KOKKOS_INLINE_FUNCTION
  • Ditto for Stokhos' specialization of PackTraits

Build/Test Cases Summary Enabled Packages: TpetraCore Disabled Packages: PyTrilinos,Claps,TriKota Enabled all Forward Packages 0) MPI_RELEASE_DEBUG_SHARED_PT => passed: passed=1483,notpassed=0 (79.62 min)

Merge request reports