Skip to content

Teuchos KokkosCompat: missing include, Kokkos::is_initialized

James Willenbring requested to merge ibaned:missing-cpp-includes into develop

Created by: ibaned

@trilinos/teuchos

Description

First, include <functional> in a file that uses std::ref. This error was being hidden by excessive includes in Teuchos_ConfigDefs, which @mhoemmen has been cleaning up. The need was revealed ultimately by this Albany dashboard:

http://my.cdash.org/viewBuildError.php?buildid=1324432

In addition, I noticed a function working around the lack of Kokkos::is_initialized, and changed it to call that function now that it exists.

Motivation and Context

This change is required due to cleanups in the core of Teuchos to avoid compilation errors and also required for correct Kokkos initialization behavior (see kokkos/kokkos#1184).

How Has This Been Tested?

None yet, will rely on new PR testing system or checkin script.

Merge request reports