Skip to content

Sacado: Modifications for deep_copy

James Willenbring requested to merge ndellingwood:sacado-deep_copy into develop

Created by: ndellingwood

Changes to the deep_copy implementation in Kokkos are incompatible with the existing implementation of deep_copy in Sacado. This is due in part to custom layouts in Sacado that are not recognized by Kokkos. The changes in this commit handle the layout issue and revise the assign method of Sacado's ViewMapping to properly convert View's of (nested) Fad types into Kokkos Views (with additional dynamic ranks) to use the new deep_copy implementation in Kokkos.

@trilinos/sacado

Motivation and Context

This PR is needed due to changes in Kokkos deep_copy (currently on Kokkos' develop branch) that are incompatible with the existing implementation in Sacado

Related Issues

  • Closes
  • Blocks
  • Is blocked by
  • Follows
  • Precedes
  • Related to Kokkos integration testing for the next Kokkos snapshot into Trilinos
  • Part of
  • Composed of

How Has This Been Tested?

Locally with Kokkos' develop branch and within the kokkos-develop branch of Trilinos with gcc/5.4 on Serial and OpenMP backends.

Screenshots

Additional Information

This PR is labeled WIP for review purposes - may be more appropriate to merge into the kokkos-develop branch pending review and further testing. Will undergo more extensive testing as part of the Trilinos integration test process with Kokkos.

Merge request reports