Skip to content

Teuchos: Fix #2273

James Willenbring requested to merge Fix-2273 into develop

Created by: mhoemmen

Make Teuchos timers use Kokkos profiling hooks by default.

@trilinos/teuchos @nmhamster

Description

Teuchos already had a CMake option, Teuchos_KOKKOS_PROFILING, for making Teuchos timers use Kokkos profiling hooks. However, that option was OFF by default. This commit makes Teuchos use the KOKKOS_ENABLE_PROFILING CMake option for the default value of Teuchos_KOKKOS_PROFILING. Since Kokkos enables profiling by default, this should make Teuchos use Kokkos profiling hooks by default.

I have NOT finished testing this locally yet.

Motivation and Context

This change will make Kokkos profiling hooks record useful information for large parts of Trilinos. In particular, MueLu makes heavy use of Teuchos timers.

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Merge request reports