Skip to content

ROL: correct warnings in examples and tests

James Willenbring requested to merge prwolfe:issue2284 into develop

Created by: prwolfe

The tests were mostly signed/unsigned comparisons which I cast to match. I did consider changing the types, but other comparisons in the same code would have required a cast in the opposite direction so that was pointless. The example code was complaining about unused variables. I did lleave those in place but commented out so that the example is still there but the compiler does not complain. If someone wanted to instead use those in some way that would be good.

closes issue #2284 (closed)

@trilinos/

Description

Motivation and Context

Related Issues

  • Closes
  • Blocks
  • Is blocked by
  • Follows
  • Precedes
  • Related to
  • Part of
  • Composed of

How Has This Been Tested?

Screenshots

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Additional Information

Merge request reports