From 9f8a83c7f11a661e1afff8b1e745f58dcebca9c5 Mon Sep 17 00:00:00 2001 From: "Roscoe A. Bartlett" Date: Fri, 23 Mar 2018 08:54:59 -0600 Subject: [PATCH 1/2] Disable seg faulting TeuchosNumerics_LAPACK_test_MPI_1 in white/ride debug builds (#2410) This passes in the corresponding RELEASE builds so it is okay to disable this test in these DEBUG builds as we are not really loosing any real testing. And note that almost all of the Belos and Anasazi and other tests that use this LAPACK interface pass in these DEBUG builds so disabling this one test is not too serious. But if someone wants to try to debug it and then turn it back on, more power to them. Note that this is likey related to the mix-lanauage compiler defect reported in #1208. That seems to be a strange compiler defect. --- cmake/std/atdm/ride/tweaks/CUDA-DEBUG-CUDA.cmake | 5 +++++ cmake/std/atdm/ride/tweaks/GNU-DEBUG-OPENMP.cmake | 6 ++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/cmake/std/atdm/ride/tweaks/CUDA-DEBUG-CUDA.cmake b/cmake/std/atdm/ride/tweaks/CUDA-DEBUG-CUDA.cmake index 04fe70e8f9..9f6d062dae 100644 --- a/cmake/std/atdm/ride/tweaks/CUDA-DEBUG-CUDA.cmake +++ b/cmake/std/atdm/ride/tweaks/CUDA-DEBUG-CUDA.cmake @@ -1 +1,6 @@ +# #2410: This passes in the CUDA-RELESE-CUDA build so it is okay to disable in +# this DEBUG build. This is likey related to the mix-lanauage compiler defect +# reported in #1208. +ATDM_SET_ENABLE(TeuchosNumerics_LAPACK_test_MPI_1_DISABLE ON) + INCLUDE("${CMAKE_CURRENT_LIST_DIR}/CUDA_COMMON_TWEAKS.cmake") diff --git a/cmake/std/atdm/ride/tweaks/GNU-DEBUG-OPENMP.cmake b/cmake/std/atdm/ride/tweaks/GNU-DEBUG-OPENMP.cmake index fd39fda640..4e4fb8e292 100644 --- a/cmake/std/atdm/ride/tweaks/GNU-DEBUG-OPENMP.cmake +++ b/cmake/std/atdm/ride/tweaks/GNU-DEBUG-OPENMP.cmake @@ -1,2 +1,4 @@ -#ATDM_SET_ENABLE(KokkosCore_UnitTest_OpenMP_MPI_1_DISABLE ON) -#ATDM_SET_ENABLE(KokkosCore_UnitTest_Serial_MPI_1_DISABLE ON) +# #2410: This passes in the GNU-RELESE-OPENMP build so it is okay to disable +# in this DEBUG build. This is likey related to the mix-lanauage compiler +# defect reported in #1208. +ATDM_SET_ENABLE(TeuchosNumerics_LAPACK_test_MPI_1_DISABLE ON) -- GitLab From a26f4a9b0fff2d00474465d90870a7af7398c167 Mon Sep 17 00:00:00 2001 From: "Roscoe A. Bartlett" Date: Fri, 23 Mar 2018 09:08:10 -0600 Subject: [PATCH 2/2] checkin-test-atdm.sh: Set -DTrilinos_TRACE_ADD_TEST=ON (TRIL-171) So we can see what tests are added or not and why. This was useful for checking on disabling some tests for #2410. --- cmake/std/atdm/utils/checkin-test-atdm-single.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmake/std/atdm/utils/checkin-test-atdm-single.sh b/cmake/std/atdm/utils/checkin-test-atdm-single.sh index b709490801..96fd426961 100755 --- a/cmake/std/atdm/utils/checkin-test-atdm-single.sh +++ b/cmake/std/atdm/utils/checkin-test-atdm-single.sh @@ -15,7 +15,8 @@ else CHECKIN_TEST_USE_NINJA_ARG= fi -echo "-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake" \ +echo "-DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake +-DTrilinos_TRACE_ADD_TEST=ON" \ >> $ATDM_JOB_NAME_KEYS.config echo -- GitLab