Skip to content

Tpetra: Fix #581

James Willenbring requested to merge Fix-581 into develop

Created by: mhoemmen

@trilinos/tpetra @trilinos/ifpack2


  1. Remove all use of the deprecated Tpetra::CrsMatrix::localSolve method from Ifpack2.
  2. Remove Tpetra::CrsMatrix::localSolve and Tpetra::CrsMatrixSolveOp.

Motivation and Context

  • Save build time by exposing less code in Tpetra_CrsMatrix_decl.hpp
  • Sparse triangular solve is a solver, not a kernel, so it does not belong in Tpetra (see Ifpack2::LocalSparseTriangularSolver)
  • Tpetra::CrsMatrixSolveOp was untested, and the header file didn't even compile when included

Related Issues

How Has This Been Tested?



  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • I have read the code contribution guidelines for this project.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Merge request reports