Skip to content

Mark minitensor storage functions as KOKKOS_INLINE_FUNCTIONS [had callers that were KOKKOS_INLINE_FUNCTIONS]

James Willenbring requested to merge MalachiTimothyPhillips:myChanges into develop

Created by: MalachiTimothyPhillips

@trilinos/minitensor

Description

Marked several functions as KOKKOS_INLINE_FUNCTIONS who had callers that were also KOKKOS_INLINE_FUNCTIONS. Previously, this caused a lot of problems when building in debug with RDC=on.

Motivation and Context

Compile time errors using minitensor::Tensor<double,3>, for example. These errors could only be fixed by marking these methods as KOKKOS_INLINE_FUNCTIONS.

Checklist

  • [ x] My commit messages mention the appropriate GitHub issue numbers.
  • [ x] My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.
  • [ x] No new compiler warnings were introduced.
  • These changes break backwards compatibility.

@mhoemmen @ibaned https://github.com/trilinos/Trilinos/issues/1264

Merge request reports