Skip to content

EpetraExt: Recursively check for existing HDF5 groups

James Willenbring requested to merge Sbte:develop into develop

Created by: Sbte

@trilinos/EpetraExt

Description

Nested groups are not handled correctly in EpetraExt_HDF5. These groups are denoted by /Group A/Group B/Group C/data. Writing and reading from these groups actually works fine, just the IsContained method, which only does some safety checks, does not handle them correctly.

I also added a missing const while I was working on the code anyway.

Motivation and Context

Reason why one might need this is when writing a data structure which contains an array of Epetra_Vectors. Doing this without nested groups would look like a mess since all data is sorted alphabetically.

How Has This Been Tested?

A new unit test file was added and tests were added to confirm the behaviour of the changed functionality.

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Merge request reports