Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Trilinos
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 936
    • Issues 936
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • James Willenbring
  • Trilinos
  • Merge requests
  • !4400

Open
Created Feb 14, 2019 by James Willenbring@jmwilleMaintainer2 of 9 tasks completed2/9 tasks
  • Report abuse
Report abuse

Xpetra: fixed dependency on Tpetra instantations

  • Overview 42
  • Commits 1
  • Changes 4

Created by: brian-kelley

Satisfy dependency of Xpetra EpetraMap on Tpetra::Details::FixedHashTable with int/long and int/longlong as LO/GO. These dependencies always exist as long as Tpetra is enabled, but regardless of whether these LO/GO combinations are enabled in Tpetra ETI.

@trilinos/xpetra

Description

Xpetra_EpetraMap.cpp now includes the def of FixedHashTable so that these instantiations can be made, even if int/long and/or int/longlong haven't been enabled in ETI. The include is only done if Tpetra and Xpetra kokkos refactor are both enabled, because Xpetra::EpetraMap only uses FixedHashTable in this case.

Motivation and Context

This fixes an "undefined symbol" error during the final link of Albany (or any other app executable). Without this code change, the only workaround is to enable both TPETRA_INST_INT_LONG and TPETRA_INST_INT_LONG_LONG in configuration (huge code size increase). Only the instantiation of FixedHashTable is needed, not all of Tpetra.

  • Related to #4038

How Has This Been Tested?

Tested by successfully building Trilinos/Albany without TPETRA_INST_INT_LONG.

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: brian-kelley:XpetraInstantFix