Created by: ZUUL42
This sets up Werror flags for the remaining packages and sets Werror for those clear of any warnings as errors. This includes @trilinos/amesos2, @trilinos/galeri, @trilinos/globipack, @trilinos/gtest, @trilinos/intrepid, @trilinos/minitensor, @trilinos/rtop, @trilinos/shylu (including DD & Node), @trilinos/teko, @trilinos/threadpool, @trilinos/thyra, @trilinos/trilinoscouplings, @trilinos/trilinosss, & @trilinos/xpetra.
There are also very minor code changes to fix a few small Werrors that popped up. Then the Werror flag was set for those packages. That includes @trilinos/optipack, @trilinos/rythmos, @trilinos/stk, & @trilinos/stratimikos.
Motivation and Context
This is all work toward #3178 turning Werror on for all packages.
My commit messages mention the appropriate GitHub issue numbers.
My code follows the code style of the affected package(s).
My change requires a change to the documentation.
I have read the code contribution guidelines for this project.
All new and existing tests passed.
No new compiler warnings were introduced.
These changes break backwards compatibility.