Skip to content

Trilinos: Deprecate four packages OptiPack, GlobiPack, Trios, Claps

James Willenbring requested to merge deprecateFourPackages into develop

Created by: kddevin

@trilinos/optipack @trilinos/globipack @trilinos/trios @trilinos/claps @trilinos/framework

Description

The following four packages are scheduled for deprecation and removal from the Trilinos repository:

  • OptiPack
  • GlobiPack
  • Trios
  • Claps

The packages will be deprecated in mid-April 2019, and will be removed from the Trilinos develop and master branches in mid-May 2019. This PR adds deprecation warnings.

Motivation and Context

Reducing cost of Trilinos maintenance by removing unused / obsolete packages.

How Has This Been Tested?

For Claps, OptiPack, GlobiPack: cmake
-D Trilinos_ENABLE_EXPLICIT_INSTANTIATION:BOOL=ON
-D CMAKE_BUILD_TYPE:STRING=DEBUG
-D CMAKE_VERBOSE_MAKEFILE:BOOL=OFF

-D MPI_BASE_DIR:PATH=/Users/InstalledSoftware/openmpi-1.8.3
-D TPL_ENABLE_MPI:BOOL=ON

-D Trilinos_ENABLE_Fortran:BOOL=OFF
-D Trilinos_ENABLE_ALL_PACKAGES:BOOL=OFF
-D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=ON
-D Trilinos_ENABLE_EXAMPLES:BOOL=OFF
-D Trilinos_ENABLE_TESTS:BOOL=OFF
-D Trilinos_VERBOSE_CONFIGURE:BOOL=OFF

-D Trilinos_ENABLE_GlobiPack:BOOL=ON

-D Trilinos_ENABLE_OptiPack:BOOL=ON
-D Trilinos_ENABLE_Piro:BOOL=ON
-D Piro_ENABLE_OptiPack:BOOL=ON
-D Piro_ENABLE_ROL:BOOL=OFF
-D Trilinos_ENABLE_ROL:BOOL=OFF
-D Trilinos_ENABLE_MOOCHO:BOOL=OFF
-D Trilinos_ENABLE_Tempus:BOOL=OFF
-D Trilinos_ENABLE_Stokhos:BOOL=OFF
-D Trilinos_ENABLE_Rythmos:BOOL=OFF
-D Trilinos_ENABLE_MueLu:BOOL=OFF
-D Trilinos_ENABLE_Ifpack2:BOOL=OFF
-D Trilinos_ENABLE_NOX:BOOL=OFF
-D NOX_ENABLE_Epetra:BOOL=ON
-D Trilinos_ENABLE_Tpetra:BOOL=ON
-D Tpetra_INST_INT_INT:BOOL=ON
-D Tpetra_INST_INT_LONG_LONG:BOOL=OFF
-D Trilinos_ENABLE_TriKota:BOOL=OFF
-D Piro_ENABLE_TESTS=ON
-D Piro_ENABLE_EXAMPLES=ON
-D OptiPack_HIDE_DEPRECATED_CODE=ON

-D Trilinos_ENABLE_Claps:BOOL=ON
-D Claps_ENABLE_EXAMPLES:BOOL=ON
-D Claps_ENABLE_TESTS:BOOL=ON
-D TPL_ENABLE_METIS:BOOL=ON
-D METIS_LIBRARY_DIRS:FILEPATH="/Users/InstalledSoftware/ParMETIS_4.0.3/32bit"
-D METIS_INCLUDE_DIRS:FILEPATH="/Users/InstalledSoftware/ParMETIS_4.0.3/32bit"

-D Teuchos_ENABLE_STACKTRACE=OFF
..

Trios builds did not succeed on my platform, but the deprecation warnings were correctly emitted. The build errors did not appear to be related to these changes.

cmake
-D Trilinos_ENABLE_EXPLICIT_INSTANTIATION:BOOL=ON
-D CMAKE_BUILD_TYPE:STRING=DEBUG
-D CMAKE_VERBOSE_MAKEFILE:BOOL=OFF

-D MPI_BASE_DIR:PATH=/Users/InstalledSoftware/openmpi-1.8.3
-D TPL_ENABLE_MPI:BOOL=ON

-D Trilinos_ENABLE_Fortran:BOOL=OFF
-D Trilinos_ENABLE_ALL_PACKAGES:BOOL=OFF
-D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=ON
-D Trilinos_ENABLE_EXAMPLES:BOOL=OFF
-D Trilinos_ENABLE_TESTS:BOOL=OFF
-D Trilinos_VERBOSE_CONFIGURE:BOOL=OFF

-D Trilinos_ENABLE_GlobiPack:BOOL=ON
-D Trilinos_ENABLE_OptiPack:BOOL=ON

-D Trilinos_ENABLE_Trios:BOOL=ON
-D Trilinos_ENABLE_Triossupport=ON
-D Trilinos_ENABLE_Triostests=ON
-D Trilinos_ENABLE_Triosprograms=ON
-D Trilinos_ENABLE_Triosexamples=ON
-D Trilinos_ENABLE_Triosnnti=ON
-D Trilinos_ENABLE_Triosnssi=ON

-D Teuchos_ENABLE_STACKTRACE=OFF
.

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • [x ] My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.
  • No new compiler warnings were introduced. (DEPRECATION WARNINGS EMITTED)
  • [ x] These changes break backwards compatibility. (THAT'S THE POINT)

Merge request reports