Skip to content

Tpetra deprecate node args get node

James Willenbring requested to merge tpetra_deprecateNodeArgsGetNode into develop

Created by: kddevin

@trilinos/muelu : please look at the two test failures called out in detail below; they fail only with Tpetra_ENABLE_DEPRECATED_CODE=OFF.

@trilinos/tpetra @trilinos/stokhos @trilinos/xpetra @trilinos/ifpack2 @trilinos/belos @trilinos/thyra @trilinos/trilinoscouplings

Description

Deprecating getNode() in Tpetra classes Deprecations propagate to Xpetra and Ifpack2, and use cases in belos, trilinoscouplings, thyra and stokhos

Motivation and Context

The Node object is deprecated in Trilinos.

Related Issues

#4932 #4924 #4888 #4839

How Has This Been Tested?

On my workstation, with Tpetra deprecated code enabled:

cmake \
-D Trilinos_ENABLE_EXPLICIT_INSTANTIATION:BOOL=ON \
-D CMAKE_BUILD_TYPE:STRING="DEBUG" \
-D CMAKE_VERBOSE_MAKEFILE:BOOL=OFF \
\
-D MPI_BIN_DIR:PATH="/Users//InstalledSoftware/openmpi-1.8.3_clang/bin" \
-D TPL_ENABLE_MPI:BOOL=ON \
-D MPI_EXEC_MAX_NUMPROCS:STRING=11 \
\
-D TPL_ENABLE_BinUtils:BOOL=OFF \
-D TPL_ENABLE_Pthread:BOOL=OFF \
\
-D CMAKE_C_FLAGS:STRING="-Wall  -pedantic -Wno-unknown-pragmas -Wno-narrowing -Wno-inline -Wshadow -Wdeprecated-declarations -Wempty-body  -Wignored-qualifiers -Wmissing-field-initializers  -Wsign-compare  -Wtype-limits   -Wuninitialized -Winit-self -fstrict-aliasing -Wno-long-long" \
-D CMAKE_CXX_FLAGS:STRING="-Wall -pedantic -Wno-unknown-pragmas -Wno-narrowing -Wno-delete-non-virtual-dtor -Wno-inline -Wshadow -Wdeprecated-declarations -Wempty-body  -Wignored-qualifiers -Wmissing-field-initializers  -Wsign-compare  -Wtype-limits   -Wuninitialized -Winit-self -fstrict-aliasing" \
\
-D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=ON \
-D Trilinos_ENABLE_TESTS:BOOL=ON \
-D Trilinos_ENABLE_EXAMPLES:BOOL=ON \
\
-D Trilinos_ENABLE_SHADOW_WARNINGS:BOOL=ON \
-D Trilinos_VERBOSE_CONFIGURE:BOOL=OFF \
-D Trilinos_ENABLE_Fortran:BOOL=OFF \
\
-D Trilinos_ENABLE_Stokhos:BOOL=ON \
-D Trilinos_ENABLE_Nox:BOOL=ON \
-D Trilinos_ENABLE_ROL:BOOL=ON \
-D ROL_ENABLE_EXAMPLES:BOOL=OFF \
-D Trilinos_ENABLE_MiniTensor:BOOL=OFF \
-D ROL_ENABLE_MiniTensor:BOOL=OFF \
-D Trilinos_ENABLE_Panzer:BOOL=ON \
-D Trilinos_ENABLE_PanzerAdaptersSTK:BOOL=OFF \
-D Trilinos_ENABLE_PanzerAdaptersIOSS:BOOL=OFF \
-D Trilinos_ENABLE_Thyra:BOOL=ON \
-D Trilinos_ENABLE_MueLu:BOOL=ON \
-D Trilinos_ENABLE_Anasazi:BOOL=ON \
-D Trilinos_ENABLE_Belos:BOOL=ON \
-D Trilinos_ENABLE_TrilinosCouplings:BOOL=ON \
-D Trilinos_ENABLE_STKIO:BOOL=OFF \
-D Trilinos_ENABLE_STKUtil:BOOL=OFF \
\
-D Teuchos_ENABLE_STACKTRACE:BOOL=OFF \
-D Teuchos_ENABLE_LONG_LONG_INT:BOOL=ON \
..

Some tests fail, but these same tests fail with the Trilinos develop branch:

98% tests passed, 13 tests failed out of 617

The following tests FAILED:
        167 - Belos_CustomSolverFactory_MPI_4 (Failed)
        257 - MueLu_MasterList_MPI_1 (Failed)
        283 - MueLu_UnitTestsBlockedTpetra_MPI_1 (Failed)
        308 - MueLu_CreateOperatorEpetra_MPI_1 (Failed)
        309 - MueLu_CreateOperatorEpetra_MPI_4 (Failed)
        314 - MueLu_CreateOperatorTpetra_MPI_1 (Failed)
        315 - MueLu_CreateOperatorTpetra_MPI_4 (Failed)
        404 - Stokhos_SacadoTraitsUnitTest_MPI_1 (Failed)
        406 - Stokhos_SacadoPCEUnitTest_MPI_1 (Failed)
        407 - Stokhos_SacadoETPCEUnitTest_MPI_1 (Failed)
        408 - Stokhos_SacadoPCESerializationTests_MPI_1 (Failed)
        409 - Stokhos_SacadoPCECommTests_MPI_1 (Failed)
        445 - Stokhos_sacado_example_MPI_1 (Failed)

Also tested with Tpetra_ENABLE_DEPRECATED_CODE=OFF. Again, the tests above fail, along with

        298 - MueLu_DriverEpetra_IsorropiaPoisson_MPI_4 (Timeout)
        299 - MueLu_DriverEpetra_CircNspDependency_MPI_4 (Timeout)

The error message for these two failures is

Laplace2D: Build (MueLu::RebalanceTransferFactory)
MueLu_Driver: preconditioner setup crashed w/ message:/Users/kddevin/code/Trilinos/packages/muelu/src/Interface/../MueCentral/MueLu_Level.hpp:196:

Throw number = 3

Throw test that evaluated to true: !IsKey(fac, ename)

"P" not found
MueLu_Driver: Not solving system due to crash in preconditioner setup

@trilinos/muelu : do you suspect a problem with the deprecations here? Do I need to address this problem, or is it not a concern?

Merge request reports