Piro: pointless #ifdef ALBANY_BUILD?
Created by: bartgol
The ifdefs appear pointless to me (besides mentioning downstream software in trilinos, which appears conceptually wrong, and can open the door to potentially several similar ifdefs down the road).
In particular, when ALBANY_BUILD is defined, some classes (lsuch as Piro_TempusSolver) accept template arguments for LO/GO/Node, and some default values are provided. When ALBANY_BUILD is not defined, no LO/GO/Node types can be passed to Piro classes, and Tpetra::CrsMatrix and enableMueLu are called without LO/GO/Node arguments; however, the default values that Tpetra::CrsMatrix and enableMueLu use are exactly the same default values that Piro uses when ALBANY_BUILD is defined. In other words, there is no practical difference between the two cases, since the user can in both cases instantiate classes passing only the scalar type, and the same default template arguments will be used by tpetra and muelu.