Change many `Trilinos_` to `${PROJECT_NAME}_` references to proejct-level TriBITS vars so that meta builds with Trilinos work
Created by: jmgate
Ran into this issue in @trilinos/sacado's CMakeLists.txt
file:
TRIBITS_ADD_OPTION_AND_DEFINE(
Sacado_ENABLE_CXX11
HAVE_SACADO_CXX11
"Enable C++11 support in Sacado."
"${Trilinos_ENABLE_CXX11}"
)
When configuring without passing -D Trilinos_ENABLE_CXX11:BOOL=ON
, Sacado_ENABLE_CXX11
apparently gets set to OFF
. I thought Trilinos_ENABLE_CXX11
was supposed to be ON
by default. In Trilinos/CMakeLists.txt
, I see
SET(Trilinos_ENABLE_CXX11_DEFAULT ON)
but it doesn't look like Trilinos_ENABLE_CXX11_DEFAULT
is used anywhere else in the project, though a handful of packages do look for Trilinos_ENABLE_CXX11
.
First question: @trilinos/framework, should _DEFAULT
be removed from that line in Trilinos/CMakeLists.txt
?
Next question: Should packages (@trilinos/sacado and @trilinos/stokhos look to be the only ones I can find) switch Trilinos_ENABLE_CXX11
to ${PROJECT_NAME}_ENABLE_CXX11
, along the lines of #1488 (closed)?
Final Question: I'm configuring Trilinos as part of a larger meta-project, where I have -D ${metaProjectName}_ENABLE_CXX11:BOOL=ON
. Is there perhaps a step I missed such that Trilinos_ENABLE_CXX11
gets set to ${metaProjectName}_ENABLE_CXX11
?