Tpetra: Use Tpetra_ENABLE_CUDA, not Tpetra_ENABLE_Cuda
Created by: mhoemmen
Tpetra has a Tpetra_ENABLE_CUDA
CMake variable, but uses Tpetra_ENABLE_Cuda
at one point:
CMake is case sensitive, so this could lead to interesting issues in CUDA builds.
@trilinos/tpetra
Motivation and Context
https://github.com/trilinos/Trilinos/issues/1400#issuecomment-347254034
Possible Solution
Use Tpetra_ENABLE_CUDA
consistently. Don't use Tpetra_ENABLE_Cuda
.
Steps to Reproduce
I verified the issue (which really just means "verified that CMake is case sensitive") locally, via the following steps:
- I added
ASSERT_DEFINED(Tpetra_ENABLE_Cuda)
above the first use ofTpetra_ENABLE_Cuda
in tpetra/CMakeLists.txt. - I started CMake for a CUDA build.
- I observed that CMake quit early with an error, reporting that
Tpetra_ENABLE_Cuda
was not defined.
Related Issues
- Blocks #1400 (maybe?)