Teuchos warnings as errors build errors
Created by: jwillenbring
@trilinos/teuchos
Expectations
Teuchos should build warning free as a matter of code quality, and because of important customer requirements. We are currently using the following cxxflags for this build:
-Wall -ansi -pedantic -Werror -Wno-unknown-pragmas -Wno-narrowing -Wno-pragmas -Wno-delete-non-virtual-dtor
Current Behavior
Currently Teuchos has a number of warnings that are promoted to errors in this build as seen here.
Motivation and Context
We are working to set up dev->master and pull request builds that use these flags for GCC 4.9.3 to protect the code from the introduction of more warnings. We are starting with some low-level packages as some warnings from these packages have the potential to impact packages downstream in this build.
Definition of Done
Teuchos builds warning free with the flags above for GCC 4.9.3.
Steps to Reproduce
The simplest thing to do to test the impact of modifications would be to run the pull request build directly. The Trilinos PR related to this issue is #3729 which shows that the fork
jwillenbring/Trilinos
has a branch
jwillenbring-PR-Werror-1
that can be merged in to test via PR. If that is done, only the Teuchos changes should be merged for now (not the PR test definition changes). Alternatively, if a proposed solution is tested in a PR and passes existing testing, @jwillenbring can test the warnings as errors flags if you prefer.