Skip to content
GitLab
Open
Issue created by James Willenbring@jmwilleOwner

Elevate ShyLU_Node from ST to PT since it is being used by SPARC?

Created by: bartlettroscoe

CC: @trilinos/framework, @trilinos/shylu, @srajama1 (Trilinos Linear Solvers Product Area Lead)

Blocking: #2597

Description

The current SPARC Trilinos configuration explicitly enables ShyLU_Node subpackage ShyLU_NodeHTS (see here. Therefore, ATDM Trilinos builds supporting SPARC are enabling ShyLU_Node, for example, as shown here showing:

...
-- Setting Trilinos_ENABLE_ShyLU_NodeHTS=ON
-- Setting Trilinos_ENABLE_ShyLU_NodeTacho=ON
-- Setting Trilinos_ENABLE_ShyLU_Node=ON
...
Final set of enabled packages:  ... ShyLU_Node ... 41

Final set of enabled SE packages:  ... ShyLU_NodeHTS ShyLU_NodeTacho ShyLU_Node ...  112

So it looks like ShyLU_NodeTacho may be getting implicitly enabled by accident. (We will need to see if SPARC actually using ShyLU_NodeTacho or not.) But ShyLU_NodeTacho is already declared to be PT (Primary Tested) but ShyLU_NodeHTS is currently declared to be ST (Secondary Tested).

In any case, since an important internal Trilinos customer (i.e SPARC) is using ShyLU_NodeHTS, by definition, it needs to be elevated from Secondary Tested (ST) to Primary Tested (PT). Otherwise, ShyLU_NodeHTS will not get enabled in Trilinos PR builds and therefore will not protect SPARC (see #2597).

Proposed Solution

Update the line:

  HTS                   hts               ST       OPTIONAL

to be

  HTS                   hts               PT       OPTIONAL

in the file

  • Trilinos/packages/shylu/shylu_node/cmake/Dependencies.cmake