Tpetra: CrsGraph & CrsMatrix still use deprecated enum value DynamicProfile

Created by: mhoemmen

Bug Report

@trilinos/tpetra

Description

When I disable deprecated code in Tpetra, I get the following build errors:

In file included from .../Trilinos/packages/tpetra/core/src/Tpetra_CrsGraph_SerialWrapperNode.cpp:52:
.../Trilinos/packages/tpetra/core/src/Tpetra_CrsGraph_decl.hpp:2582:59: error: use of undeclared identifier
      'DynamicProfile'; did you mean 'StaticProfile'?
    return rcp (new graph_type (map, maxNumEntriesPerRow, DynamicProfile, params));
                                                          ^~~~~~~~~~~~~~
                                                          StaticProfile
.../Trilinos/packages/tpetra/core/src/Tpetra_ConfigDefs.hpp:131:5: note: 'StaticProfile' declared here
    StaticProfile
    ^
In file included from .../Trilinos/packages/tpetra/core/src/Tpetra_CrsGraph_SerialWrapperNode.cpp:54:
In file included from .../Trilinos/packages/tpetra/core/src/Tpetra_CrsGraph_def.hpp:66:
In file included from .../Trilinos/packages/tpetra/core/src/Tpetra_Import_Util2.hpp:64:
.../Trilinos/packages/tpetra/core/src/Tpetra_CrsMatrix_decl.hpp:5039:43: error: use of undeclared identifier
      'DynamicProfile'; did you mean 'StaticProfile'?
                                          DynamicProfile, params));
                                          ^~~~~~~~~~~~~~
                                          StaticProfile

When I fix those and enable tests, I get the following build errors:

.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_insertGlobalIndicesFiltered.cpp:137:16: error: no member
      named 'DynamicProfile' in namespace 'Tpetra'; did you mean 'StaticProfile'?
      {Tpetra::DynamicProfile, Tpetra::StaticProfile};
       ~~~~~~~~^~~~~~~~~~~~~~
               StaticProfile
.../Trilinos/packages/tpetra/core/src/Tpetra_ConfigDefs.hpp:131:5: note: 'StaticProfile' declared here
    StaticProfile
    ^
...
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:51:17: error: no member named
      'DynamicProfile' in namespace 'Tpetra'; did you mean 'StaticProfile'?
  using Tpetra::DynamicProfile;
        ~~~~~~~~^~~~~~~~~~~~~~
                StaticProfile
.../Trilinos/packages/tpetra/core/src/Tpetra_ConfigDefs.hpp:131:5: note: 'StaticProfile' declared here
    StaticProfile
    ^
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:143:25: error: use of undeclared identifier
      'DynamicProfile'; did you mean 'StaticProfile'?
      GRAPH graph(map,1,DynamicProfile);
                        ^~~~~~~~~~~~~~
                        StaticProfile
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:53:17: note: 'StaticProfile' declared here
  using Tpetra::StaticProfile;
                ^
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:459:29: error: use of undeclared identifier
      'DynamicProfile'; did you mean 'StaticProfile'?
      GRAPH graph(map,map,0,DynamicProfile);
                            ^~~~~~~~~~~~~~
                            StaticProfile
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:53:17: note: 'StaticProfile' declared here
  using Tpetra::StaticProfile;
                ^
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:474:29: error: use of undeclared identifier
      'DynamicProfile'; did you mean 'StaticProfile'?
      GRAPH graph(map,map,0,DynamicProfile);
                            ^~~~~~~~~~~~~~
                            StaticProfile
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests1.cpp:53:17: note: 'StaticProfile' declared here
  using Tpetra::StaticProfile;
                ^

When I fix those build errors, I get the following:

.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_UnitTests_Swap.cpp:415:15: error: no member named
      'DynamicProfile' in namespace 'Tpetra'; did you mean 'StaticProfile'?
using Tpetra::DynamicProfile;
      ~~~~~~~~^~~~~~~~~~~~~~
              StaticProfile

When I fix that, I get the following:

.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_Issue601.cpp:100:52: error: no member named
      'DynamicProfile' in namespace 'Tpetra'; did you mean 'StaticProfile'?
    Tpetra::ProfileType profileTypes[] = { Tpetra::DynamicProfile, Tpetra::StaticProfile };
                                           ~~~~~~~~^~~~~~~~~~~~~~
                                                   StaticProfile
.../Trilinos/packages/tpetra/core/src/Tpetra_ConfigDefs.hpp:131:5: note: 'StaticProfile' declared here
    StaticProfile
    ^
.../Trilinos/packages/tpetra/core/test/CrsGraph/CrsGraph_Issue601.cpp:107:39: error: no member named
      'DynamicProfile' in namespace 'Tpetra'; did you mean 'StaticProfile'?
          << ((profileType == Tpetra::DynamicProfile) ? "Dynamic" : "Static")
                              ~~~~~~~~^~~~~~~~~~~~~~
                                      StaticProfile

I get a few more after this in other tests in TpetraCore.

Steps to Reproduce

SHA1: 2b9c4fe7