Intrepid2 warning-as-error on muir
Created by: jhux2
@kyungjoo-kim @mperego @trilinos/intrepid2 Just wanted to let you know about a warnings-as-error issue on muir (full error is here):
/nightly/hudson/slave/workspace/trilinos-nightly-muir/MPI_DEBUG_Werror_DEV/Trilinos/packages/intrepid2/refactor/src/Discretization/Basis/Intrepid2_Basis.hpp:298:5: error: ‘void Intrepid2::Basis<ExecSpaceType, outputValueType, pointValueType>::getValues(Intrepid2::Basis<ExecSpaceType, outputValueType, pointValueType>::outputViewType, Intrepid2::Basis<ExecSpaceType, outputValueType, pointValueType>::pointViewType, Intrepid2::Basis<ExecSpaceType, outputValueType, pointValueType>::pointViewType, Intrepid2::EOperator) const [with ExecSpaceType = Kokkos::Serial; outputValueType = double; pointValueType = double; Intrepid2::Basis<ExecSpaceType, outputValueType, pointValueType>::outputViewType = Kokkos::Experimental::DynRankView<double, Kokkos::LayoutStride, Kokkos::Serial>; Intrepid2::Basis<ExecSpaceType, outputValueType, pointValueType>::pointViewType = Kokkos::Experimental::DynRankView<double, Kokkos::LayoutStride, Kokkos::Serial>]’ was hidden [-Werror=overloaded-virtual]
In file included from /nightly/hudson/slave/workspace/trilinos-nightly-muir/MPI_DEBUG_Werror_DEV/Trilinos/packages/muelu/src/Transfers/PCoarsen/MueLu_IntrepidPCoarsenFactory_def.hpp:78:0,
from /nightly/hudson/slave/workspace/trilinos-nightly-muir/MPI_DEBUG_Werror_DEV/BUILD/packages/muelu/src/Utils/ExplicitInstantiation/MueLu_IntrepidPCoarsenFactory.cpp:55:
/nightly/hudson/slave/workspace/trilinos-nightly-muir/MPI_DEBUG_Werror_DEV/Trilinos/packages/intrepid2/refactor/src/Discretization/Basis/Intrepid2_HGRAD_QUAD_Cn_FEM.hpp:170:5: error: by ‘void Intrepid2::Basis_HGRAD_QUAD_Cn_FEM<ExecSpaceType, outputValueType, pointValueType>::getValues(Intrepid2::Basis_HGRAD_QUAD_Cn_FEM<ExecSpaceType, outputValueType, pointValueType>::outputViewType, Intrepid2::Basis_HGRAD_QUAD_Cn_FEM<ExecSpaceType, outputValueType, pointValueType>::pointViewType, Intrepid2::EOperator) const [with ExecSpaceType = Kokkos::Serial; outputValueType = double; pointValueType = double; Intrepid2::Basis_HGRAD_QUAD_Cn_FEM<ExecSpaceType, outputValueType, pointValueType>::outputViewType = Kokkos::Experimental::DynRankView<double, Kokkos::LayoutStride, Kokkos::Serial>; Intrepid2::Basis_HGRAD_QUAD_Cn_FEM<ExecSpaceType, outputValueType, pointValueType>::pointViewType = Kokkos::Experimental::DynRankView<double, Kokkos::LayoutStride, Kokkos::Serial>]’ [-Werror=overloaded-virtual]
In file included from /nightly/hudson/slave/workspace/trilinos-nightly-muir/MPI_DEBUG_Werror_DEV/Trilinos/packages/muelu/src/Transfers/PCoarsen/MueLu_IntrepidPCoarsenFactory_decl.hpp:63:0,
from /nightly/hudson/slave/workspace/trilinos-nightly-muir/MPI_DEBUG_Werror_DEV/Trilinos/packages/muelu/src/Transfers/PCoarsen/MueLu_IntrepidPCoarsenFactory_def.hpp:52,
from /nightly/hudson/slave/workspace/trilinos-nightly-muir/MPI_DEBUG_Werror_DEV/BUILD/packages/muelu/src/Utils/ExplicitInstantiation/MueLu_IntrepidPCoarsenFactory.cpp:55:
I think the issue is that Basis::getValues
takes four arguments
virtual
void
getValues( /**/ outputViewType outputValues,
const pointViewType inputPoints,
const pointViewType cellVertices,
const EOperator operatorType = OPERATOR_VALUE ) const {
while the derived class' method Basis_HGRAD_LINE_C1_FEM::getValues
takes three arguments
virtual
void
getValues( /**/ outputViewType outputValues,
const pointViewType inputPoints,
const EOperator operatorType = OPERATOR_VALUE ) const {
I gather @csiefer2 might have mentioned this to you already.