Skip to content

Cleaning up CMake deprecation warnings take 2...

James Willenbring requested to merge william76:cmake_warning_cleanup_v03 into develop

Created by: william76

@trilinos/framework

I closed out PR #1435 and re-did the changes on my fork into a different branch. It appears that replacing DEFINES with TARGET_DEFINES in epetra/src/CMakeLists.txt and epetra/test/src/CMakeLists.txt cause CMake errors, according to the checkin-test script, so I didn't include changes to those files in this new PR.

This PR does implement the changes from the deprecation warning from Tribits to replace DEPLIBS in two ThreadPool tests and it replaces DEFINES with TARGET_DEFINES in an epetra test and a galeri example.

@bartlettroscoe These ran with 100% pass on the checkin-test script, so unless you have any objections, I'm fine to merge it in.

@mhoemmen Mentioning you since you had commented on the prior PR.

Merge request reports