Skip to content

NOX/Tempus: performance improvements and prec flexibility #2252

James Willenbring requested to merge rppawlo:issue_2252 into develop

Created by: rppawlo

  1. Improved flexibility wrt external preconditioner use. The NOX-Thyra support was modified to allow for an external preconditioner to be set but delay the update of the matrix coefficients. This was a feature in the nox-epetra support that never got duplicated in the nox-thyra support.
  2. Fixed an inefficiency in the use of nox in tempus where some solver objects were being rebuilt every time step.
  3. Added ParameterList validation to the SingleStep solver and added a parameter to ignore linear solver convergence failures. An application was requesting a very tight tolerance that was not always met, but the progress it made was more than good enough for convergence of the time step. This is off by default. This an option in the other solvers that was not in single step.

@trilinos/tempus @trilinos/nox

Description

Motivation and Context

Related Issues

  • Closes
  • Blocks
  • Is blocked by
  • Follows
  • Precedes
  • Related to
  • Part of
  • Composed of

How Has This Been Tested?

Screenshots

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Additional Information

Merge request reports