Skip to content

Belos: Fix for Stokhos MagnitudeType (see PR #2677)

James Willenbring requested to merge Belos-constexpr-MagnitudeType into develop

Created by: mhoemmen

@trilinos/belos @trilinos/stokhos

Description

Fix Belos for the case when MagnitudeType isn't possible to construct as a constexpr. This implements the proposal here: https://github.com/trilinos/Trilinos/pull/2677#issuecomment-395467589

I took care to ensure that solvers accept the relevant parameters (from the input ParameterList) either as MagnitudeType or as double.

Motivation and Context

Stokhos needs this for a nondefault configure-time option to build correctly, as @etphipp explains here: https://github.com/trilinos/Trilinos/pull/2677#issuecomment-395241635

Related Issues

  • Related to #2483

How Has This Been Tested?

Locally.

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • I have read the code contribution guidelines for this project.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Merge request reports