Skip to content

Re-enabling Belos tests on Chama/Serrano that were failing.

James Willenbring requested to merge hkthorn:develop into develop

Created by: hkthorn

These tests used a bad norm comparison that was causing the test to look like it failed, when it didn't. These tests were disabled by commits cbb56a7 and 5be802cc, and are being manually enabled again.

@trilinos/belos

Description

The resolve tests were using a bad norm approximation to determine whether the same linear system, solved again by the same solver object, resulted in the same answer. This comparison has been fixed to be the correct norm and exact norm, not an approximation.

The tests with this bad comparison were failing on Chama and Serrano and were turned off on those platforms for ATDM (issue #2965 (closed) ). Now that the tests have been fixed, they can be re-enabled.

Motivation and Context

Belos tests were failing on Chama and Serrano, now they are not. So the tests can be enabled again.

How Has This Been Tested?

On Chama and Serrano using the very useful instructions given in the issue report.

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Merge request reports