Skip to content

Domi: Fix config bug with clean branch

James Willenbring requested to merge wfspotz:domi-tpetra into develop

Created by: wfspotz



In domi/src/CMakeLists.txt, I needed to change Domi_ENABLE_Tpetra to Domi_ENABLE_TpetraCore to ensure that the HAVE_TPETRA macro was set properly in Domi_config.h. This pull request is similar to #3731 except is based on a clean feature branch that cherry-picked the pertinent commits and ignored the commits in #3731 from an accidental merge.

Motivation and Context

This manifest in PyTrilinos, where Tpetra for PyTrilinos.Domi was enabled, but not Tpetra for Domi.

Related Issues

How Has This Been Tested?

I tested this by running the Domi tests and the PyTrilinos tests. For PyTrilinos, I had to disable ML in order to work around #3456. The error really doesn't show up in Domi tests: Tpetra was always improperly disabled and all tests passed.


  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Merge request reports